[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 08/10] drivers/char: mark DMA buffers as reserved for the XHCI


  • To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 5 Aug 2022 09:05:27 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ptnKYsYaxIVJBuhKFvpn/8js8/bBe1mvTq4ZLb2YokQ=; b=O5etydUjJ4MuMhlMUEO/F8xyQDdn1iTelZHm1Vtw16Q2NoujCMo54IgFe31hEy10oXdHXYrnkS63roeaMt1rHs3k3nFnZMPO6phG+8xN18XFQRf9devSelAnrVVn1Q8Xznpoc1V8+y6K/DS0H8Bop7r1vOvZoYiWMTe/gDGsufwia4GPJJNPp0Y97WmQ7eOQSeCEwjfwG8k8PHA9EDLYyK7gLtWrVxdxQsV8psBy56zOZ5Q8+tgUkF9CAXbcrNExkic4rslbc/JplUHK7O1yJOHdlmuhVXfQ957f/Ixcl/AZl73dzgH+5GDwcYR49O4av3PhVFI12bUHnYBBHMaFbQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sd7aLK9jDcQ3g1wMdH4fg2i/elsw93Wh77M0s8e8TJX8edJocAK+mqLCTga5DykK13bMgJdbIleHnTsg7WRejp09cnoII2sfmRQH1rmKas9Lf4I+vebLwoCY6ew+5ZZQ5a1zTBkGqsLxxHpoFmVTba/9inQISR0LxLJIipeJtsd0cHxmq7V9+vXEbS95Hme7piskuCPrJk9PYy2UZdajQ0Ceer/EBRlZxbRyJ8i/yYYKVMFpH3FIzENKb90k/6w4yk7AyvGTTgnKr0yNU+1Z694m0IVT+eLxGiWcmKmmDVaN+7SrR991vKQ/0Pn4yKvPYkc/J6SJqTUKFtUlcHs8Og==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 05 Aug 2022 07:05:46 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 26.07.2022 05:23, Marek Marczykowski-Górecki wrote:
> @@ -1046,13 +1047,20 @@ static struct uart_driver dbc_uart_driver = {
>      .flush = dbc_uart_flush,
>  };
>  
> -static struct xhci_trb evt_trb[DBC_TRB_RING_CAP];
> -static struct xhci_trb out_trb[DBC_TRB_RING_CAP];
> -static struct xhci_trb in_trb[DBC_TRB_RING_CAP];
> -static struct xhci_erst_segment erst __aligned(64);
> -static struct xhci_dbc_ctx ctx __aligned(64);

Why the change from 64 ...

> -static uint8_t out_wrk_buf[DBC_WORK_RING_CAP] __aligned(DBC_PAGE_SIZE);
> -static struct xhci_string_descriptor str_buf[DBC_STRINGS_COUNT];
> +struct dbc_dma_bufs {
> +    struct xhci_trb evt_trb[DBC_TRB_RING_CAP];
> +    struct xhci_trb out_trb[DBC_TRB_RING_CAP];
> +    struct xhci_trb in_trb[DBC_TRB_RING_CAP];
> +    uint8_t out_wrk_buf[DBC_WORK_RING_CAP] __aligned(DBC_PAGE_SIZE);
> +    struct xhci_erst_segment erst __aligned(16);
> +    struct xhci_dbc_ctx ctx __aligned(16);

... to 16?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.