[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v9 8/8] xen: retrieve reserved pages on populate_physmap
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Penny Zheng <Penny.Zheng@xxxxxxx>
- Date: Tue, 9 Aug 2022 08:58:01 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qc/J9r3AaJPnUqwMqXYwWHPL/cC6vYuHrNbRr6+mLwk=; b=R6rwlQbBt6Wef26epROddVVyBmJDKvmGAb1zNMaGjY/6TAPv8r0wY1RqVx8BWOno6dqHvIiIJPNfCvNTNzxkIWJgKKbWk1wF+7UhFDl9PmVDtw48xJhitMh2lZICjbN5g3+mZRB4prT/vLU9ghVqheaE7RIRZ7PPighIUa3RU4vLuzMqRH9r84O4q6lxvZHydd5FpVGTd/3u2b09FPmmEklsa/WlL6bOWovBV6fuAzAisDsdmMOw3C6YiqDjjwwF//7A/gv2zb4S7QHrgB2g5IbnGgVQP9bWTsy2w5tG9hYQ8IK3Yx5gIGcYBz253aDwbcJqlSOIzjLh/JXKs6KW9g==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qc/J9r3AaJPnUqwMqXYwWHPL/cC6vYuHrNbRr6+mLwk=; b=Q55+rtkFZtUAnvZNw8P/heCHwJnjKiKTkX5GGqvCQ+GPljoyLdeQdDHMtTzbEco5+bdGyJymhjVsZUr0ifPIRq4POmkMxppEZn057sHlLjbSBgVJqQVqjWeh7vM62P296uUJMnDKUWKDF5ycyuOQnwIde/n+y+RxqwTuKDHdGs4iyZxj/3KQKyXVVmrzHLaFaZiGJ/ehtCu6wy12BJM0yD1tXLDgvIR12jE1ttf3O/7do/k5h9HQ7dlrhIQT2AFSsyulNCWZqRsMFnhIDAxETGdFI7wJ9TJq2XLkNn2EKxbtVqbIF9msV4j+jn2GVDao+tN/Xw/KP/a7MLekwMQLFg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=klJvBe3zNawfiBdj4JGhD4DO3oVo7wHSEeXoCQZV/OIOVsh8EZJ1cRh9feodjZ2dBlLQM5KcacCQ7+KyjH9ssPiqIIdo7zCvu3iwzf7QpNq7WYc8T2HaVwpMbZbkotg+R/U42YgrD0it7OEU6rZUUhh0UUYXq4NBja94IU5+A2prIwKylbMeFWkXcEdZkogRYzL3HMFU4XGFy/xSWCaAKkS/qrVbMkVkqqhdo9M32prM/FnhW84ShjmkKjsEgf62Aj562L4j+bIrmfI2Sh+VzPMqE5B109H6QmcOftA4hehuyiRGwQ7Pa4DkVPmPjXZFOIb4OmxKh7egBHAvqIg5Qg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aEL9CJrEVZ59hUOXP34OGOhmQHBXz6sMrw6q8jOl54CbdieH8trT9NOKEf6OU8dOJxk4f28i4SrJx2hGAVey+CdJhJsEm0pDaqJpaEEJC1NwZqyX6LYkMgPmnFSaD/bjok9iJxUt81zTm1/+WbCFQHoOs6NpHVZsPPzG7OuFjpIWlDEtn88uxm66rNCMXCJMgUMQ4o+LFhsp5bWQ9aGZ27DxASItknNUzvGlwaQMUmtBdxJnbtHFB6Djk8mzjt9Zb32lwkAJq0n9ZCeLnmA8w7woti1pEeZG6jQrMZBZF9YSxyS+K5tviYQZ67cBg2cIPks+8yRTMeW+JZ3RWULvSw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Wei Chen <Wei.Chen@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 09 Aug 2022 08:58:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYm/wqv1nrEHMOJUyQDyAePQJHla2PQtqAgBcOCRCAAALrAIAAAXbwgAAGY4CAAAYCAA==
- Thread-topic: [PATCH v9 8/8] xen: retrieve reserved pages on populate_physmap
Hi jan
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Tuesday, August 9, 2022 4:27 PM
> To: Penny Zheng <Penny.Zheng@xxxxxxx>
> Cc: Wei Chen <Wei.Chen@xxxxxxx>; Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>; George Dunlap <george.dunlap@xxxxxxxxxx>;
> Julien Grall <julien@xxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>;
> Wei Liu <wl@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v9 8/8] xen: retrieve reserved pages on
> populate_physmap
>
> On 09.08.2022 10:07, Penny Zheng wrote:
> >> -----Original Message-----
> >> From: Jan Beulich <jbeulich@xxxxxxxx>
> >> Sent: Tuesday, August 9, 2022 3:59 PM
> >>
> >> On 09.08.2022 09:53, Penny Zheng wrote:
> >>>> -----Original Message-----
> >>>> From: Xen-devel <xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf
> >>>> Of Jan Beulich
> >>>> Sent: Monday, July 25, 2022 11:44 PM
> >>>>
> >>>> On 20.07.2022 07:46, Penny Zheng wrote:
> >>>>> When a static domain populates memory through populate_physmap
> at
> >>>>> runtime, it shall retrieve reserved pages from resv_page_list to
> >>>>> make sure that guest RAM is still restricted in statically
> >>>>> configured memory
> >>>> regions.
> >>>>> This commit also introduces a new helper acquire_reserved_page to
> >>>>> make
> >>>> it work.
> >>>>>
> >>>>> Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>
> >>>>> ---
> >>>>> v9 changes:
> >>>>> - Use ASSERT_ALLOC_CONTEXT() in acquire_reserved_page
> >>>>> - Add free_staticmem_pages to undo prepare_staticmem_pages when
> >>>>> assign_domstatic_pages fails
> >>>>
> >>>> May I suggest to re-consider naming of the various functions?
> >>>> Undoing what "prepare" did by "free" is, well, counterintuitive.
> >>>>
> >>>
> >>> How about change the name "prepare_staticmem_pages" to
> >> "allocate_staticmem_pages"?
> >>
> >> Perhaps - if what the function does really resembles allocation in some
> way.
> >> So far I wasn't really certain in that regard, and hence I was
> >> wondering whether "prepare" doesn't better describe what it does, but
> >> then its inverse also doesn't really "free" anything.
> >>
> >
> > Hmmmm, “prepare” with “destroy” in its inverse? Do you have any
> suggestion in mind?
>
> To be honest I was hoping you would make an attempt at finding a suitable
> pair of verbs. To me "destroy" is more the opposite of "create", and I'm
> unable to think of a good opposite of "prepare" (short of resorting to
> "unprepare"); if I really needed to come up with something then it would
> likely be "cleanup", albeit I'd not be overly happy with that either.
>
Maybe unprepare is better here, I was searching linux code for the help, and
they are using prepare/unprepare as a pair of verbs a lot in drivers codes.
For the renaming here, I suggest to fix it with a new commit, since
free_staticmem_pages
has already been merged.
> Jan
|
