[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/11] x86emul: handle AVX512-FP16 move insns
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 11 Aug 2022 08:17:36 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nDPgYLchmXejmk6IwI4ANwZAwXgkwnGeHSKr3HPchTI=; b=nCy/ZF8M83xvr4zNhWCSUXizGS/404JXGhWDImN7IJu7EB8SEkvKbb5Mj4L1xxS4qY2O/hepUUy+2Nvf3EQlFt4RkACMq0+9ym2a6F2sYVFKEb7REkX8IV3Uxg6hOUWrz2vnqz2EyXRyf+4NcMsGV5LLUWIlhpcbdYYR5UENURRP1+P4tDscpPJd6LGOzAlmFNXltqtj6YdFsYLOK/Y1FNCn0LX1XAyGQrTLoc96/2w/vL3ZXBoWYgmGVWZF/wF3rT76mIlOmtAxl2ZIeND0ABFLsdb22cdB5lAS7ACyOlzDBPFxkm0rBJS95Zzgqh8rVUyVMOgVbQ61Sg7Iiiu3iQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JFfxjRZmrplYfR3emNxbaYMh6Gxm5+lAp1Mtg1zjXJOimuXkEQ6fUMVsqN1+e8lL3WFVzBM7pJyp6tkv0lioacQdZUULWyHNJwB4FQYs+dKskeLokjN7/9cKa8TMRPk87iJHTfFRBYDSlBuYycXOwKKwTFY60gGBirLJBc6UpfA7cxkNDryiJyCM+RP03RtPBLDb+IbLGQ+7RxgjdEUJRD+wRUgD71cclfRWxOfhVYT8WEnBVM/B3mhCdkr9/HgsnxWqPRrqww18GoXpuc/gmv7rIn8ETFmStkIxlfwfFUiQju7VYbGUuQNafla/xNcGi2myOLsMYI3UF+87ZHal1w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 11 Aug 2022 06:17:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.08.2022 20:04, Andrew Cooper wrote:
> On 15/06/2022 11:28, Jan Beulich wrote:
>> --- a/xen/arch/x86/x86_emulate/decode.c
>> +++ b/xen/arch/x86/x86_emulate/decode.c
>> @@ -585,7 +585,7 @@ static unsigned int decode_disp8scale(en
>> break;
>>
>> case d8s_dq64:
>> - return 2 + (s->op_bytes == 8);
>> + return 1 + !s->fp16 + (s->op_bytes == 8);
>> }
>
> This hunk looks like it wants to be in a previous patch?
No, why? It's VMOVW which first needs it (d8s_dq64 isn't really used
very much). I could have put _all_ such adjustments in a single prereq
patch, but it seemed better to me to make such changes at the point
where they're actually first needed, to make the connection with why
the change is needed in the first place.
Jan
|
