[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/msi: Switch msi_info to using pci_sbdf_t
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 12 Aug 2022 08:45:05 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1XAPlaUOVTiIfPopHk22cvy56SQbCWm4+1p/oKN8q4M=; b=ZnUbzBOeo2F45FP39Dsfmww6oFvxlSNPpwpolLDEvsHhMxMCGhtS/sgLEAs/wrrEsvo9xz9SbSoOsBnSVNxZwuAvq0SCkP7wZqPmkgx2s7rWOFoOdG1eSoJVO/ZDrxlc/Aigg22Q958BsInOW4a+2E/h2JOxtIt9iy4/Qabi+GuPriAcGCwVVwTZYQw2qeAOfioY1xO3BcJ1L5XvMzRbUzn/tfgFpk87k2bfU+gklpDaPRed4KxrZ2vHB5C6XZ7tMobdxPO+MUYbJ72JWz3UwNG5EXu1WGh4adE66XfnKo4pAWNVcqCeEuVItdWsxc4Kuljkz45BjQWOJprpVzPR/Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BVXicpdb7OUvPlYN83sNhPDF6mTdYyiSgY/cYfJQ0S/4cDbvibIHoksfFVKJ4Wb8QrQYFcIujM0njbboDKEdaEWS1uV2o9PSCow6zvkmb87Wa1hucHtK+PfrWr/npgrPBklPTJcNK73tyhaL1Xmg/vhAoeWEdjfHFj7u7t+i63SnGj0lVo+K/ZtRsg1gqs738EEWhe29SLfrz04h1ncuwAwsSfwz06o7+iYSFBXdjqYHVsAbDLmlEt6jlSpP27oP/HpD4LjrE8avoLA6/1ZI2MezCUizMqlVB1ubnbXupIrX7BqNWLn2MUN3IfkQlr9oug3QQ8ak7LvFEbC3DMUsoA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 12 Aug 2022 06:45:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11.08.2022 18:37, Andrew Cooper wrote:
> This reorders the fields in msi_info, but removes all the under-the-hood
> parameter shuffling required to call pci_get_pdev().
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Oh, you've made the requested change yourself - thanks!
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
While not the primary goal as per the description, I'm particularly happy
to see ...
> --- a/xen/xsm/flask/hooks.c
> +++ b/xen/xsm/flask/hooks.c
> @@ -918,7 +918,7 @@ static int flask_map_domain_msi (
> {
> #ifdef CONFIG_HAS_PCI_MSI
> const struct msi_info *msi = data;
> - uint32_t machine_bdf = (msi->seg << 16) | (msi->bus << 8) | msi->devfn;
> + uint32_t machine_bdf = msi->sbdf.sbdf;
... this open-coding go away.
Jan
|
