[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/msi: Switch msi_info to using pci_sbdf_t


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • Date: Fri, 12 Aug 2022 10:22:25 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VkWM/VENhM/uTnPmoiN2dQjsGAICGS3Kb3d/rvy8paI=; b=G6k9tdWXGY8rqS84VVguBQuOYrCITRvw2GpC1OGrnTD14rHL9GyT4lSCn6vPuFmbvJzXDKgfeeyVJ2VrVaK2CfpPKPFZNmPvPTxBy8BKBoKsTtFKtq8c6birHfjACEgqpQAMUL6xasVcYBM3X2qdrbiUXvhffjBWIH1kFktN/5olVpLKdMhf6OjUnpXRY3ZroSKlupiirdRl9eeg1ECWd9Ukpp1g3BRJsH4vclHH+ATxUeBDrEERyK0ghiul4Qw7vFy0ZTDUAl+Iw2z23DRQRTA/ovA37uGWockG/XiAKi9CkivSNn5rE2aR+0rN1IOvAp540U5iuu6ryAtB23dtiQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ACGsSNwtkYOM6DWTGlt6EfM6aS1GLL16gaxUXqEAYPMDfdvR99ieiWjF4qi1vmsh2kaebtxcvmu1YFE3u7+rjLph4Cx7Xfw2aoq2QaWVZawYOLhoVwabIsachKUDWn6zYwvMhvEsJlED0m2M04BBBpWdcVHeBG3Jh8jGwcFytXid3Ox2ugjWOXd945ll7yNCg6h99TPiR/jE6mbTxu32GLAXqr9W1kIVm6Fx2XbBOOGcjgNMa7rXPuIIIYHeNWuS0X1zgYqvY1CsENhyL53SU8y6B90Q777aI0J8P5bLyjQC1e3Czv/kp0s481MHsgt5d1DqrJyvYQLGT/DsFMA8Gw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 12 Aug 2022 10:22:41 +0000
  • Ironport-data: A9a23:T6NVXKktzv/VmE5PYL9QSFzo5mJPLRO4T7NN2KgyY2vmR7AEGURwNzJs89viY1XMGPRfL3Py3WupzRYxVX4lji++r92TOSDQ9sz0v5ui+AYdo8p35YNINiYNwqifp0DMlqbu0vX3w0J0ZQ1mKKGczYTfCzpcrik6qLoy99qJoNBFhWB/NkawKX5/c5yZDssTevAtRAUBmpLnJe3rGo617GDyygE48hLSnbZ4qIzjP6Hy6QRBBnTUm8rb3cZQHQ5G1RoFBOjQqJF8i+HfPw1jL++are4xUN+ob+ZtZ7paJBa8cy91f35kZlWd64HsuqiiOycm+75YhDMQS8arAwRSlhR0J8zVRfTP7qnVSpk4GboEqBs+N6SZxYr7ZMaljG6wxgo2lzJATy+tt58VwVUEuvuxYHyuudqglvEsflkSuTNMED1rjNvRRzEfegFTp7GsZazsOFxWYvMZ2PquPoJ4WWNqVTUfFOkhKTsLyau5dFL9jdICZioAzw3NisET0hl/M3nzhvFQzC4qDGyFSxoqrGy56zSzcEUEzsP3v1Eczi3VmBW1XQ9G11ypNoPPCAijHf94PafkaGprd9FFF02aNlvzGznCMW2fpXKJDjVix2Z5CQ0ZacLC+pgTxmVBXhUly59ht9hiPqBpCO6wK9wwD+nRQV01jbNX9OwAw4URtbcDu/+WXaCshoYh8QI+tRwWxaDX0oiwUCSYtcxsNMs0PNFI7Rf/P8Z51rgV395cYNgTHwSn345i5OHWpIaqR/E/OweBs9Ao/n1UXspvt/G9m5UNuzCyxjj+ZMKYoBsEW/rdusQhSFzJOY09F/HoPy5HjyCO9dnseWxk6R8iWJZPGJMqUVA3NeKk0qndWdzVk0G4TWulHg1QKlJHKcjeizMfYQJ3AGLj7L5oqaX1yLXUZFhmLDWi72smSYAkXuXskHFyw8YwkV6ScHJbk3T5M5hCIAAgdJ8XojNAFqku+H8mkG0YFvPfnTxlJGFavMWI+dFgU9m54Nap1iyGUyXoJx12B4JUeBExg60qPbWm142Ic3RZqhS6shljmTuTUsWOo0OkiIvl3q5lWiYe1iIG0Bcs8uuMqqFXa5y1RhJJxlxWya/FdZmO7E7wmwNmNQ7Ib17IvdtWVNR3p4O0D7C5sqVS0m8Tzr3zuAbGeaGCxN2mze9isY5hBOFvk7o0oRpTPvKF/vLrRCx4yUtd2VfcRtIFDBZBvXfZGOBCWOaFhRQXzsKZGyEtAa19irFGNfpKk1ya7hmRs0jBt8X3jGwzxSUfgkcZ3X/+RlR7qlsp2/bJikoHN9+XRUQ2aHCzrq5CCLTwVsw8p3cKtJGjfh3VtOV+5iCFshI1SvSx8t3OJ4xL13man89R70YZoI9sYh/G23k6fr1YoMnoqzC8LxQkxBjEtsmj3Q/tFJWaZTh4GdfXJ5LTj19SBdLZpUgAustoU1mO4o8aOs3Sr95G+Tq/V0RPHJ78TQ145Og6GfvnJEa43Ebs/Ge9lz8uMik4HT0E0U7BcnqNcu+0fbuWQ+VKvc9IPbm6pS5wft0WbZrpRTzMTC+SRReVzn6Z/34Z+JToOyqOPU4xwajfX2OcIelQ16Fx0eCKk+H9spoyapkb/3VLY7x8jAe8bZNa0bKnYbVPss5QcyfnVBNS9h6mPKEqWoLC/FexAFeDe5OCEC1rQY1etxqiap8y5aaDKT30q4GLDmf00/86Sa16rboPqFk8r10lyvq7g2ZXtJp4sDtic/CXM5r+2cG7PnrIsy6hJks4nN9eetUjiadB8jaHzLEGwIRwkVdD0vVFmY6sjPty/k8h9JvpjsEgvOaRaJ82ti23LjTj9R6KIog+kXaewdV0MB8N6CKmNKcvPISaGGqUUVydTvTE1uchD/vZ7joPGzH8k/DnSHIsp+WP/4SPYVDo8WJNTchOXR4WKRGA6PvIRiWXWoUUeX66NTFTy7gqH3mwe86tJvq4DyGZNMNQP8UH0S1oBqlIOgP88nKoCHyCcQQXJSvHG5jnaBzvx63EkMzkl2v9PKd4cMt7vXXMGZs8v6agXtqyJaSZ0N6zt9LfqLk1mrdmQecyIdvfVkcusACSElvIQN4uclhs0Ck7/pkYKkHSfIXbob8HAQ5iVYlfuJSftLkbNT7uAtx6Ev9PRDHik+xTBTpomDRikLnixZa6BLbIoFHeJpEHzEXFzryNMuCRKF69lnowm3NI7mkWq4JJJOjUjxKTqbYsKs317ymvYTwALtFQ/XhhpdS43+ttyJ11rrYRxn+ZBPOtks/ra0WbjzU+CVYOQKF7Yl3JYY/7F0+4GBrOJXdn2VsP057FJUe25B8hBjDL6js=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYraDAO1BrPwl+zkW5rB84Wzymza2q0tqAgAA8uAA=
  • Thread-topic: [PATCH] x86/msi: Switch msi_info to using pci_sbdf_t

On 12/08/2022 07:45, Jan Beulich wrote:
> On 11.08.2022 18:37, Andrew Cooper wrote:
>> This reorders the fields in msi_info, but removes all the under-the-hood
>> parameter shuffling required to call pci_get_pdev().
>>
>> No functional change.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Oh, you've made the requested change yourself - thanks!

I looked at the code and decided it was simple enough.

While doing it, it became clear that uart->ps_bdf[0..2] is in desperate
need too, but that was more complicated than I had time for.

> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks.

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.