[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 1/7] xen/arm64: head: Don't set x22 and update the documentation
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Mon, 15 Aug 2022 01:36:19 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MD9AcI6josYGeCEXq7jU3pVCX60dvpLBxZ8R8+chxXE=; b=b/F2GHnbtAdmiJn85/ajUyoks12POaBhGrtFsMeKWLzIg4rsmxzNMDTTv9l9Lz196SnP4qcv+EDRarGailURTTPdIxtOb95/zbAhsN2dBOtXH8f32z4Sp1ctz5wDPHEaByq+W1CbcUFb4v1e6wNuW55ZjAwAz1GRMKCKnG1RIc1UzS8BxFJhFdf3QUWi9TbxQlbhR19r9SipsNtYnDMmeKMVtzDtaM59On6Qvd98aTvik2irVWHme1w/eIvEIxGquEtaW1QuuYnkyGKnA7EI5XANPekKwKyLEqDNOPvPGnlzBjSG5bzB2q9ZsGlvdk8e2V5N/T6d1Y6atT3F6OWs3Q==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MD9AcI6josYGeCEXq7jU3pVCX60dvpLBxZ8R8+chxXE=; b=Sma5kT+se81Bq613TGsAmwi181BKtM7O3fQOADoWWDqZeIq4ywIhexYMVSHdAYG6JfWWJQMXEAABQat6kxaMg4VvyRMWw3mO3ta424tcAuIC8Ju9w8OceowiW0OO/LdlVExHVAHH2xOp2HWTKjL0SXMbQQ2EHbW84oXhBK/7f8tL5/VFUntJN7jiDmj47Z1IpQNG8bHbl9wBd8xvRjeiUZVmPjvksOznGaauMXsVrfRQbuii1BtK7mvFuKODxp1BB/NV5crihlsZwyPw/eHlyZ8QaWxOj1xm+zB24tv0bGnazLPTq+CiFHJ1GGmdRCtvP7HKZ6VHC0lXAddszcy7nQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Dz4+W5JwG7JAZzh4mizsH1ZW0CyapJiAK85cwJi2V+MNRCyc/Nw2B6W7CNwibUkb8c+vuBnylDuDPSJiMnf0Yl+JtLdbLpRwMLW8DuIr5ATQbTR0epbcyOZSd7BJI3pXmUZ8QPgfRrBRhjjxBBh1HzyOxb3/g2qOa34hPOqH6zdprvamxLQRd1TRV219+B0EW2D3ugufyKWjSwV6Vjzh+FOFoBig+GT5X5WWyEY+yVU5kbJrJZSHFYvno6Yihxqvco/7XRsmaSI2kNCHDmHsCkERzL/ppgeENEbmg224aNukIigs2/hCPv6mJL6VBHdJ0vFxeghtPoXCl17DIuUbbA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=becSCRteeFBhrzDXkznofgoYbwAJKG+FyH7oCB/B9oowedY3Dz6SkLMwq8PjFX72dCBpwyzFtPscXwhP45SonorzyEUBOo6/tEGB2MNMnBHxkAgs70LDlNrk3lLPm/AeuuxXct5jhgnDFmeHKzhQhqQoBp4CmEaxi+pN+e84pkD19jQTy0x5xlbnScECF4VpWhcS01/oG7aG4+ZjHJ2wjiOa7vWCO51qU6o+7C8xbKGFKMNYVp+Z9Ccoy2yMfzXZP7z+RTIRsr3hwx/wAKjpnRoBWsWKvhEV0snpx0gAb+iEPBcSeizSeHAiJENZISisHslDZagBY5cGxMloG9KjHA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 15 Aug 2022 01:36:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYroFIQn9s3NohHEWvCLSRgBfZSa2vMCzQ
- Thread-topic: [PATCH 1/7] xen/arm64: head: Don't set x22 and update the documentation
Hi Julien,
> -----Original Message-----
> From: Xen-devel <xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of
> Julien Grall
> Sent: 2022年8月13日 3:25
> To: xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: julien@xxxxxxx; Julien Grall <jgrall@xxxxxxxxxx>; Stefano Stabellini
> <sstabellini@xxxxxxxxxx>; Bertrand Marquis <Bertrand.Marquis@xxxxxxx>;
> Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
> Subject: [PATCH 1/7] xen/arm64: head: Don't set x22 and update the
> documentation
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Since commit 7e14a47e7c73 ("xen/arm64: head Rework and document
> launch()"), the boot code is setting x22 but not read it.
>
> So remove the two instructions setting x22 and update the documentation
> to show x22 has no specific purpose.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> ---
> xen/arch/arm/arm64/head.S | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index 1babcc65d7c9..26cc7705f556 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -71,7 +71,7 @@
> * x19 - paddr(start)
> * x20 - phys offset
> * x21 - DTB address (boot cpu only)
> - * x22 - is_secondary_cpu
> + * x22 -
> * x23 - UART address
> * x24 -
> * x25 -
> @@ -305,8 +305,6 @@ real_start_efi:
> #endif
> PRINT("- Boot CPU booting -\r\n")
>
> - mov x22, #0 /* x22 := is_secondary_cpu */
> -
> bl check_cpu_mode
> bl cpu_init
> bl create_page_tables
> @@ -345,8 +343,6 @@ GLOBAL(init_secondary)
> adr x19, start /* x19 := paddr (start) */
> sub x20, x19, x0 /* x20 := phys-offset */
>
> - mov x22, #1 /* x22 := is_secondary_cpu */
> -
> mrs x0, mpidr_el1
> ldr x13, =(~MPIDR_HWID_MASK)
> bic x24, x0, x13 /* Mask out flags to get CPU ID */
> --
> 2.37.1
>
Reviewed-by: Wei Chen <Wei.Chen@xxxxxxx>
|
