[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH 7/7] xen/arm32: traps: Dump more information for hypervisor data abort


  • To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Henry Wang <Henry.Wang@xxxxxxx>
  • Date: Mon, 15 Aug 2022 01:40:23 +0000
  • Accept-language: zh-CN, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4th/mCebd/QpOjLG0hZvSB0Lj8WRj7xm5gAcknz7osQ=; b=XRlnGOUNuTnpEqNoglOZAj8xvUsV0N62FM8WZHwRrens+NfocEvngZxf/jA16eBCL3nJS7bnw1vjbgx2QHww9/xaYXwSaBKYshxcfOfPKCUNGZuUOUejz8pw1JbHQtcfUlztuDO8awklh4PVniZhUNjJOf8AKwSMf+QZFomZT39wlVZiNdCB7RfOwsAgbKxEEof6t3N09TIWfzIBx2NhtR0HOEu4idD2nVHQ4mbOnw1td50J5RDhTCffRy/0qVJ3T0VMjIRyiHpQ8R+ZghyYxLBVsWMT4BicULJWOvlEJ7+0LD5yzoiNCiTeLywFYSPte4j7FaP68ewXGHRCbo2OCA==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4th/mCebd/QpOjLG0hZvSB0Lj8WRj7xm5gAcknz7osQ=; b=hf7qhhFNBCw50qPmBV1hVoPEEuLLu+jWDhaNEO5BMT24Upq76TdGPccfX0Z+6yuQckytSTH0lElfsONWvm4UBtFWi9Q0PtJ/5HbSibVzNxCrjHK1TWMTkMXzUgK/E+iLrNqKeIWIlr8/KPbIpjU+myGOlXz4QeSsrKZAb1KhgM4gckplE/RWD6r4tz/p+AP/RQ+G/GmwFu0Qg2NPR9RYv86DvAEO539cNTWg/GTX8W0xQrswqvkCjGx91Z53kj98XHf6a7lJU2H5oSM42kS5aCySApJsWcymvcyvJPe8IKwW1DafgIZssahZ74SgGZWEYNYv1O4AiPupv7ihvoQgEA==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ESNy8S0Y05FdZ2D4HHyZB+In2OiKPkOP86nRyRIMPk5LnPIbXFi2HxkBUAqMLUKzqQ8hQBiusdHI252G93QKqMfELgQOhGAr2fas9Yc3lAX4X7zezds6qVZpija7ios5n5/eb6rC54mXApK8hLRRLXWcSWQ+ZiZK+E5uVt7UFfeOdCKzCzr3SJom8BmCTZ5KVzQP4nAsIgzgaPu6n6j7K2rc4Nj6GmplGm2gcMRuNI4p4lL7Zr7rLQ0pnkqYOLoYdfJZJ7HHvS6TiybLemINtLrUoYGoIvTEaZo9HHgplgBQwRfq4iTK937ZNdppSuxN4VXbeocXnayiOR5X4CaVxQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nWyKArihc7HDBfFYXcn5WhWxt5CH+nVhuoAgmfeheBjp7rSHUqrSxKbLYWltTF/BdG2O5QoJ/mvIhbwtxifDbXpqHBsvCwfwt/0WFBiFR1TNMaa5bUBPxWmKrCu5l4PFpI9TU4gC9hyAnxWofShxjrdMnwn2YW1uEnnzWTgPEGY6djQd9ltCNh0MvJX6+trRqZmgzPCQo8oaE4UmlQ0PVJuiIYSRpQ9S0zGJle6PP8H4YPwWGNJ8r9WWZqS0UTHZ25W3y9v+ZzxYBS3jXDDNE1lVMEmR0fyEL/67A/Q+GaIdynrgr0E5fO2/Ff1uwg98cre8FGusWck30ZxsiCCUDQ==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Mon, 15 Aug 2022 01:40:39 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYroFOVyqyQRSbhkS8uh6wKmYB5q2vMYiA
  • Thread-topic: [PATCH 7/7] xen/arm32: traps: Dump more information for hypervisor data abort

Hi Julien,

> -----Original Message-----
> Subject: [PATCH 7/7] xen/arm32: traps: Dump more information for
> hypervisor data abort
> 
> From: Julien Grall <jgrall@xxxxxxxxxx>
> 
> Unlike arm64, on arm32 there are no extra information dumped (e.g.
> page table walk) for hypervisor data abort.
> 
> For data abort, the HSR will be set properly and so replace the call
> to do_unexpected_trap() with do_trap_hyp_sync() to dispatch the error.
> 
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>

I think this patch looks good to me so:

Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>

But it seems that there is a duplicated patch at:
https://patchwork.kernel.org/project/xen-devel/patch/20220812192448.43016-10-julien@xxxxxxx/

Kind regards,
Henry





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.