[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/7] xen/arm32: head: Move earlyprintk messages to .rodata.str
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 15 Aug 2022 10:21:44 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IGteyt2N4vJhcIfIwaIw/lKsxnkpy/uYQKr1uq4J/sE=; b=P3ZxH05R57/5I4GHQu82oJw3GVd68rkUJZDgPsC1yoDidkObCGCGBTH3n/of0P0XpMHE6leQjwnjlFOyvbb2Al5/MGillH/10oiVL/df5sWoaiDOp70XM9k5lNwHFJI8FCJm3gL3xp1Fc0Rsg2xBlAqNNOhm8chOSirN1SqX6q/3BbqEUfio1xwVuKGEczxXSZlBPPW31/NAgbWxw4O/OCh4w4+lXCEAw3AJBR8ggTpyEu2LKhnEdODkBqCV+iaE6ENnYZfIr4Myp8U+iKZM9zUqXxqPfpCnMXqVzgoTi7vk0CX7wBk3WTUf/dI+pWXwPFswk8OF67pFI7P6P1dTcQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HBH7yjBUv7ihrEkv1CrVQ0UqbDW9A/J3nhmEP+UxwNiKiQk66Ye+XNVeec2xXrGMF0nMFkYlwXPqQQJWV2QR4h9Ga4jNEliloMoz2YRFDcAnaBQNwfYHCE2uo8lNzK+lNyQJExxoRahh0kK+GxJEldBDsZMj1/brp/7vYCpq9Zjs9zwBpShYc6//D/4sh16vzmRtrmVGTAtOpPE9Vz+BTAH0+22UDm/QW52rvTy2GRNdaxMZ46qWhxBXthY5fQNe2Q0pitWo1taTysaLfQfib1OnwLnof+t+8QDe0s4cNmMJxCHHxdVGQBWu8u08iWk5Mjn+fzDtt6fWDfTT59uQKw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 15 Aug 2022 08:21:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15.08.2022 10:17, Julien Grall wrote:
> On 15/08/2022 07:43, Jan Beulich wrote:
>> On 12.08.2022 21:24, Julien Grall wrote:
>>> From: Julien Grall <jgrall@xxxxxxxxxx>
>>>
>>> At the moment, the strings are in text right after each use because
>>> the instruction 'adr' has specific requirement on the location
>>> and the compiler will forbid cross section label.
>>>
>>> The macro 'adr_l' was recently reworked so the caller doesn't need
>>> to know whether the MMU is on. This makes it easier to use where
>>> instructions can be run in both context.
>>>
>>> This also means that the strings don't need to be part of .text
>>> anymore. So move them to .rodata.str.
>>
>> Wouldn't they better live somewhere in .init* ?
>
> PRINT() is also used in path for secondary bring-up. So this could be
> used after .init (even though today CPU hotplug doesn't work on Arm).
Then the term "earlyprintk" looks to be misleading?
> Furthermore, PRINT() is only used when earlyprintk is enabled. This
> should only be used in a development environment (gated by
> CONFIG_DEBUG). So I think it is better to keep all the strings in
> .rodata.str rather than trying to distinguish whether the caller will
> happen only during init on boot.
Fair enough.
Jan
|
