[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests


  • To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 16 Aug 2022 08:51:42 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=04tBr9NPFZN0zCrNrrglsMrlMB32SkuRGR9UgyuH/jM=; b=bgu+fISGoqvnz2PoLtpfaBvtVLc+/QsatBBtu5+ghub/ycVOjQBiMGjjjlikiScMjYV3I5Dbv4LzblPcoO3tUmRNVFo6QdkmqHt8tMHir/G0qTL/97LLXYnUg2W7R/X1P6wP93eC3b8NJAdkya1EN2CKLE3ZSSQfkeYVJrzFszJRftMWOX9GiXtoBOKDJlLi3w+CtvhRQ8y8D73XbGMhOQXTMi0N1V43eOct7Irva2rYoMWLF7EfWDn8jop0uqaJOcO0IGWPbJ0KjwOozOCjH373/9Trwh21pVFXGaeoRnTxYsEJ+aTagnn/tF93jErdMEdmySR0vw8Eda5nK2ugaw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ilikxP7MDh8YfRG1d84Sh1E60GFBGj95FYNFIqVAzUx3401Ba6Iy1HEpFY4UaeWjBbYOLSsJGz7LzMCyYRcvB/cF+jhZSZzfKt95zt9UQ4GdMBhGb/U0iqPu3A1DmPmp0u59fxSZyt35uZN5YPnn6VR6BCk/2XJ7KGsf5Se2h6CLcZl5OiyrcmChc746hdVZf7OymsgRzFoeYet1BrFwHJ+boJcT/Bv5Tr1DWmhgDNK/tKcl2FZ3LwR5+HoQpk9tkB+YrUzsdf8288Hx2nariW2Jgay4/bXiAUUp8I30vy5/X3CCvbOdY9awPOAtoc9fJe3bJbbs60Ay3YcRWu219Q==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Community Manager <community.manager@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 16 Aug 2022 06:51:54 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 15.08.2022 20:49, Andrew Cooper wrote:
> On 15/08/2022 10:14, Jan Beulich wrote:
>> On 15.08.2022 10:15, Andrew Cooper wrote:
>>> On 15/08/2022 09:01, Jan Beulich wrote:
>>>> On 17.05.2022 17:31, Roger Pau Monne wrote:
>>>>> Roger Pau Monne (3):
>>>>>   amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL
>>>>>   amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests
>>>>>   amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD
>>>> I came to realize that I had announced that I would commit this about a
>>>> month ago. I've done so now, but there was quite a bit of re-basing
>>>> necessary, to a fair degree because of this delay that I did introduce
>>>> by oversight. I hope I didn't screw up anywhere.
>>> Revert them, or I will.
>> There is no basis for reverting
> 
> You have falsified tags from me, which is a consequence of the series
> not been reviewed correctly.

Andrew, please, come on. I have not added any tags from you, hence I
cannot possibly have falsified any. The Suggested-by tags had been
there all the time. I also cannot see any evidence of "the series not
[having] been reviewed correctly". Please can you support your claims
by actual facts?

As to the series itself and its possible reverting (or fixing) - can
you please reply with technical comments on the problematic patch(es)
of the most recent version?

Henry - you may want to add this to your list of things to monitor.
The situation will need resolving one way or another, but obviously
we first need to determine the most suitable way.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.