[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/7] xen/arm32: traps: Dump more information for hypervisor data abort
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 16 Aug 2022 07:28:49 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VPapwNYuZ+DBoI0CbtiBl4Dh5gmTwk6+D+SKzNwRh4E=; b=bgWSfjkM6QA23UvjAX2tAUW389OYcB/6rhvq09pm2ltDDT7bMdiSwpsN5R3hoaw+zk2j8Gc6pvbkdNHnbPHL2uxmGay326GCdQE6m4nHhgpQM5w3V+zhEfLK8ZPsfx2rn2e+wdgHiRcNJkCquf7WeRcPKUjcAyr21Lnb7j/v9C2VOvZiiKB5njGzLu+fgqtvr3cbHR/CF0GV9SUB1xf0MiHw7IQa1G+HuaBLejvkB1ld3FaUJrxA6AuzdhU0NP0uTOAoZt9jGBY53+j35STb2meJmcvWonf2yzTjtJttkF4KRcWHdZiiUOf8CUAoghJJEDlb9uLXvL7QvK8Tby3Kjw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VPapwNYuZ+DBoI0CbtiBl4Dh5gmTwk6+D+SKzNwRh4E=; b=jyePh+Tq5RCFJjNp/xKloD30HpHV7QlN4Htj1OpbJ37i2FawRsTuQpt00RIpIHqp6snWFoseC2gmu4evGMxqxzXxKupAun5qA0M3NZxnaTfwbCwsal8fZ0mC//zR71uBEX6d+m1q9XSgcMWVOL58SkBxBjhr7rmqrwYetMf8BrbUsb4x2Hs0CVly6eeAPWBlH77Qt4cpVzBWuQImASsHi+ajtgNO3MKqsbJ3wisYr+C+RTP/JlmuUsz6ik8GEbfBoH2kP/w/8DnQNu8qIsbDy3YEpBrlkfU7jiRyl24ehhad/rwlqCWEqwmyYfn4K2MTnGckCgPmNHVK6zFWAnw/lA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=kkGqmuE996UwnEclatOcTMz72SJFyytdXhhJl58bWT5mFmC4bsmhG0yluII9hjlhu2ntwu5b/jw85o+US65Irg8r00LboWAsRX1IzAo2/cWIn1ihvJgA7E9bR7YMapkF6fnTFQjJ4o7gabPXO6S4hsK8+Lufa5ESj3RGVLYSmLmT7/Co49c9ISFSQ9nlUcjRcS8ouzZ46qd6ibNR4WlWrlYm9tsAKgaC4+pQPLDpRiLXWeWzxg51lqU6hT4R1Q0B3hCOe6r48LkSrdqKUrfmB++jMVbBxJgPHzfqWulUWy9IjlZK71BIhzLeN7uYgkj8oDnNR3MAebctYbX+I+RXwg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XzcMAg0M61gcdDfveGJThRAVAMa9PEyUw4znzTqFXmSxBFChg7uyyAI8GXPGorR3NQbXznDRxbpyir2U6PUkUkt/4eF4b/zmKNkvoIOQKw7q+fvChiM2d9yVexQTzcjg6HkdEtQkm0byNJijRuls6FM+iGuxgr+yCcdUi7vxM7dOW+eZAS9vK4I4ZzHF6HhMBvC0j9NUdrGfObclrXaeRrQjtjn1FvQ/tul6muUzm1KK5+8V1QkUgJFZZLbEDKAxaxNuwZ0Z2r/WI2/8nJInbfT5gkK1TSXbS9kPRhrbS86NfF56rGfW21ZNrtkfY5jx9ZiAq0yRSrfKL17PWLpQVA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 16 Aug 2022 07:29:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYroFFG1SBMYgirU+4BTxPWgpRqa2wLhCAgAAHIICAAPF0gA==
- Thread-topic: [PATCH 7/7] xen/arm32: traps: Dump more information for hypervisor data abort
Hi Julien,
> On 15 Aug 2022, at 18:04, Julien Grall <julien@xxxxxxx> wrote:
>
>
>
> On 15/08/2022 17:39, Bertrand Marquis wrote:
>> Hi Julien,
>
> Hi Bertrand,
>
>>> On 12 Aug 2022, at 20:24, Julien Grall <julien@xxxxxxx> wrote:
>>>
>>> From: Julien Grall <jgrall@xxxxxxxxxx>
>>>
>>> Unlike arm64, on arm32 there are no extra information dumped (e.g.
>>> page table walk) for hypervisor data abort.
>> The code in arch/arm/traps.c has nothing arm32 specific like that so
>> could you explain this statement ?
>> Here the arm32 code will call the generic function which has only
>> something specific for BRK handling but the rest is generic.
>
> The statement is not related to the code but the console output. On arm64, a
> data abort will decode the HSR and provide a dump of the page-table walk.
>
> This doesn't happen on arm32 because Xen will call do_unexpected_trap(). So
> the only information we have is the HSR and FAR. This is not very helpful for
> debugging page-table walk.
>
> After this patch, the same information will be printed on arm32 and arm64.
Ok then this is what I understood. Your commit message is maybe a bit unclear.
I would add a sentence like that: Call do_trap_hyp_sync for hypervisor data
aborts on arm32 to have the same information than on arm64.
This can be done on commit so feel free to add my:
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
>
> Cheers,
>
> --
> Julien Grall
|
