[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2] build: Fix x86 out-of-tree build without EFI
- To: Anthony Perard <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 17 Aug 2022 11:02:14 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WZOPfjaKgJTc697CmyeiETw13PagHAE/ELw9eD7Uuac=; b=CB+FGObeqCGiiP0DlLY/MB2Nu1+i8IBJZPs4DR+6mjrn9OQ3fFG5TMFwzR7AhyCD94FikSK1enDUMhFPFQjkU+3bJHwUIC0H01cXhi/a/pat6a+7l+I8o0vB7bB9TdMBQtfDJqgWGHbN+bF15nYQRfmidvL2hHuTVLPlFIF+8wQ1SCjLwuy5sDtRJjXUKLnonwfVPACi6Dve9qyU7vpzvnD6SPzPPyeO1YEK8sd9UVtRpPs+bidWcngdCnuf0/FeozmWSjKPqHM/DCANYNX1/Oi4uALzglV0UiROLZ1xvjsio5AVjLji8mlPN5C3/Xn+Q/YNEaNmF70i7JTNk59WBA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vc5+Qkv35Ws5Rf8vXz27msThA4Y2S4CdSKKRIqd5hmjDqh1lhtOekNvBFnIO8m4IrfX5s+ImtuTGrV6bjIfvZbewgo78144svuTKdNO6y2yDkTRBtoWfIpEq8HiiProkgdCYgzfuhLnp9FgSrGBdzt4oLQzzi73ZegC5mbLuJdeih7DEE1WMDB8WieyPv9lIaFor6yX29HCrpR5tmJ3y79OpMwqVAS/YjxWMfHLS9cJ8zkD0ZRik6b5TACBsv9ZVBkR5UIU5ZEMGGbYj7EqHfNFCy6r5Y9NRZS0zigaosFMyYziiAQJ0ga2l8cpaxOxXHK+XipDVg0LROaY8jJOHYQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 17 Aug 2022 11:02:27 +0000
- Ironport-data: A9a23:ROLWM6ORfdeEKVPvrXNrnJbID4GmJRDwMZ5BO5ONyJDMOBg3PpO3+DCIXisKGYBhGxn0FO3MPJFAYd7nTBFKIaVqljQqLPF8/x0h4An1Ucm/U3qJCZ8uGh3F4JCBdm++sNodWO/gDMhhgPPm+6Y7KG0rn0cHkDXH78mUmbGiEqmVa2nIkXhMO7Y1S8kcGC6pWZ+XM/4wrchxlHZ45iXSAMS2L5/8aSfAS5oJYX+eA/HmXv5HD4UrQyttQ2bPTFhHXEpLBb1lqW7khOvYV471Bi+pK40P/kQWFOQdXk8E7WQ5OTqzd/H2xoeuDvS7JzH9luJWQ63emmXLX5Y/bunjnDRBFhpgTR77Q4iCuxoeEuVbGv5DCJEDZqEF3acXp7B35eqjdUVJcbNVpo8d3dYFVQA4NC5M9vJCHhDbUSCQOP+DHXCAJShGro2c+RfsPyJM2TeEf/dTYJxkt01n/5dD5/C25VgESxXg/ELfi1ZCXAf8urKSbhHyJfVyDASAJEf6jdlPjqUMlNVti6Zdj2i9e2L4hmd+9jDuKphMbfD2eXM63d0T2rpENA0j6Sj7eumjuQMm4gxY3Kz0PLlziasuonVcJwEJCIeM2TMcIN2CGiC+xzqpXaUslu099Lc1cutAVZ6Mjn+Y8ZI+Z15CuVU5kNHm26k5ZSju9IXjNRIYIv2J4Eb+CkrtakUlZS3WR4cavMYKdclWgrBXc9oSSfUnMBHKblriuSVG85IB00yGG4+VFz7cYbddzen7VlIVsny2cliJ8uvR1LsHzqie4ncJSSFBLt87Nw990rEfmowWvy/aQN3WavUEdGLFCzlD23GECGLhLNLv3x99gn0ayJd+7BC0vILmC2R/vY9p+sdrhbMPhSZh3NxjNIjYzh6INXLxi6Y7+D3MkQKYRaEYJ6YK7EJ5y92SUC7D74jdurkCTL9qIE3rHoFRxykwlna2z7b8S7Peq9z4ALjb69076rr030N7swW0z0E/RkYfg4LtBgvos42n0TmaJmiO2KOyFFKcdgT1HGNEXFPs0cQqS2gbrNg8nz7Y2u2VcR8KflS0RA4KyMZso0KshQLo5U0Niq+7tN+g0VzaX+EVVNfNVdbSYEND5AwbY+blBP+aMVcO20b+Uj6YJWw3y3Uzxji5yMyT6kiXzRKB3lvOv9PKz6bYxpzCLZqOLiqMPg6oa3XJHHBmoXVz9sRzRLnMLiZj4dSssCcEmScSqZrbRCMOBo2fKVVVQzovuDLc05f5GnoRfDYjsYpNeWWfdmc9pHdXNU8P+65tQTuJ79XMO0NNBSID3rDmmidPR3OA7aZf03aycSbuaSGdWQKxFkC/jW/H115mE14CEqDKLIGBi0ILov3lw0mvkdlbZYCyi9LilpHQUu/8rDLX7D1WSB4sgBVzgbepodC2kBgwlcyddnVWsR6TuKhld82ksRiiYSwSbU0NsXKCQlIBYhd3yMB8J2MOdVLt6RXQHjZBO7dq/YpOf5Q8X5Sg/Oe9lz8uA/yu5yCFdhvR7nAmI3ScbYXDD29Dqogn77J8vRzAK0WsC4jis/hpRiyv2/WKlZKj1dAEx5rAWWTJY0rhu6zf32OMIeFQJmFwUdCAZ+p3wrKgNrpJ0XVLczHvyQecbdNe0aqPHfOrUupSVgqTe0F6wAux/tAri0JIQxkNeO8ayC+AGPgDWH3PsFSB7wu41gO0B0WEJ+OLDX8mtj+vMtuWdD9dQkAFcoFVsHI9TIEuURnOg9xarQ0NAaXXI+iNj+PKR5qRl0FIKsz15/5R9sPz+p39G+MSEkEm6mCeRsDFFNrIsh/1kU3qG7DKw1gA+0HavIiA0yw+nHGeZP68Yiyjlk5flqBnsujhAw2Gikh++kWKZJ3Kux9cuqC+wsMNlQjXJuXcIlc6CxVvn5sErtelPlhy9cmss8JUJE6juAvWmUwgRA8zc7ytHYe0viCuhAihiz5ueBWPcVJdVfx7p2lBWL/6qzjDGreVA9aY4WfJUUmKs2qO3Yxx12v542a5wDJH23ATuhXRt1yVzpdPVDUf47aek2U0LQDz4W4kyzTlZ7xj28TILpwaJSe0aRTTzVu4EXsrNnI6V8ZDU7bOTBYuwwu5hZqMZMFcXUGTrJRy67WkER2IyA7PiRhB2gWyoF+SKpenxOh4B2mN5P1MNG7nemZvNePZxBZHFVVbOQ+CXJoehlBDdQCE8P1P+dLpE+7xAa+yWo/n59aT34WD3SFqy1J/IUxm/uNMW38A6vRE+1PhnIs7MGoCzJpFspuMoiqVGA2KchTBzBd2Qnl6xKrNkBxFOYF5gSe0ags3lJbGKVlJr3045Ink4T7f+eYjLTT7OZB0jClf+9KsY0Ztuc1B9LX6G/okinMb11s9bJlbo2nLyAawLYhiq5/8qP3ffmwPNcDjWjYNyXwkLtq/JddHVzzrM9jE1lCkW/vFv8PTwqyZV7Un5YcdfeKuOlmJN+zbc8g3NYgC6qqZ1YdS7rKDr+PxIEjzLzhHlDdD4h2kis9V77k/UoajxXmMnIdQ3IGMHLeD5H4VRix7y2JG8l1f8KzrEp3qz92+sqhP9SiCr5i+rITpXrj0A7qOJPeBxTLAHYolBiN9sYLYGrFxqJWObvBL6zmEJwFmJFzPZctqFJB3/cMnmHr/HhafLw==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYshn1FitJ6Hl8lUq9G/d15az/a62y7WeA
- Thread-topic: [XEN PATCH v2] build: Fix x86 out-of-tree build without EFI
On 17/08/2022 10:15, Anthony PERARD wrote:
> We can't have a source file with the same name that exist in both the
> common code and in the arch specific code for efi/. This can lead to
> comfusion in make and it can pick up the wrong source file. This issue
> lead to a failure to build a pv-shim for x86 out-of-tree, as this is
> one example of an x86 build using the efi/stub.c.
>
> The issue is that in out-of-tree, make might find x86/efi/stub.c via
> VPATH, but as the target needs to be rebuilt due to FORCE, make
> actually avoid changing the source tree and rebuilt the target with
> VPATH ignored, so $@ lead to the build tree where "stub.c" dosen't
> exist yet so a link is made to "common/stub.c".
>
> Rework the new common/stub.c file to have a different name than the
> already existing one, by renaming the existing one. We will take
> example of efi/boot.c and have the common stub.c include a per-arch
> stub.h. This at least avoid the need to expose to Arm both alias
> efi_compat_get_info and efi_compat_runtime_call.
>
> Avoid using $(EFIOBJ-y) as an alias for $(clean-files), add
> "stub.c" directly to $(clean-files).
>
> Also update .gitignore as this was also missing from the original
> patch.
>
> Fixes: 7f96859b0d00 ("xen: reuse x86 EFI stub functions for Arm")
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
This version is broken I'm afraid.
/builddir/build/BUILD/xen-4.17.0/xen/build-shim-release/../arch/x86/setup.c:2045:(.init.text+0x3bc14):
relocation truncated to fit: R_X86_64_PLT32 against undefined symbol
`efi_boot_mem_unused'
ld: ./.xen-syms.0: hidden symbol `efi_boot_mem_unused' isn't defined
ld: final link failed: bad value
~Andrew
|
