[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2] build: Fix x86 out-of-tree build without EFI
- To: Anthony Perard <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 17 Aug 2022 13:50:41 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jTWIdfi6cz6Huq7A7IdamjtXWNLQ/xmuyRW7itJsDvo=; b=eB5sT1wDopMzIeMWtWh1He/cJZoJYtEHHWe7jgOuMH3Ouvlhe8jDpD6v/3lH0T2fqhkO4R6/RqHHMa0Zapjj9UUtVqHmZw84zipYw/nwz68oHx5OPfSIemRYCadhuSVTPgUymZaqdtkj1sl2JZgk0gB2CgEuAP/oN0VV4OLFqVUb7Yyzsu5WcpfGFP/sy0xSKCUEZQ1tZaZHzDcJqE+NAxxRK3JItsbwi9jLY5y0KI1i6vSGISqyj2jDuFLlkUDzRmsKDCYq60cz0l3r43vLHX5QYCSTRGki1s1x8FBPBeQd8wtV8JU8eb3GvoLre2JoXmF4USRMLL+5l/stICLwsQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=glg+9f9PWoKBDrXBgdC9/zVmlONe8jW/iZ8286eQ1GmDvfe7tPSmalsdDlqEZjOipi92xtPrilQwTxWugOKdq6Idj1nLLLvbWwn32inn1t4LGYAAJe8/P5LqVfFYcNdZoSEtVELjsmSCFs7s5ujRPZq3IeUlQ/UTkpf+cnzcel2ksecCat9MsxI6q4kepg0HkMJ6sRyrJKpc6Oe6Xuz5FHVWKgd13xsjyeGYGgODHbFEA5dEAxoDRMYiqvSdNgB0wrVPF8wTm+CYLoYvW7CMSJaIxo3ra2D5l5PGR6dKPW4bPzm3bHFcmrqmNujhM4Hmw5Ct336W0dn/8RrWP1nMhg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 17 Aug 2022 13:50:51 +0000
- Ironport-data: A9a23:ECdmqKKxaBrFyzKjFE+RLpQlxSXFcZb7ZxGr2PjKsXjdYENS0GEFn WQcXWyGa/qNZGejf9hwPNy1/E4PuJOEzoNlSlBlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vraP65xZVF/fngbqLmD+LZMTxGSwZhSSMw4TpugOd8iYNz6TSDK1rlV eja/ouOYzdJ5xYuajhOs/La90s21BjPkGhwUmIWNKgjUGD2zxH5PLpHTYmtIn3xRJVjH+LSb 44vG5ngows1Vz90Yj+Uuu6Tnn8iG9Y+DiDX4pZiYICwgwAqm8AH+v1T2Mzwy6tgo27hc9hZk L2hvHErIOsjFvWkdO81C3G0H8ziVEHvFXCuzXWX6KSuI0P6n3TEmvw3E0EsZ6Ai4cl9HDpEp MY/EjERYUXW7w626OrTpuhEoO0GdZCuFqVP/3ZqwHfeEOosRo3FT+PS/9hE0Twsh8dIW/HDe 84ebjkpZxPFC/FNEg5PVNRiw6H11j+mLW0wRFG9/MLb50D6ygBr3aerG93SYtGQHu1en1qCp 3KA9GP8av0fHIPPlmHZryj97gPJtQzxArpNHpnpz9VvnUKsxVZNBg03CGLu9JFVjWb7AbqzM Xc86ico6KQ/6kGvZt38RAGj5m6JuAYGXNhdGPF87xuCooLW6QuEAmkPThZadccr8sQxQFQC1 EKNnt7vLSxitvuSU3313qyPsTq4NCwRLGkDTSwJVw0I55/kuo5bpg3LZsZuFuiylNKdMTv92 SyQpS4ywbAal9cW1r6T9ErCxTmro/DhcAkx4QnGW3O/2SlwboWleo+A5EDS6LBLK4Pxc7Wal H0Nmszb5uZeC5iIzXWJWL9UQuHv4OuZOjrBh1IpB4Mm6zmm53+ke8ZX/S16I0BqdM0DfFcFf XPuhO+Y37cLVFPCUEO9S9vZ5xgCpUQ4KenYaw==
- Ironport-hdrordr: A9a23:/f6jlaycTIpORYRqglLcKrPxaegkLtp133Aq2lEZdPULSKKlfp GV88jziyWZtN9IYgBbpTnhAsO9qADnhONICOgqTP+ftWzd2VdAQ7sSi7cKrweQeREWs9Qtrp uIEJIOQ+EYb2IK9PoSiTPQe71MoKjlzEnrv5an854Hd3AtV0gU1XYfNu/tKDwTeOApP+tdKL Osou584xawc3Ueacq2QlMfWfLYmtHNnJX6JTYbGh8O8mC1/H6VwY+/NyLd8gYVUjtJz7tn23 PCiRbF6qKqtOz+4gPA1lXU849dlLLau5d+7Y23+4cowwfX+0eVjbdaKv2/VfcO0aKSAWMR4Z fxStEbToZOAj3qDySISFDWqnXdOX4VmgDfIBmj8DHeiP28fSk9DcVZg4Jfb1/212oM1esMlJ 5j7iahrJxQAgrHnCPho/7ydz8vuHaVjBMZ4KkuZwU2a/pHVFc2xbZvpX+8Nv87bXjHAUQcYb JTJdCZ6/BMfVyAaXfF+mFp3dy3R3w2WgyLW04Yp6Wuok9rdV1Cvj4lLfYk7wM93YN4T4MB6/ XPM6xumr0LRsgKbbhlDONERcesEGTCTR/FLWrXeD3cZeg6EmOIr4Sy7KQ+5emsdpBNxJwumI 7ZWFcdsWIpYUrhBcCHwZUO+BHQR2e2Wyjr16hllu5Ek6y5QKCuPTyISVgoncflq/IDAtfDU/ L2I55SC++LFxqdJW+I5XyMZ3B/EwhubCROgKdEZ7unmLO6FrHX
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYshn1FitJ6Hl8lUq9G/d15az/a62y7WeAgAAvEoA=
- Thread-topic: [XEN PATCH v2] build: Fix x86 out-of-tree build without EFI
On 17/08/2022 12:02, Andrew Cooper wrote:
> On 17/08/2022 10:15, Anthony PERARD wrote:
>> We can't have a source file with the same name that exist in both the
>> common code and in the arch specific code for efi/. This can lead to
>> comfusion in make and it can pick up the wrong source file. This issue
>> lead to a failure to build a pv-shim for x86 out-of-tree, as this is
>> one example of an x86 build using the efi/stub.c.
>>
>> The issue is that in out-of-tree, make might find x86/efi/stub.c via
>> VPATH, but as the target needs to be rebuilt due to FORCE, make
>> actually avoid changing the source tree and rebuilt the target with
>> VPATH ignored, so $@ lead to the build tree where "stub.c" dosen't
>> exist yet so a link is made to "common/stub.c".
>>
>> Rework the new common/stub.c file to have a different name than the
>> already existing one, by renaming the existing one. We will take
>> example of efi/boot.c and have the common stub.c include a per-arch
>> stub.h. This at least avoid the need to expose to Arm both alias
>> efi_compat_get_info and efi_compat_runtime_call.
>>
>> Avoid using $(EFIOBJ-y) as an alias for $(clean-files), add
>> "stub.c" directly to $(clean-files).
>>
>> Also update .gitignore as this was also missing from the original
>> patch.
>>
>> Fixes: 7f96859b0d00 ("xen: reuse x86 EFI stub functions for Arm")
>> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> This version is broken I'm afraid.
No it's not. User error on my behalf. Sorry.
Tested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
