[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 3/3] libxl: use time_t for qmp_synchronous_send()'s last parameter


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 18 Aug 2022 16:07:16 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SRRfVD7hJnZdH1IsdEus/1cIXqBM1/ZFOBeK1CyDYjc=; b=Lxg71w/8OMYtKCd+H7vc2uLIZQubjU8Xka1xmagMy+nHpLUw+h4RaF6eX+XgewbvPcDCKReYA/ZFRe3Qrc/ttRCS2u5wTz9rfQV7pUBGe4/4ApEUQz+lowuNa6LrkAlrp/HjNBSZSG+ICHrIPYaz5WXP5HTp7stGso+zTMlTgVbNMO0GJUlBaYD8wZ6PXF1MqGsbfs5gNsCcwpzHw+kkKEQo7zF8L5mDUdfi+77HUeVmpwnM0gNpxFJ+SqDzCjAAx8TsGLRrfpTGV02DXe6S/2bdB3t4wxspuB5if+Ngv+hWTqtv00njEnB5qmwWOyLrH9JNDTPvHUtNnIJRwgGWXQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c0H0K8AJEsaOM9LaBIhohbEImCb/aJMC2QQxLFNUNiFnvcte31VYYr9kYGW6uYSj7jUDpYFxJlLprOCMZ+q/uPoSLV5aKFMksl2izWytHwM0z9jbQarMZhbUCwEbPIZ1vecwk9YSKZS/grRx+QbgyR0IcqsbKQykpBZZdaI1fr1kuML6PQKZFlOWFinxU1O2CGfioF1Rej2YwuK+fozwP2WfG9BGkJivHXWNGxL+PNABbztnvzHvK5+8z6nqYAoLSgbr3m7sm5M5SZqk+MKvxJQz8BvqUX3szEtAwjPoM3oRgG/HhYaRyMC2nT4EAgh7V3nP3HRhmZIT8jOVh7tp4Q==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Thu, 18 Aug 2022 14:07:24 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

"int" is not a suitable type to hold / receive "time_t" values.

The parameter is presently unused, so no functional change.

Coverity ID: 1509377
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
An obvious alternative would be to drop the parameter for being unused,
but I assume there were plans to use it in some way.

--- a/tools/libs/light/libxl_qmp.c
+++ b/tools/libs/light/libxl_qmp.c
@@ -582,7 +582,7 @@ out:
 static int qmp_synchronous_send(libxl__qmp_handler *qmp, const char *cmd,
                                 libxl__json_object *args,
                                 qmp_callback_t callback, void *opaque,
-                                int ask_timeout)
+                                time_t ask_timeout)
 {
     int id = 0;
     int ret = 0;




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.