[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] libxl: use time_t for qmp_synchronous_send()'s last parameter


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Thu, 18 Aug 2022 17:14:56 +0100
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Thu, 18 Aug 2022 16:15:24 +0000
  • Ironport-data: A9a23:lL/D66vRNPJGRxRLjWJ1qWxQJefnOphVZsZKJsmfNk3eNXix3RfKay+QfFakzPnuH4fhePpUhzShtGjaYWPAbuTZfVBMRd9amF36WO5As2H2EY7O/LAOr6O2LxVlbeFmEEAeofEN7L0BlDFnloQm7waH9WG89KSo7thphodbAmtSxXtCHCObvTUg0HPpZRQwE3djsloTHGEg8aifjAQp7RFS9QBxZqTfWMuBe9Uix1tqBj4wnf5/WvX6KdPaqHDlfkO/tnO8PBmWQWGoc3+6ItZlJQayNY9dzsYvSAaY1Qidy0e3uIvN/o78vOlA3NWrMkDvbLhP3AU4qJyG622UseDzs6qhiBt+22FB5xXBAxx1yNgDGnA6Gu93n8RSaBQeDbdBmtTVm5d7dpWxP4urH5yxdUObhA0J/nw7YhO1gTiczoFWl/5eOWrhEkwnXuryTHW+Fux9P5lgpZTAmc+j2AGBCPPtrMJp88+9Uzc64hdjEt1UhkNBierkNm+EgCLib7pIdmGCHkqpgeZj/OauCXUCudKx390+YtOR+rcFc+0Syp6W6dDDdEuv5dZaV/FOMP+w3mAKs3pHK/yFz0g3hjMTAoDEMSXcU/gC0rCslzJh9F8CX4hBbrjgX7kAcLIyL96uSzrTxYPcHW1rp8AKd5BbbOxEbbrjwZuXlNMRG/SF9fGfrIvz7zM3KKvTi+73WmdKGeR5rArc54GkJxFkj5s9MvW0fiKCNdXD3I4yDDZAbyKSOcFK2yp8iyElFEb6gXcMc/DI92VMZxXhEuZfMcd6mEncR67snZ0CKEWl3tGgFoeBbuNDPsQMa9AzUH3WsvZFLlS7KrybEybD/q7ylS7HVazaPg8lM3yAV0HeGtRFsTn44a9JtrIgbCsF96DdWiNCf2HppzzaodOTQqsTB7iEnknqaOxM2OuDPXs7XZwbP7jQrow1OwdbKRck0DnD9yeSeC4H8F8j6NNuila4StX2tjKcrCIQwRU/0/Oc35Hpq5uD3B/JWaDakZea2qdvu8UKW70c9t0owDCHv3u42o+yjT/9UEHREZEcJxDkZ4cAOLTYthJtlbzqXE6TgHI251qNNU06T7JhSJDNv9OwKRtfTOz/OnbBHH7QO/GRwz76/mhGpgs+nbQkxEjNfEK9/rxsZQoggc7XpmIvFfjgSMILBXQeSzdNmX0PRsIgTOOFppoc4ic2jV0yC3WSxnerIBO2+5hWjS5m0RTOvZ30ZK0FBH6t1VII0KADvbVF3+ME8VCIZKpKSE6AbimRSqJCAbMVHhJ5yHH0EBtqqTFwCzIlLjwz3e8bS68Q2IRDZtV0054DvBVdI4Gq6leB6INZUy8TT4AsPN7DViSbLNTzZgWNB9vza/3weLzWIRDANZLu09RNCwpRWODMpxMekyCwKhuJ7Yhj2mGbrjKRFqZg2zoryc5tFBtCeOENTtSuONEiTljHZiuNGzZ1dGtsA3CshJF55gf+9IVbeGzNiFbZDU4oxPQ57RVmunzaP9ISHc2EeH9WYVr6jE06soChlVQstt8sCqgfTtB8+CnIXOXLsQYLLUp76D5GrjRT2A09BBuCDd+T1Y9AujRzKqfaPvP5uQg1FPkw3Zre9cbjJjpbPztZnxPmfHQ1qcP7MxZDnJz9k1lIn9oMH2r0Ya87Lo3BDqDp/iulK7U1kPECgCryaXb6TlLGm2++0HECrY26p7m3g6+iIFrJ4jVvCOLjqyBkx/PPgucr3bChDdIf+wdQZZoJX1mfAPRbN3sI2O+bpOcPedRjLPxcgkFP4zNBgrUFK3Y7qS3l+sQ+HSxNP2YbbRlo/+ZwrpBkEBAxcI9QlFit7ag/q+1Qrh47B+FdGEM+SDZv7Xzo/CcDNBOVWzosgoMP4o1KluLl9grOE6+fiP9vsSmpLILGu3mE+weZoU1VMhBejLNZqU3USQatAb64EBMOkrKN1QhOiziukw9prLAcZItAYGWHkR/HBafIL9SAFsXFuDWr7mvISCdy7rRSQlpOZqSAEOyOtNym3+0Jn+Kx0soW6dLjf/KmOxnQirn+hY4/Ug4C+3e7W66x+QkIeatH+vh0ygy3Lw0v2mAss6ejWTGROkZ+HCfxprNjlWLUw+NcXO3kZXD9jpI4AxpkMBYWKJJeBYPtYSVlP30bYf3yGo1vg1RQT0JFHLhkwhmFN1R2cqMnEdJA7ZqtO4wajs4vvsK9vHZ1H7euuygj1TueRbfQ0Dvm3zhFKN8WNxJ+3m9XYi3FsXHbxOvvCyCpzyYBZVTz0u6SNwCTT8UoSB00XRGy25c6B6/QVkA/9V5LMjlJzyRUgM5IrVlruTVEiDwjtek5m73aywQgELGghu5cKHUiVcYSwZEU0Bq29Rr7Ia6OhZWcJz3G4RP4DwO/kKAvSlpiLCTzPWwJv+y75U450JunSd5l/eAs93xKAdlLvN5gW9uVbMXJ11OFmktx+jJJ4QwJTxI+5OWsWAcXGcbib/Q7YXLX6nWWhg0+vdVJob3Jpfl5kEk51i3D4nuSDBpV+0FGXnpY9oARM7LBQcuHOJVC1EVHmOVWYD4DCWU1fk1ui12L+StYz5ezUsoMGTWpbeYrqlxee1O1Vyxhmv7U0+036A8TKNRdiQXXit1jbxiNHArat0o/36NVwh5jY4fwrKOSN0awiE+qwXa6bf3punVj/eKUVtK69B8hXxbkxmH0rX5G99FG4ZqBc45xZAS3+cJIfrmBG9HkfQbusSDN3w4MNepBnvoZ
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, Aug 18, 2022 at 04:07:16PM +0200, Jan Beulich wrote:
> "int" is not a suitable type to hold / receive "time_t" values.
> 
> The parameter is presently unused, so no functional change.
> 
> Coverity ID: 1509377
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

> ---
> An obvious alternative would be to drop the parameter for being unused,
> but I assume there were plans to use it in some way.

I'd rather drop the function all together instead, it doesn't get much
use these days as it's been replaced in many cases.

On the other hand, there seems to be only one call site, it would
be only one extra change to drop it, so that would be one way to fix
this. As you wish.

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.