[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] libxl: use time_t for qmp_synchronous_send()'s last parameter
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 18 Aug 2022 16:35:49 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YmZlVFccG7F7f4SXijI23mFVqjliHVMPi5oBHMZm8mY=; b=QCR6Nx+eooiy+fZzOqiZjceP+FT4tGrxChHKIiUPxzit+gt5anpvOAFfyY6BhgYMfGoNnS3goWvdRxR+87dLXpjYFvAg75QGsw7oW6/AQh1v8bL7Ls/ZE2KHuRizsaue4LhLaZbommokZ0V+2+Osf/vvo04R8QhfJolbeg9FQKRBoyrLwVIAoIh2/CsO8BJbr9or0taiCNqzZ/q0g//qzhrxDe3BDsYV6IAGBG4ofk0htxGaUnTcr24dDUL0ToHLBThMHBI+lD8XOZtuFRQCdVXKVmcq/tFgqSL7hjDVYT4s+Jh45mz9bkHNQa/DtaK6eNi11VR/no3sz6iRboFFmQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YalLUltpJlVoRxb9JI086h6/g/vmxCRcBsSLM1rRwE4vWr9wKMgl0+7EHfgw9kW02F5JPxFCWEHwQZYxjMCChI7mZB5hA7OhI8pRxrCAZve33IHA5RRgOOQbCqZ9XuT+HxcPM34jd7xOPxDuo5Cj7u4QeznCv/593qqI+k/PpeBzGvMLX20mHD5CEOA6mmk4I4xyAHCiXmvlxM9LaBq6xLBcL0dCcwTc5BpmTfizQz2j/q5G22RseQarheEB6wkCIBnmHg+eh+1gOgpZ4Iibd/O7uJ+TTl+6wA9eAGrQC4mtRJnNn4FfcXjFIxCa1U1dc4fJoZjTXvT4ofo0qHW57w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 18 Aug 2022 14:36:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.08.2022 16:20, Juergen Gross wrote:
> On 18.08.22 16:07, Jan Beulich wrote:
>> "int" is not a suitable type to hold / receive "time_t" values.
>>
>> The parameter is presently unused, so no functional change.
>>
>> Coverity ID: 1509377
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
Thanks.
> The severity of this issue is rather low IMO. A timeout of more than
> 60 years not being handled correctly seems to have no relevance at all.
Agreed. The tool can't tell that a time_t-type value is used here for
a timeout, not a time stamp, and using the correct type is Generally
Better™ anyway, imo.
Jan
|
