[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] automation: Remove build-* from gitignore
- To: Bertrand Marquis <bertrand.marquis@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 18 Aug 2022 16:30:10 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aPxcbN6NSN+W/lbktdMMgl/cOwLf7gi3NV8a42Rafzw=; b=fcRVsqON7JvdB0TTjWGEBDsmv8didXOR2wEmfGAt4eIUa4BtkCfoDkP5qS76giGkBopOY3Q/u+6MVWFJBZgCmJV4vTCn4UsMOb7Jk+DBw1/eKx5ftJrzUc/Znpqx0j+r1hRYvYD5WtE9zBa0hrjDA62DpiqT1wImULmVhiL2dY11FIMZN02LEgIY83TZIY6BEzsx/iarEhXfOERj3w2UxT5hL2Zqx6bWV0ksqgyclZOmzUgUAc//7G/yNQnhgIu4NCJmsLepkAXis0f3VbyaDzo6H/8aL7vas6Qm3EiP5QbSaR5SWR3xBTEWc44Hf8FomEclmoounQYRJJECT0afow==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yqlei5tMrxKwkeTz7A0u1vZv8oOcJaM/fy92y/LvHWdoPBuzxfi15xaP3mgfw2XAwO/MR9IJt2ifsSBvqC+WfNV0/eXiNlDTugF4ohL0NK1kaEGE7pSSpNyKc6sS38AuMBQAVjrdVZoXC2eV2K1PeZFNqRB/mzMBDySUqaYxd8TZKrqPppKfJkBgqZ6dxVCYu2SVVK2bgBVL5YBYIidTEAbM5WFASIAktiBqC7R5sbEH0+ZJA/XV0W2hHa1cVYkmQbGkpZ1tBs1cOssUxOaOnKPF89UzDI+8ghWihqbRcrWLVzOQKrt7nMlEZyDr+Q/w6n8itWi+cSn/4UUERLvVNg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 18 Aug 2022 14:30:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.07.2022 16:41, Bertrand Marquis wrote:
> ...because there are some scripts in automation corresponding to the
> entry (build-test.sh and build-each-commit.sh)
>
> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
While it seems odd to have this simple a patch sit un-acked for this long,
it looks like I'm not the only one uncomfortable ack-ing it without knowing
why the entry was there. Old .hgignore history only tells me that at some
point build* was changed to build-*. This recent mail from Andrew
(https://lists.xen.org/archives/html/xen-devel/2022-08/msg01043.html)
matches my vague recollection of build-* being used as sub-trees for
building stuff when out-of-tree builds are possible, yet people also don't
want to build in an entirely separate tree.
Hence as a compromise between keeping the status quo and deleting the
entry, could we go with changing it to build-*/ ?
Jan
> --- a/.gitignore
> +++ b/.gitignore
> @@ -44,7 +44,6 @@ config.cache
> config/Toplevel.mk
> config/Paths.mk
>
> -build-*
> dist/*
> docs/tmp.*
> docs/html/
|
