[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] automation: Remove build-* from gitignore


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Thu, 18 Aug 2022 15:50:42 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ucRyjCWzIV/kcdluUxKTf4R2mXjqu7ArjFcEA4o+VJk=; b=h4Y9ecBBmQn6ETGGxUJkUNSM7UECI9pS1RSVFKdwZ92Wfjg80Jj/Ra8/Jw7J066I4BIuK68p7mEncL19HIgfnjUgM77aXFXp+xqaG7Hxxct4DFAaMzyLTg/6bbc3K2W0BAzXz1GNYXluV2hXFMKDJYGR44cDlD04/jXQadMmKFAjWEevbq+6VohpiOm6GAZpWc6slmu6Oi0QJx30xsCBgatFar1Sw1g2h/FgdNtdKJHdGwpOvewEi7j/aZHaPAtNhmLBVbSIANpA25cJLY5HQ0PXBdLC9zNCfb/XJ71NPXJQGxd+duUC6bc+et/cw+DCuhRO5ewzsWCNUCKdaOdEMA==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ucRyjCWzIV/kcdluUxKTf4R2mXjqu7ArjFcEA4o+VJk=; b=jhVSmaAmV1MeLJ+3sbH8q3teDiEYirp1imlkjJ0cK9yZYgJMeq5ACHEfpnnu0pzjFH+5WaumQbHGdixd8G/mBmmGaUDbeZ5Obvp3tTjtLZjRbuBtFNulgGUE4C/UimvNs8YuMsg3jG3r3y/Qit6uSuEGvM9Xr/GOdo7G9ACcq5c0nZ6ZhksKeOE6/RSDcYoXP3ahkdW1ErvlXcGz5X129y4bMno8qtXmfOxTdE44FWKbbDRcxYfUGMvCp/g5SMuy6PFrP2qNM9YSPwso8nzQb1srbnblGQPOtXzVLlDwigHkXFJHjDX2ZGEa3527HsJVciBKL80putdLfNoO+qchuQ==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=fKYha+gg3tKdUDy+yvs0+hsdBpxo1xyBi5S74hAkl+mPYLH9uI1tKGcz3F9jQ7NTaPXGTyxNirhz+JoM+OMTK+zm71QMILgkxl4f73E9q4uul08C/zNT4u6WKtzoWlSDT61zeGz3bLmmGRTEEkY0AVn7C7KT1FJT/PGLJm6KRTAdYZs817RPx6NVDgrGebYzhebNuNjG7ptufNkf49OgaTiWSUZkD0LF6lPZ8X2WT9C2WRzTueM2THk7/t8XItNy8Iuud77WBrlrSVPrWChZ66WVz/x04DEuDdgEsZwRtA0IA/bSOT5oh72PGXjpck5xs6fkUrKuF4ImOdpiO8289g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZWNYkouRa/WI/IF72qWTnUNcvRHig9w8d4+B9ahwob3W0bF5ihHxH/Cn88QW6QcsJoR9aNtmKEaC7TZoyWl4o/3kixj7J/+lnAwzbQHGWLejfHG4x6vgJKDA4CRTKGfwxFeLhjwJbvb7dcUG/RALJ0REtLiJri6+q0v3RCi1kwQsP8kQlnVTX+tO8XCGZfYVmyxJLoTYag7sU7Xod74EdaMCDo9MaiFkcw4r1Kpqty1KN509AjejE958dwVy5Ai3kbg1HrU18/pFxAiEpesCk/8bY5HDCf5xvV2uMJvExRTJll4jAEbTltHzdIyUgHatg4YuE1NjKuo4sB4eQ7pALw==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 18 Aug 2022 15:50:57 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYlf2h3D1pYVHMJUWskUaBieWyaq208g8AgAAWf4A=
  • Thread-topic: [PATCH] automation: Remove build-* from gitignore

Hi Jan,

> On 18 Aug 2022, at 15:30, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> 
> On 12.07.2022 16:41, Bertrand Marquis wrote:
>> ...because there are some scripts in automation corresponding to the
>> entry (build-test.sh and build-each-commit.sh)
>> 
>> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
> 
> While it seems odd to have this simple a patch sit un-acked for this long,
> it looks like I'm not the only one uncomfortable ack-ing it without knowing
> why the entry was there. Old .hgignore history only tells me that at some
> point build* was changed to build-*. This recent mail from Andrew
> (https://lists.xen.org/archives/html/xen-devel/2022-08/msg01043.html)
> matches my vague recollection of build-* being used as sub-trees for
> building stuff when out-of-tree builds are possible, yet people also don't
> want to build in an entirely separate tree.

Thanks for reacting on this, I should have pinged in fact.

> 
> Hence as a compromise between keeping the status quo and deleting the
> entry, could we go with changing it to build-*/ ?

I must admit that not knowing why it was there I could not suggest how to fix.
This would work for the current issue so I am ok with that.

Cheers
Bertrand

> 
> Jan
> 
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -44,7 +44,6 @@ config.cache
>> config/Toplevel.mk
>> config/Paths.mk
>> 
>> -build-*
>> dist/*
>> docs/tmp.*
>> docs/html/
> 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.