[xen-unstable-smoke test] 172620: trouble: blocked/broken/fail/pass

[osstest service owner <osstest-admin@xxxxxxxxxxxxxx>]

flight 172620 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/172620/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl             <job status>                 broken
 test-armhf-armhf-xl           5 host-install(5)        broken REGR. vs. 172605

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 build-amd64-libvirt           6 libvirt-build                fail  like 172605
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  6c987150cf71976b5dd16b5f736dd5b0c6f6aee8
baseline version:
 xen                  f2beaf876dce590ee9937b79cd3498f2fe9f661c

Last test of basis   172605  2022-08-17 17:00:27 Z    0 days
Testing same since   172620  2022-08-18 08:01:46 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@xxxxxxxxxx>
  Jan Beulich <jbeulich@xxxxxxxx>
  Jane Malalane <jane.malalane@xxxxxxxxxx>
  Tim Deegan <tim@xxxxxxx>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          fail    
 test-armhf-armhf-xl                                          broken  
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-armhf-armhf-xl broken
broken-step test-armhf-armhf-xl host-install(5)

Not pushing.

------------------------------------------------------------
commit 6c987150cf71976b5dd16b5f736dd5b0c6f6aee8
Author: Jan Beulich <jbeulich@xxxxxxxx>
Date:   Thu Aug 18 09:30:41 2022 +0200

    x86: rework hypercall argument count table instantiation & use
    
    The initial observation were duplicate symbols that our checking warns
    about. Instead of merely renaming one or both pair(s) of symbols,
    reduce #ifdef-ary at the same time by moving the instantiation of the
    arrays into a macro. While doing the conversion also stop open-coding
    array_access_nospec().
    
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Reviewed-by: Juergen Gross <jgross@xxxxxxxx>

commit fe3f50726e878c81985e28282927d151a0d49de5
Author: Jane Malalane <jane.malalane@xxxxxxxxxx>
Date:   Thu Aug 18 09:30:10 2022 +0200

    x86/entry: move .init.text section higher up in the code for readability
    
    .init.text is a small section currently located amongst .text.entry
    code. Move it above .text.entry.
    
    This has no functional change but makes the code a bit more readable.
    
    Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Signed-off-by: Jane Malalane <jane.malalane@xxxxxxxxxx>
    Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

commit f2d947ac0738098ec2f52a17448df7e2acd64ff9
Author: Jan Beulich <jbeulich@xxxxxxxx>
Date:   Thu Aug 18 09:29:34 2022 +0200

    x86/P2M: allow 2M superpage use for shadowed guests
    
    For guests in shadow mode the P2M table gets used only by software. The
    only place where it matters whether superpages in the P2M can be dealt
    with is sh_unshadow_for_p2m_change(): The table is never made accessible
    to hardware for address translation, and the only checks of _PAGE_PSE in
    P2M entries in shadow code are in this function (all others are against
    guest page table entries). That function has been capable of handling
    them even before commit 0ca1669871f8a ("P2M: check whether hap mode is
    enabled before using 2mb pages") disabled 2M use in this case for
    dubious reasons ("potential errors when hap is disabled").
    
    While doing this, move "order" into more narrow scope and replace the
    local variable "d" by a new "hap" one.
    
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Acked-by: Tim Deegan <tim@xxxxxxx>

commit 6270081c57978ff32d76d8eb11196fd217f7af2d
Author: Jan Beulich <jbeulich@xxxxxxxx>
Date:   Thu Aug 18 09:29:04 2022 +0200

    x86/shadow: slightly consolidate sh_unshadow_for_p2m_change() (part III)
    
    In preparation for reactivating the presently dead 2M page path of the
    function, also deal with the case of replacing an L1 page table all in
    one go. Note that the prior comparing of MFNs to bypass the removal of
    shadows was insufficient (but kind of benign, for being dead code so
    far) - at the very least the R/W bit also needs considering there (to be
    on the safe side, compare the full [virtual] PTEs).
    
    While adjusting the first conditional in the loop for the use of the new
    local variable "nflags", also drop mfn_valid(): If anything we'd need to
    compare against INVALID_MFN, but that won't come out of l1e_get_mfn().
    
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Acked-by: Tim Deegan <tim@xxxxxxx>

commit 241702e064604dbb3e0d9b731aa8f45be448243b
Author: Jan Beulich <jbeulich@xxxxxxxx>
Date:   Thu Aug 18 09:28:38 2022 +0200

    x86/shadow: slightly consolidate sh_unshadow_for_p2m_change() (part II)
    
    Pull common checks out of the switch(). This includes extending a
    _PAGE_PRESENT check to L1 as well, which presumably was deemed redundant
    with p2m_is_valid() || p2m_is_grant(), but I think we are better off
    being explicit in all cases. Note that for L2 (or higher) the grant
    check isn't strictly necessary, as grants are only ever single pages.
    Leave a respective assertion.
    
    With _PAGE_PRESENT checked uniformly, the suspicious mfn_valid(omfn)
    checks can be dropped rather than moved/folded - if anything we'd need
    to compare against INVALID_MFN, but that won't come out of l1e_get_mfn().
    
    For L1 replace the moved out condition with a PTE comparison: There's
    no need for any update or flushing when the two match.
    
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Acked-by: Tim Deegan <tim@xxxxxxx>

commit 0caf699e69d79f54b94191e2f84956713c4be0da
Author: Jan Beulich <jbeulich@xxxxxxxx>
Date:   Thu Aug 18 09:28:05 2022 +0200

    x86/shadow: slightly consolidate sh_unshadow_for_p2m_change() (part I)
    
    Replace a p2m_is_ram() check in the 2M case by an explicit _PAGE_PRESENT
    one, to make more obvious that the subsequent l1e_get_mfn() actually
    retrieves something that really is an MFN. It doesn't really matter
    whether it's RAM, as the subsequent comparison with the original MFN is
    going to lead to zapping of everything except the "same MFN again" case.
    
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Acked-by: Tim Deegan <tim@xxxxxxx>

commit 62ca138c2c052187783aca3957d3f47c4dcfd683
Author: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Date:   Thu Aug 18 09:25:50 2022 +0200

    tools/libxl: Replace deprecated -soundhw on QEMU command line
    
    -soundhw is deprecated since 825ff02911c9 ("audio: add soundhw
    deprecation notice"), QEMU v5.1, and is been remove for upcoming v7.1
    by 039a68373c45 ("introduce -audio as a replacement for -soundhw").
    
    Instead we can just add the sound card with "-device", for most option
    that "-soundhw" could handle. "-device" is an option that existed
    before QEMU 1.0, and could already be used to add audio hardware.
    
    The list of possible option for libxl's "soundhw" is taken the list
    from QEMU 7.0.
    
    The list of options for "soundhw" are listed in order of preference in
    the manual. The first three (hda, ac97, es1370) are PCI devices and
    easy to test on Linux, and the last four are ISA devices which doesn't
    seems to work out of the box on linux.
    
    The sound card 'pcspk' isn't listed even if it used to be accepted by
    '-soundhw' because QEMU crash when trying to add it to a Xen domain.
    Also, it wouldn't work with "-device" might need to be "-machine
    pcspk-audiodev=default" instead.
    
    Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
    Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx>
(qemu changes not included)