[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] Arm32: tidy the memset() macro
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 19 Aug 2022 10:11:52 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YjlgEtmW/ECdrd5wVCKP1t/iJue45rLdbC3MQTxTBDQ=; b=VlqPBRYz98aL09etMUMRff+nUnQP2+pqYKFJ75XD+Y/jjZO9ky17/WZl+4yDOu6ZL22fW+ApGvD33cISbjme8fW84+1ufSELCoNEOZQcP/PrUk488jp1oEpYocwLYP7VQ6IDu0hvd+hDWR7B6bAeKXz9xjJzgNhy0og07q49iJ1HYNjSDyJKFR9Ru0z1O+l8D8FqCHYSjjqBNZKFFLgHwinPiC7ThrZE0OkuR0j6oPxjPl0RulR0NBManFVGDrjnkhzBF81kbofhzWBIfUPm8ty8uUbEoHKzuNTIK/IswUWBHQ++pd62TdNwjR+PI322sbRG9B7e0Gj4sThmKBVdIg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ixrTm4mFYeiJnlZ0515cwaaIpZjMpSB8/rg3yqgXPqxhX4z1xi/GDI0w4K/eImgLz/zf78ImMlAoRIREFkLXX7HUAECX6EQAIoX76yV1WQXqE4Tfn9T7E00IXHlCswtKqgP9DvZyb3EWtr3RE+ccDg24Cx3dj7gty3v4SJIVepsLSWfqZuuFox2HCAKHfW6Qc4qQCW+GUYf4H6jNihRc+lFeDMB4Bati6qfAwdAdLxVn71iJ7R0gCzlrrvxqH5RcqDTGujZioFZIMi1rxmmtgHf1oJj3QTE/YN/ggWbb+3Woa3LK4O5Qb0bff8DB9dJ0yvgHEz5EAx9RYE2yf/yk2A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 19 Aug 2022 08:12:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.08.2022 10:06, Julien Grall wrote:
> On 19/08/2022 09:02, Jan Beulich wrote:
>> On 19.08.2022 09:58, Julien Grall wrote:
>>> On 19/08/2022 08:50, Jan Beulich wrote:
>>>> - add parentheses where they were missing (MISRA)
>>>> - make sure to evaluate also v exactly once (MISRA)
>>>> - remove excess parentheses
>>>> - rename local variables to not have leading underscores
>>>> - apply Xen coding style
>>>
>>> This code has been taken from Linux. From you write above, I don't see
>>> any strong reason for us to modify it (even if it is small).
>>
>> At least the MISRA issues want addressing, I suppose. Plus I wasn't
>> able to spot the macro in Linux anymore (nor __memzero()), so to me
>> there seemed to be little point to consider keeping anything "in sync"
>> here.
> I read the last part as we want a re-sync of the code (we haven't done
> one in the past couple of years).
I'm afraid I'm now really confused: Which last part? I don't see how
any of what I have said could be read that way. Quite the opposite:
By stating that Linux doesn't have this macro anymore, isn't it quite
clear that there's nothing to re-sync against?
Jan
|
