[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: “Backend has not unmapped grant” errors
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 24 Aug 2022 08:40:22 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L2tASAJcbyeoJJNHMXYy+/pVjGHuvQF0cvFlbJWfWIk=; b=UoDYovgQHV2k1iKP0+PEGW3gvY+DdBmXGZQnhITzTAwdIfoJJaLZ7rxGon7k91Fybg4afD0jxFja2KS5b9L4ADRwwh9UkFyypz/cEYfjpguohExTsncfkMPLoADqFRmZG5V4qdbyiuCy5pB3LaNuQAEHKNTepKIbrS3tVpCgRwwy0n7KuluCGZPT4taShj0ia4vudGtcQ7+eEj08pYRUDYt83oNAavR26haUaFUO8VgNxCa1EEcnCQ5YpMZXQN/QcrBWN7U5wYABb9dFCAzRaAhaiqRtixJPIxmBhbLUYNSykP7DN84YbbADTgkdsm7Sck4Gnxpfr2QAOs2aFaMXJg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BePX4AbHxl+b27xqK0DAFoFdzYrG5rpizv0IYdF6A3lmhlf/Y3agyZa+z3saiTM0b24ovCFXwpY4kNXt6WmIjH7uiKkZWC3cT9RrOqKQ+OKpXZqs9DTFRCqHbcXe8PA77N7pgfZkC3g7GW2IbTsLCTCafX5arq37xHVgsLPLkXZI7ZeYlqCPBU47e3dVVXkXkEILzN9rBJCCwFUvj00ulHCrT89zbj42mklscoJG5wcryMR3MEzvwSQDT/YfVM5DhTit7FKjnALOKBg246nA8/Ik3SvvfrNmZMliOCaZrYeia5GGHRz9Fx1tBm3ZsoN8o2azvswA9oifcimtxSSpFA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Xen developer discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>, SeongJae Park <sjpark@xxxxxxxxxx>, Maximilian Heyne <mheyne@xxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 24 Aug 2022 06:40:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.08.2022 08:36, Juergen Gross wrote:
> On 24.08.22 08:30, Jan Beulich wrote:
>> On 24.08.2022 08:02, Juergen Gross wrote:
>>> The blkif.h comments should be updated to make it clear that the values in
>>> Xenstore don't reflect the state of the connection, but the availability of
>>> the feature in the related driver.
>>
>> Isn't that implied for all the feature-* leaves? I certainly don't mind it
>> being spelled out, but I don't think there's any real ambiguity here.
>
> I think it should spelled out explicitly, maybe in the general paragraph
> about feature negotiation.
>
> To me especially the phrasing on the frontend side was reading as if a "1"
> would indicate the feature to be actively used:
>
> "A value of "1" indicates that the frontend will reuse the same grants ..."
Hmm, yes, that's certainly wording worth of improving (regardless of any
addition to the general paragraph).
Jan
|