[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] Arm32: correct string.h functions for "int" -> "unsigned char" conversion
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 25 Aug 2022 16:34:43 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WTa2VvAIxWdy0E5BCcQlqrQpKNAMUNm6p8bVe8gBT5s=; b=iOfnyXhqfnzMD77gHOA7+YwkIN8gqpJsn7GueBxpyaPgvydSQ03grk8AjWjrKbDO6NHB+QvkvE2Ex4MpoS38s3pe9M68FFTDq8XAp4JcloRZbqtpckVX3fvo8qpG9wtiwvx57ctmUf7VCu4zAphpT2LeYsTMxwNsJDK5/v1iGQ98cHf2EvMLGK2n5GwR5vJKG1LJfNNaZJtg8TVHHH2idg2yUi171DiVT0GIoJ0uBdWnw72sO6NE0MKg3nSIhoKBKEk9UCnSC1aVr8pQ/YtWprbvmjBMj6GxP/1xQEQTcTlimIz8XrWfbFx+XKlu5ixdO0sbnin2Zp+Xr9WjN2XnOw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W/Ujo5F0SJ7rfyfW1dzj/F04AN3+NanzscAcneB0XWGoQt6xy6sNEyDZoS2RyTKvRImyoHPUDkNMfVGNUYLPb41xuseyoG8J00umXCLzCR+7VBlVLJ+z65E0hB9GVH3gvI2PEYOXtp3twGbou7GHW+rDjlMZzrIyTjM4dZXdeQnH4g2y9hzsSkBQ/arrqVtklvUPKneyB/hhoJzGeq/vwpJXuVpZwl++ZsmNFCJr4pq+lbMcK1DKxNqdI5rT+C2BU54LI3FhVU5vkbbBRON5dISAGt+gplEuW23MkuWLanfSpFAObfzjkazdgTQmmcqrHIJm34l4AHffWNFJDYAS8A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Thu, 25 Aug 2022 14:34:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.08.2022 16:31, Julien Grall wrote:
> On 24/08/2022 13:44, Bertrand Marquis wrote:
>>> On 24 Aug 2022, at 13:33, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>>
>>> While Arm64 does so uniformly, for Arm32 only strchr() currently handles
>>> this properly. Add the necessary conversion also to strrchr(), memchr(),
>>> and memset().
>>>
>>> As to the placement in memset(): Putting the new insn at the beginning
>>> of the function is apparently deemed more "obvious". It could be placed
>>> later, as the code reachable without ever making it to the "1" label
>>> only ever does byte stores.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>
> It is now committed.
But then perhaps not pushed yet?
Jan
|
