[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Arm32: correct string.h functions for "int" -> "unsigned char" conversion



Hi Jan,

On 25/08/2022 15:34, Jan Beulich wrote:
On 25.08.2022 16:31, Julien Grall wrote:
On 24/08/2022 13:44, Bertrand Marquis wrote:
On 24 Aug 2022, at 13:33, Jan Beulich <jbeulich@xxxxxxxx> wrote:

While Arm64 does so uniformly, for Arm32 only strchr() currently handles
this properly. Add the necessary conversion also to strrchr(), memchr(),
and memset().

As to the placement in memset(): Putting the new insn at the beginning
of the function is apparently deemed more "obvious". It could be placed
later, as the code reachable without ever making it to the "1" label
only ever does byte stores.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>

It is now committed.

But then perhaps not pushed yet?

Yes. I tend to send the message just after I apply it. I will push when I am done with a batch (in this case, this is the only patch I pushed).

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.