[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2] x86/public: move XEN_ACPI_ in a new header
- To: Jan Beulich <jbeulich@xxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Tue, 30 Aug 2022 00:52:56 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Po+ym3haD4dd013MRDyISNl2D1o494H0wJEy34PqJbs=; b=MsrkRlaYpZ0HfYXe5RmV5OWuX2eNNrYnZr7X7kKqHotivajgeJYPD52ja1zJ32THoyeQcB7oxMO+VrJCPqZ0T+LC8Ex3O2vKNzSAnKJsyD8Ol83m5abw4uXVPFtFIyUGOEO68ffxhSXaoK31+J4gnFE3ZPCKTTshTDBtgqvQdXMKGKyXp58c23I8Rxv9XGZUqx6DowwmCb6FumxDx8+nlhPvTvG5KZLxXmNacnv82htqobGDRAqn4uzqrnLMzby3+koR64EWVEnrXPUY6eeAHFZkJVfgWT/NdbJE+5KrRvxM9gwgNb0GaFmGH73xa6bnL00+S+xk4mC1ed78HzrpaA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Po+ym3haD4dd013MRDyISNl2D1o494H0wJEy34PqJbs=; b=d7WCqChrfexcREgocgBdCWzgyKAYuDf4kk55Mxw2oUSIjLClAZiCm3xVGDBfEOgd+VyYgvU9EGSRckEdxcKNwz03gdwRnAoZCSjMClP87JkLhAgpRzwAQnfg9WsTiETZPb8acLJ9+oYmdTALOqMQdduTY98eiWTcaVT5jzFjZJzeDZCcZTfkPRxB2PHszpJjSwI1ap/OTkawtS+r4AmE8lS1aK9hTYRSsePgy/MaAu8E/Dql0W4tFwQFg0S8bt5q55w/CN1WzSRQYlmX0oetSxA1dckzUVFT+VaD2wjUoP+cNG5FKUMp9j63cOSJQsyDE3dYAf0ZBnc3VlfnTA1D4Q==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dAowYGBkyPbV9MQC09rsUwqz/Tw/nPCLjTCY5DnLzxPwAeRbhBDV99otG4UEnictQFEGeYR8ZSnmK+6h8QjE4p/VCSWTXs+Fg/AGwwc/S94AyxjE3O8fi88ELTZ360hW6AfhbwyPowIQDzzREypMu3sEK0aVJtNjV3MH15A9VDG/HuQlPSTsSKkSeqjmfMjEt+pxDbgVztnlJe/UdsfWadZPoHkYvLYk2ZsAFz6GSMnlU6J1V1AdaZOyXY/S+DL/IpjtpAhazC3IUkN24GcP9EVzYcBMoeLhN00WRQcl/S3R5SOGDZNne+yeNUUYhNfvzsQvq1cVg1KWGROE99PIsQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MT2HxAslqU+TM/mBMScxyAY3jmxk1xamV8BlDHr+sTSg2KaoqIWNpzrpP2sEYLqeNLJueWeVufhTkjyrCWgIjTcfKxBRFgMu98jlg3j2KUCuMbY+rLC5iLawtLUPIbV3uUyAycN66e2ApgZ70HSHCJrIZzvUli2t2Wl1yGu+WZRlVuQAs2EiXgmVO+xKENtRGr6jvGrl/yL7fq/gHkarqDUSeqDDh4BGzFmfF7FkEjLIYXPfK6O994J72S7yVp76eG+Y1DGDeb/GCNzTO2QBC250gh4H4LYFOvwLwbSjvUQQ4SCFHOxkiRYGBYjYvIjOsvRjiWE5PnDpRfurqLToTw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 30 Aug 2022 00:53:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYuGftYa+h04RcYEK+Oaks92E1n62/YK6AgAdDISA=
- Thread-topic: [PATCH v2] x86/public: move XEN_ACPI_ in a new header
Hi Jan and Bertrand,
Sorry for the late reply. I had a couple of days off.
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Subject: Re: [PATCH v2] x86/public: move XEN_ACPI_ in a new header
>
> On 25.08.2022 11:48, Bertrand Marquis wrote:
> > When Xen is compiled for x86 on an arm machine, libacpi build is failing
> > due to a wrong include path:
> > - arch-x86/xen.h includes xen.h
> > - xen.h includes arch-arm.h (as __i386__ and __x86_64__ are not defined
> > but arm ones are).
> >
> > To solve this issue move XEN_ACPI_ definitions in a new header
> > guest-acpi.h that can be included cleanly by mk_dsdt.c.
> > Inside this header, only protect the definitions using ifdef
> > __XEN_TOOLS__ as the defines are not used anywhere in the hypervisor
> and
> > are not expected to be.
> >
> > Previous users needing any of the XEN_ACPI_ definitions will now need to
> > include arch-x86/guest-acpi.h instead of arch-x86/xen.h
> >
> > Fixes: d6ac8e22c7c5 ("acpi/x86: define ACPI IO registers for PVH guests")
> > Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> > For the release manager:
> > - risk: very low, the definitions moved are only used in mk_dsdt and
> > external users would just have to include the new header.
> > - advantage: we can now compile xen for x86 on arm build machines
>
> I'll give it a little for Henry to possibly release-ack this, but since
> strictly speaking this is a bug fix, I think it could also go in without
> (as long as not actually objected to, of course).
Thanks for informing. Yeah definitely no problem from my side, so:
Acked-by: Henry Wang <Henry.Wang@xxxxxxx> # For the 4.17 release
Kind regards,
Henry
>
> Jan
|
