[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Tue, 30 Aug 2022 00:58:23 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U1gujnHkgu3GEGxdmUmZpeltirryqyZLv7UVkksZmqM=; b=YwH1I3NxIFtMxVeqQr+faX+QTXQLY4UERCkMS/Yvtb7nqFXL9cq8cPZgZtjNwS0ZkVqTaAxap96et3Nsv0SAHSw0xwL/JTBXJmAZgJJmKgHJEl1r0hPFaZGZYxADczgMWlnreke1opPf1Obd++N5yayzy/vu7lk7hDBqLuGIU+FYo5C+rSqcOy8pQsazcZ6WUtFuV/gEs9fVuVqw9l8Oq2/P/JFb+QEV5w2h/AJ0tjrXegYnftcn/GujjYtAvWKiJTZ2l2sCGPujkoLHnn7XbObRHGBW42HyYex3mtoV952WsQwv2lcMWqo40aFM6FH7lSFF0J6/sSEnqrhPaGJ6uw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U1gujnHkgu3GEGxdmUmZpeltirryqyZLv7UVkksZmqM=; b=f6PcGuprRzYc4yKMptnngm66zZHp1hny7aYFEB/M/DTsoTyOTF0Y6pmCtmRQH5ZV3jFbQRQu3YWf3tDhWvFEn+h4G2hkXtDF3z1PmmaurNedmY3oMCP87OZyRwQDNQAt2V0/N1FNLloAf1VOcxBGivwfHWdfPGfgEU9lBYUIBEFDOFiS1oro2FSK9GwPNGJgTXEphJEfWvgbDtPZfwCbfiNXYSOiVQMjxp/9kTRINSkZs5NHytrHOlc3abX9uAQkWbnPSwSl8pK2hTl/qpPnwHyZrQExMX78kujpnTHgC5HrNvRkiyZRXffOuDncaRrDbY9RGkxm67Cw0u/OANUb8g==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FAD+dNmd/ByCKF40cV7Pa8E4oC6oTJgCBWISoXA+J9lSBxX7smWhsrhPknLJXRYKDJmgTem89sdC725fsd/KpaufIgSoStNvf1D1ILbVhIDSYLOPIaRerlSGIGZ0HgPBfKr8BfnRkaqIjMo7btlYzjd/GOfovpp7rx+R8FUTc2ruUwGxi/UZfDN29dYaMZAfaS8XRAnefMsxrslHgJUAJU9YxD1rSG3Ukow1utILLLrrQrsYYRupU69o0sqzBVNqJgFInzDKeXHTNr8jQlKHRyvTLNUR+ErJXb851xZkkfJwzmbJO73zXpJ7caMcnsprbzAkU0/TIuTI3KVjZiDzeQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ca/DhFap9YKUUHSV6ciJNUFShzk329DfDEmM2jnGRUOLsKw2ZmUCZVwpADot0dCkNUe351CxiYi+k4ci+TblZ+3u9fGD9LZzAMKm+9JQ4MlRtyJXdo0qWA8UjsZz6FIA9KlWwslQrgOfuWnY5vpkm1Kd3n0d2DP6H9wuXK3Hq0xAuJVSt4z9qYO5fVTFfKfI75bXmXNV6zV3Ye7yWqSthUN5r2MIklfR7sU+CM2ao+zEfLpYILQh6xzOsOoGt/iVrL7mho6BRmMnNXEBS6LIHyfmVLql6rbf3FpQxNcut++bRB0n2nPov226CXS881Wh45R5i8HWCANxDRVTxcDJTw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>
- Delivery-date: Tue, 30 Aug 2022 00:58:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYt4ueuuTQX+2f5E69518db+C55q2+ENkAgAC6AOCAB9oWAIAAAi5w
- Thread-topic: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory
Hi Stefano and Michal,
> -----Original Message-----
> From: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Sent: Tuesday, August 30, 2022 8:47 AM
> To: Henry Wang <Henry.Wang@xxxxxxx>
> Cc: Michal Orzel <michal.orzel@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx;
> Stefano Stabellini <sstabellini@xxxxxxxxxx>; Julien Grall <julien@xxxxxxx>;
> Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; Wei Chen
> <Wei.Chen@xxxxxxx>; Volodymyr Babchuk
> <Volodymyr_Babchuk@xxxxxxxx>; Penny Zheng <Penny.Zheng@xxxxxxx>
> Subject: RE: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory
>
> On Thu, 25 Aug 2022, Henry Wang wrote:
> > > > const char *name,
> > > > u32 address_cells, u32
> > > > size_cells)
> > > > {
> > > > @@ -301,16 +303,40 @@ static void __init process_chosen_node(const
> > > void *fdt, int node,
> > > > paddr_t start, end;
> > > > int len;
> > > >
> > > > + if ( fdt_get_property(fdt, node, "xen,static-mem", NULL) )
> > > > + {
> > > > + u32 address_cells = device_tree_get_u32(fdt, node,
> > > > +
> > > > "#xen,static-mem-address-cells",
> > > > + 0);
> > > > + u32 size_cells = device_tree_get_u32(fdt, node,
> > > > +
> > > > "#xen,static-mem-size-cells", 0);
> > > > + int rc;
> > > > +
> > > > + printk("Checking for reserved heap in /chosen\n");
> > > > + if ( address_cells < 1 || size_cells < 1 )
> > > address_cells and size_cells cannot be negative so you could just check if
> > > there are 0.
> >
> > In bootfdt.c function device_tree_get_meminfo(), the address and size cells
> > are checked using <1 instead of =0. I agree they cannot be negative, but I
> am
> > not very sure if there were other reasons to do the "<1" check in
> > device_tree_get_meminfo(). Are you fine with we don't keep the
> consistency
> > here?
>
> I would keep the < 1 check but it doesn't make much difference either
> way
I also would prefer to keep these two places consistent and I agree Michal is
making a good point.
Kind regards,
Henry
|
