[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: acpi: Include header file for version number
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 7 Sep 2022 10:05:54 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1c++8snHPM6G4uK3DDdgD6QKn838AAZMIC6ysONemz4=; b=dd1On4l8tPC5Gudu/kP457Qh/gjASAUnjQ4n9y8vZwzXaV8wfMtGoxnEJLy9J2/28RHxRGnUKe5jHygh9JBn/2YHkHdDc9/0fML9sOGNbtm4387Uo0kKk73LTNfOu+QP4zpHXqjIX1qlq/xgmBFc5KWriW/lgL7B8aMlOoolefu58jH4ntq2eoVgQGNWCD8Xrq6g8tMuhFI9moT47GlqdZgB2H04QUKao8fvEKRHuG0Gotymvy4puzMscDtdg2jzu3GGANfeZS2MYJgYzotRU6TRGUHfuBxXPLesWcEmORLimwrNT7EVtsFHb6L+zcdRRlOF3Fjp/FiUxasFzCancQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1c++8snHPM6G4uK3DDdgD6QKn838AAZMIC6ysONemz4=; b=XpRtzRYNMSxbtmp5l9ywpKuWWWybmWh7Hq0DgOc0OKBelijC+8zvS06boy+PR3aeff61x3U5L66J82qVhFqtJM4R4ApJ6tF2lRl5y+ToYCp2SoGlLIZcceLUa+v3E1I+LkQzb44ze8Qsn+K5iaC5+gRkUDj422j6qX2a3zcMo8kTk27Fz5cpIWu6MP8ojm/b1tPePu5Wgxw9LxdRh1JslXjZ0CcL9Y65MH7Jhqyo3NptgDD4NLHJTbq9lmrnBhw4umv86zbZAV0a/N1EvHRyQoF8//Pd+qbYGyzgl3N1ZA8iulTYucicQhb0SgyCKK/BdknVStJzduiPn7Adf/RSpw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iUayeIxVujPz3j7pXrzCURi6Aqt01HdGq1DH5Lpf/C4RIcHQ8oBlMicCwVAqLzkr7cFSOFp0cFiLEVV/s3NuADg32dqrN1KLFc6uz2Z5tKGDNmp4uWBcQYJqJ5fbLbggB5OOCQWcdd23BT8me5ItZHxP9bOwWwEn2rt+QP4TVty3hXCfAB/nWnHcl+5LcoQ8C/AgJ07z9oZ5hfmvxmfmav3/4in0/fy+ErNwISvBY97aqGCw+kqx9qot5iMEJ6ZuIxkos+S6Yi3Ra1LbGilFuIdP/rUNwJ9jLp4cdv7+Fu5eVnecGVz+KvTYpGajgLFkJETQN7NIaO33nMsITjTcNQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l4NQmpyllcC6pBqkMZhEs0QhEEr4v6GqIyuGQE/kwr6r7+qj0MU9z3PKZ0wPz7wtyGccXSm+t4QylyjMlkQWHGRxEHuRaGoWGmoa1jcEuuDqkLgevYUyHUtD4EmD4A+PVcLCHPiPGfb0rItIMGb8T0XJFJ30/Z0HsWUoPuP9fvnqvFFbEA+ZWkDtiemU1c0KizUkjyuxMfCk/C3m9bVEoAhCbQfVSTpCII57QC1GXCUqwKNqLlVmHRI5LFGxkjEDRuL8RHFt7gZDliacPg7qRQnkRAAhAez321FrUSVG7AQ7gGQ1CC0rzOj5ciBu0XA2Darp3Mg4wQ9JmkRYuQXxVQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "leo.yan@xxxxxxxxxx" <leo.yan@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Wed, 07 Sep 2022 10:06:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYweQzyVikzADCFE2Bfo+zYT5rgq3ToyoAgAABNgCAAAHYAIAABH8AgAAAyoCAAAC7AIAABHeAgAAOWQA=
- Thread-topic: [PATCH] xen/arm: acpi: Include header file for version number
Hi Jan,
> On 7 Sep 2022, at 10:14, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 07.09.2022 10:58, Bertrand Marquis wrote:
>>> On 7 Sep 2022, at 09:55, Julien Grall <julien@xxxxxxx> wrote:
>>> On 07/09/2022 09:53, Bertrand Marquis wrote:
>>>>>> Otherwise if we start adding those kinds of checks, we will have to add
>>>>>> them in at least 3 places in xen code.
>>>>>
>>>>> The solution I proposed above is easy to implement right now. My gut
>>>>> feeling is tweaking __stringify (or else) will take a bit more time.
>>>>>
>>>>> If you (or Leo) can come up with a solution quickly then fine. Otherwise,
>>>>> I think we still want some hardening for backporting purpose.
>>>> I think a define in compile.h using stringify is the easiest solution:
>>>
>>> Ah! I thought you were suggesting to tweak __stringify. This is ...
>>
>> Also possible but a bit more tricky
>>
>>>> #define XEN_STR_VERSION
>>>> "__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)”
>>
>> Quotes at beginning and end should not be there.
>
> I have to admit that I dislike the STR infix. I'd prefer a suffixed variant
> (e.g. XEN_VERSION_STRING) or one omitting "string" altogether, e.g.
> XEN_FULL_VERSION (albeit I see "full" as being potentially ambiguous here,
> since one might expect that to include XEN_EXTRAVERSION as well then).
Version is a value so here I though it made sense to distinguish that one as it
is a string representation of it.
XEN_VERSION_STRING is ok I think.
I generally dislike anything named FULL, EXTRA, BASE or other which are just
unclear.
Bertrand
>
> Jan
|
