Re: [PATCH] xen/arm: acpi: Include header file for version number

[Leo Yan <leo.yan@xxxxxxxxxx>]

On Wed, Sep 07, 2022 at 10:05:54AM +0000, Bertrand Marquis wrote:

[...]

> >>>> I think a define in compile.h using stringify is the easiest solution:
> >>> 
> >>> Ah! I thought you were suggesting to tweak __stringify. This is ...
> >> 
> >> Also possible but a bit more tricky
> >> 
> >>>> #define XEN_STR_VERSION 
> >>>> "__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)”

Just remind, We need to define XEN_VERSION_STRING in compile.h.in rather
than in compile.h, something like:

  #define XEN_VERSION_STRING @@version@@.@@subversion@@

> >> Quotes at beginning and end should not be there.
> > 
> > I have to admit that I dislike the STR infix. I'd prefer a suffixed variant
> > (e.g. XEN_VERSION_STRING) or one omitting "string" altogether, e.g.
> > XEN_FULL_VERSION (albeit I see "full" as being potentially ambiguous here,
> > since one might expect that to include XEN_EXTRAVERSION as well then).
> 
> 
> Version is a value so here I though it made sense to distinguish that one as 
> it is a string representation of it.
> 
> XEN_VERSION_STRING is ok I think.
> 
> I generally dislike anything named FULL, EXTRA, BASE or other which are just 
> unclear.

XEN_VERSION_STRING is good for me.

Hi Bertrand, just let me know if you prefer to cook your own patch for
this (essentially this idea is coming from you) or you want me to
follow up for a new patch?  Either way is fine for me.

Thanks,
Leo