[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: acpi: Include header file for version number
- To: "leo.yan@xxxxxxxxxx" <leo.yan@xxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 7 Sep 2022 11:12:24 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e/ImRGUKclv4L01W4gnUgTQ2PXKpJkMORfZP2Q730zQ=; b=adNfckj6dOoIMaWnAkZOjubdLlBbV1tH/ApHSe27z0vmAZXLkJtiyboj/uZTs5xxIdPHbw0VIYBwuI5+bC2RSSaVcQNc20LMZOl6l1Fv7V19otGHuXpiDmpQqg4YEw1PcvUo3AYUzuIEvDZRLUXwxwMaEVnF9O1Lw/CvP80aDgnkFnjLnQum8hPU4Mn42mXy+AG4IphEv/MpZUKBoar9UstSxnHLAEOpKWdzR9wfB3S2PkkSwkqXsTobmebY2Fkuz7uvdTWDrKC5o7hoxLqCvyJ49UHkRNATANVph40y/siCW1AyYXGaF1Jt3gDXqVOHMmuwVHVCURQQo4GF7xDSmg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e/ImRGUKclv4L01W4gnUgTQ2PXKpJkMORfZP2Q730zQ=; b=M3/RFEObSrr18r8LkR15KV2HvQeC7t20/jtuOBBtvLLxjDaBxV5WCqDc6XeJ0Nrvb1m9VNFzcwe1e1DOqeI4tSoWARG6e4b+U7uqE5Sbs62DNhntq1krfbLG8MA7QGeC1BiGpBlwQ5ZkP7QMGmUDVsV3wvtz5IoNjErxHA9o/FlpN8r5SG/XloAvi89jtfCGkYApLOvOsXvMELcYb7jVT+h/USaOriNabwsOlR6Fx/7vpiicl67dAIP3j5NXUET3Oe885DicN+pXlRjK9DhP72V4owPwzgAHzwJB8/Ie779nEg9kbniMvAsnq6FNjQsWp2hbwUHplzpwu6mltmsbeQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RmdHr0mozKoDr1W74jdEzUJ/QRdBC/ecHDMtOA55YnHDIC7vMarmuHNBWq63DwDfnZ11J6+GkiI263L57SDRUiWg9sArcYLKIgE97lNf6vHnxDjDoVf2hoacPG5JtA/szn09zCHFFmxo1ymjVj0udEhsyc29US7hmngf46YECqjwrbS87PruOP81QzYJ9JX6raDGVmX0Y6t2F5RxXACBmECaa4pCKygTEb8GzCtSm6YnmEPu43eO1+5g2IPbLecDbNs9ld86sKIbY3wSwcuTudROP7O/N2THLh51+vdnfE3wQnjd6O4z2ZIOWSjdXksKgmIEHF758TQzyjRGzl4WIw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Co1MfP+smSvjLv49ZvGCblkPWSy54CVM/x5VGeGoDYl0+SpPnePhTeyhvPM20IjVBdgD3KTmM+kcy4a2cVWI03t8pxYPp87XzcuiKrNi9CLcgPnv87GgeGLSQBgsYhllsmeUcFr4WjYke9lXBpOTcBPvE5ByDazdRUKRL+qwUqL8NJNbvnZeGnEVDRiB5OZ43KJ9NjyjYkhuiRZYDOJUwM3wzTiCFbvboztN2OjORd2lBjo4OgqyoSIq6lTpxDwPZ8s04IR63h+n7TXX4ontiIrhrfA40OTz1XVpAuRMRAmBoTe3NYW3MX/mukoUdUreOmvHUj3wDB/lKesrDaDfsQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Wed, 07 Sep 2022 11:12:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYweQzyVikzADCFE2Bfo+zYT5rgq3ToyoAgAABNgCAAAHYAIAABH8AgAAAyoCAAAC7AIAABHeAgAAOWQCAABGIgIAAAQ0A
- Thread-topic: [PATCH] xen/arm: acpi: Include header file for version number
Hi Leo,
> On 7 Sep 2022, at 12:08, Leo Yan <leo.yan@xxxxxxxxxx> wrote:
>
> On Wed, Sep 07, 2022 at 10:05:54AM +0000, Bertrand Marquis wrote:
>
> [...]
>
>>>>>> I think a define in compile.h using stringify is the easiest solution:
>>>>>
>>>>> Ah! I thought you were suggesting to tweak __stringify. This is ...
>>>>
>>>> Also possible but a bit more tricky
>>>>
>>>>>> #define XEN_STR_VERSION
>>>>>> "__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)”
>
> Just remind, We need to define XEN_VERSION_STRING in compile.h.in rather
> than in compile.h, something like:
>
> #define XEN_VERSION_STRING @@version@@.@@subversion@@
Very true but you will need the quotes here
>
>>>> Quotes at beginning and end should not be there.
>>>
>>> I have to admit that I dislike the STR infix. I'd prefer a suffixed variant
>>> (e.g. XEN_VERSION_STRING) or one omitting "string" altogether, e.g.
>>> XEN_FULL_VERSION (albeit I see "full" as being potentially ambiguous here,
>>> since one might expect that to include XEN_EXTRAVERSION as well then).
>>
>>
>> Version is a value so here I though it made sense to distinguish that one as
>> it is a string representation of it.
>>
>> XEN_VERSION_STRING is ok I think.
>>
>> I generally dislike anything named FULL, EXTRA, BASE or other which are just
>> unclear.
>
> XEN_VERSION_STRING is good for me.
>
> Hi Bertrand, just let me know if you prefer to cook your own patch for
> this (essentially this idea is coming from you) or you want me to
> follow up for a new patch? Either way is fine for me.
Please push a new patch and add:
Suggested-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
>
> Thanks,
> Leo
|
