[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v4 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_*
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Thu, 8 Sep 2022 01:33:56 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GenzEgHIZOjwRhfyWebMvQmUv1NVzHQDyNaUWymoNVc=; b=dhczJZneTjkF7HUMNN+q238AIOT7FESoFZnuOSl0Tom1pI5HRV6dFJKN/p6kljHtd7MVkpsovEwfylVS+IK+HzmMaAofpYhvF0SLPGcXodrtjV/JByw48+WcHnx3+Tg1EEHb0RqU4tdabijUpNEpF0dLf4eimW5x79jh2pTf94yPA3TKXHXeZ031S4ya4/t4EnhbVTXze/6W6LhiF5BfYdhXq9+Eba9D1Rn7Qe7XsqY6YFEI+sFUE4rTkDkp3R+QtUSPWnswD+B0WZTlvwALA3/DdSBJMftLJV3Royy6y6HGOsxFh67L81GvoOl6xsqq03Xkk+fVBBp/o6pJgUZsNQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GenzEgHIZOjwRhfyWebMvQmUv1NVzHQDyNaUWymoNVc=; b=FPxcWNIIiu5jrjYRONG09wYkjn8sl+SHV5/YrjbkH7zkStRRTm4X3xsT6gCH1rmPPwqqyrB5po2lBBRjV6SePTsJh4lzkPKJ30yXFV7WIxr25mVUJ+iK0vqmYeO7KAkl6YBThWrHvT4j74+h/HtSvkU7ooN9Mv7ZBcDUl8gPa2cud6Rhg98TsleSa9nV3YRaeK3N6jZGCqUKOL+lS1RDhvpz+5LxXgHeAkXgu4YKeMoqGGBQz3AyYz49NXa2fpwbPPFEaH5ooe1enJtalTsQYByMZniN0gBs6Bjcf4U0KuGKyyiQT6xBqy1kJ2F+cmzaA/elGUzy8vv/Ym/ArlswGA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ZZVzNj/o06ueKTI2pW7ZfZJGmHpqrIBH/LxRM9ktAlndkRgOAOho9/RbPC6ndOh4Mt3Mh5jfmQ8SEo3jIvEP96i0iX9Y3q0dA+9AvdG0aEZzUK6vj/X/u+eD+A0lz8mYwDxfKZnRlZ+3uCkM26JZo+8RS5uRfqXilSVZt+y2xMhW3gGAmXj3lAah3nsCotXI/Q+GBUrPd/0clI2dDandYle+lmHxIhzECNA7tZW4fp/WcJPZwhajFggUUKfvgHX0pNBqI5EfGHfEBREBY02ffPfOI7XJkNJO7CtovYK8TaMg1a7Bal/KiHAnaKbHJgLt7wEK4nyvlacocQcq+mmUMA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G7X1PMuOWLBtqDYEF3ZU68Pv2U0f9/Buo7QLCX0qOAd/xueo4xTISJCXXd/ahE5sKDq1UqyllVOmjlvFkv776Lp58MErcf72OgxGme/pUevTUp4bf2y44HjduKGU0hvu8GlC9Gc3InxOTsPyc3grrgrvWoPE6KpohrqOxtARfGUMqFIR2u2dPdEG4zgQZcxCMl44CIZe4c0Ztbzik42LfC/wmPiq5zcmqOGuJgJIUiz/wI3X6L7hTFHRm4zJwDNzEKm8DPrkvGZgISaTlMGZeKyB4FpQHaQthu7ze6s86ctSQML+Mm4i85MdFSFRjsl2KYkuX1S15e6q7dBUdOUD6A==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 08 Sep 2022 01:34:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYwsc6S8K4gfOKFEuFG4G9iA/zZq3UGkiAgACmHJA=
- Thread-topic: [PATCH v4 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_*
Hi Julien,
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Subject: Re: [PATCH v4 3/4] xen/arm: mm: Rename xenheap_* variable to
> directmap_*
>
> Hi Henry,
>
> On 07/09/2022 15:35, Henry Wang wrote:
> > With the static heap setup, keep using xenheap_* in the function
> > setup_xenheap_mappings() will make the code confusing to read,
> > because we always need to map the full RAM on Arm64. Therefore,
> > renaming all "xenheap_*" variables to "directmap_*" to make clear
> > the area is used to access the RAM easily.
>
> You are also renaming a function. So I think it should be clarified in
> the commit message.
Oops, thanks for the careful review.
>
> With that:
>
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
Thanks, I will take this tag with above fixed in v5.
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
