[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v4 2/4] docs, xen/arm: Introduce static heap memory
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Thu, 8 Sep 2022 01:32:08 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IheUAavtjkvnKbrBSesn47mZoT1v2VxfZ9V90jdMYiw=; b=NFP08MeljbyRiHQ/mxlcT0nCHt7vkGjE8I/KjCOSJ0xeWTbWFjIJPMgL3fF871t6hvcN8KNPhHAUKx0Xso/0uUaHfF6/CJvJi9Z86OmVYYzGjnfAFLknbr5udlz9pQ+eBICW/rsJYWKbXGQtAoABe30lBPq9pg6wNP4eJn8VmK2a5hfyNZdbWw3riyAtJKMJsjs1XZhVC5WgWvlo3ue5yW8frY7+3kN9EH7JLOvDg1lT3KsGcO+fSIw7SggZXf2u0XBUaj8oDlEA071/fQ/on2BaXM1ezsBaNkeE0gEN9/1cLjNkYV67OMtkWUkIVVMbGWY3JwofgdRMdnIWsT3h0Q==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IheUAavtjkvnKbrBSesn47mZoT1v2VxfZ9V90jdMYiw=; b=Z5f338WzuML0PnYwSToG9fvviY24FT0xHiin3Z2lXm7KBB7TwuIgrNsSy5fk/YDLOuYOKA3ikt0pRBX8Vioy8nScZY8lzkBfv0IvJ8lcqcRag+D03vXPkNRLCD/LOJ9i8MgJM3yb35wC6B2e+SXi331Kprj8Ab8M/g/5lBa4ahJ/suwDIqbB1rlt3ddl0Fj5gIB5C/D34sUdKN8ajLlK8nxvqsW/y8vOJ11n5b0a1Eayq5Bj+qCVdUzpD2sn6iXW+qt9pMmbRJw1DJhswZVfW45ufGNCmlJ+9vKr2R/MeVoo0fTVPC6KV/pX7G/+lCzhvtYHfuGnuhQ3TME+WzsyJQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XFljItzxVPzk7ssOLz90rBRSB6J9aPEcsMnaKecA+s4XRYkChj55bIGL4WSLMZvPvuWVxXOJ4qRQq7ZnhTOGGNc0WRdphrhLrnTMe5ZZny3MAli3hQIKmhSJevNwehto53LzEXOE3yp/Z2DC4WKZAKlWNHroJPHchrJo8EHJ4VWxyG8y7iCume0stcP4Ra4YEmpRZw0nk3AXOToaHO5oHQDTn8DMROvQiGWApuG9AV7zV1fSrPymhO7aXScEgT9WnpSMdyKAoJmt963+ImNc5MgobQPfKd3bNmbugQ7i8CTQgWwuVBU22xke5DAq3BYC7qxWq7EjYz99Btzb391Uqw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IK8cxVeZ5a5Q8veCDJpZyj+zKv/7YnbSt8M6hBMROCQyNrcRshhVe8/D1wnECTonhhHiK+J18BW84qUXT4zAkACD6bfArKkr/miKskhTobya3Da3DZ/2wloFILmMNzWjXumzUJ+7SpXXfWrIA+WTrnifC5X2+FoSng1s+E//blw7YSxPc+uB/p5K2Uh5WVdRn70MPNupuUI32l4hICxJwyoqrh/R8nceD/962xmjVn0I3EOpluA/jG/wHkiMKzcW9zUBQs4ZKVJqZwclhySfIDwj2/ZAvrA/SvCeyva3YzOICWrP+aMxpuqg3XQZgee5ZNbHZzdgj7lGZnDznF9qqg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>
- Delivery-date: Thu, 08 Sep 2022 01:32:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYwsc8IB/BGoiaOECLtnnc9tK+sa3UGc0AgACl6FA=
- Thread-topic: [PATCH v4 2/4] docs, xen/arm: Introduce static heap memory
Hi Julien,
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> > +- #xen,static-heap-address-cells and #xen,static-heap-size-cells
> > +
> > + Specify the number of cells used for the address and size of the
> > + "xen,static-heap" property under "chosen".
>
> Logging here just because it is easier to keep track of open questions
> :). For the future, I would suggest to list them after --- so they don't
> get lost.
>
> We need to agree on the naming scheme before this gets committed.
I think we are agreed on #address-cells and #size-cells. So I will send
a v5 with these changed.
>
> > diff --git a/xen/arch/arm/include/asm/setup.h
> b/xen/arch/arm/include/asm/setup.h
> > index 5815ccf8c5..31610ccd65 100644
> > --- a/xen/arch/arm/include/asm/setup.h
> > +++ b/xen/arch/arm/include/asm/setup.h
> > @@ -22,11 +22,31 @@ typedef enum {
> > BOOTMOD_UNKNOWN
> > } bootmodule_kind;
> >
> > +enum membank_type {
> > + /*
> > + * The MEMBANK_DEFAULT type refers to either reserved memory for
> the
> > + * device/firmware (when the bank is in 'reserved_mem') or any RAM
> (when
> > + * the bank is in 'mem'.
>
> Typo: Missing ')'
>
> This can be updated on commit if we decide to keep the current naming
> scheme.
Don't bother, I will do it as this patch need a respin anyway..
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
