[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
  • From: Henry Wang <Henry.Wang@xxxxxxx>
  • Date: Thu, 8 Sep 2022 01:17:22 +0000
  • Accept-language: zh-CN, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X7yDCSamfKK/lBbBhwu0TAL+0KunvxQ11SF8NZsaBHc=; b=KfveL7WtcqtqWSkkYFTeH/KtwP/tKkFsdwofcVimpwdoq98y4FHwKcbodYyFglLPjtnb7o9ImisAz+VVVa1Ltp7xbZU3UBB29K/P31sKpavwZMVLSHoOpS1wr3SbiiCZ1FXKGD1SDlx0hHyUUwWQUoDEJ/Y8gP9l1Qc7o7bzxrZv+cZ5IoJYVedRVrl9uQ7Yccm/HSIZ+TuPHQra0BObM/YFQHz2UfhcAWGS9mGchPN33Ipq68CKUGpW7k6hmIwCFMYJ5aflC92+R7zk7XqcrKvODLO+bo3Ihxj0Xlo/56se71sNpsNFwKYZ2OqWvO1iHAOoy8Cjfrb28LJWZTbfcw==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X7yDCSamfKK/lBbBhwu0TAL+0KunvxQ11SF8NZsaBHc=; b=L8DwpyAQ0Cy5xbJTvrwT21xSrgvO921D+DoMtKuYHTjBCfBP/WQ/88cUEb6CXSsjKN1eAB5zNFGvS08EfndlUc2TPeqSecIMz3BwKQ8u2te46Hx6Z7eQAaiE6nvy4dKB4dEV0rM8rdZY2g02YRaO+P9FlOz14+GjGLiyz2QfkLwiqzrc/mBUIVUQXGLyMtey7uVD+3V4jlm4+KmdsCsrFxRPBG5BOeHuLvw2t8iykhfc8Lr+S3xJEfNVknATjgyUbHE2MSeMVQndXZhrruSrkvrC14RWbYnsU8zr9HA6HDmXsSQkJOoN+QbPeYRtrl1DUnvbHEcCL8p5S9hPd1YKbg==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NcjkWpANM7i0VASWKotOKI1JZ6FfufpzD52TUbRucFsFehyZEa0k5jAFA5FWHORModfJtCBFvsec3hjD+zvzS1/l/hWcgriP7su0v7aJLGFRabDt/5mIaB9VBcdW4oJluM4hdOppGgpIFPxtZvyOTsz5FT3a88ve2v9wBa0g88NhZCduKMs5ict7w3whI5VQM28/kg0p/w94eOTg/yBUOS7nbQJB2Sjy6DpDrRINkiXpvWjC3npG3Jeqv23pObvbC5C5yKd9i0QLijjdtNGldRUtiSuYVlnE2Dzkitq/7vbqmbWZ5zzaglufoOSBaX5Z208q4eW8XfiSpRIsiuM6eg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FWYpF1WW9Ah0s1IRDplyrScZGNmcwlwpGUZNmQts8hWV4PcEp/9a7KPpehQcbJwzw4iTSPLvRzkWjh4kw39IGTtZKeOFxsqG4lPyCuuzB2qB995Q6pT6ttsmX5p5vWWPXyqbINJkgCYw7MiVY995Ft+pk/InlfmQ2DuLoSM0pe2YzYNHSivHlecaPO46d3kdDQ6T7A/QttNT/8oUxJKjdgwRQqo8YKEToirkV5Ttnqe5J7svBZ2OazBOl2UsVQ9J/VTusiDQk75eVkSZhEhqLiq32OYgK9KEwGVWekSFmO1rzaU6zgHKy5VVV95SbKTFkCL4W4mi6pVgZzQyrcVdZA==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>
  • Delivery-date: Thu, 08 Sep 2022 01:17:57 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYwpUJ7IYztv5II0KGaSuPgw9aFq3T1xaAgAAKD4CAAAVdgIAAAr4AgAAA5ICAAAbIgIAABXCAgAAA4QCAAAB+gIAAARoAgAACMwCAAABysIAABM8AgAClgQCAABX8MA==
  • Thread-topic: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

Hi Stefano,

> -----Original Message-----
> From: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > I would not block this series on the renaming for existing property (what
> > matter is the new ones are consistent with the discussion). The renaming
> could
> > be done afterwards. I would even say post the feature freeze on Friday
> because
> > this could be considered as a bug fix (assuming you agree as the release
> > manager :)).
> 
> I very much agree that we should be consistent. Consistency aside, I
> would prefer *not* to introduce #xen,static-heap-address-cells and
> #xen,static-heap-size-cells and instead reuse the regular #address-cells
> and #size-cells. I think there is no reason why we shouldn't.
> 
> I was about to write something about it a couple of days ago but then I
> noticed that we had already introduced #xen,static-mem-address-cells and
> #xen,static-mem-size-cells. In order to be consistent I didn't say
> anything and gave my ack.
> 
> But actually I think it is better to get rid of them all. I think we
> should:
> 
> 1) do not introduce #xen,static-heap-address-cells and
> #xen,static-heap-size-cells in this series, instead rely on
> #address-cells and #size-cells. Please write in the binding that the
> number of address cells and size cells of xen,static-heap is determined
> by the parent #address-cells and #size-cells. (It has to be the parent
> because that is how #address-cells and #size-cells are defined.)

Ack, I will do in v5, also drop your previous ack so you can take a look
again. 

> 
> 2) Also remove "#xen,static-mem-address-cells" and
> "#xen,static-mem-size-cells", and also use #address-cells and
> #size-cells for xen,static-mem as well. I think we should do that in
> this release for consistency. Any volunteers? :-)

I will add a new patch in the end of this series for static-mem cleanup.
This can be merged later as a bug fix according to the discussion with
Julien.

Kind regards,
Henry

> 
> It is not going to break anything because, not only static-mem is tech
> preview, but also it is very likely that if someone was using
> #xen,static-heap-address-cells it would be setting it to the same value
> as #address-cells. So in the vast majority of cases it would continue to
> work as expected (not that we couldn't change it anyway, given that it
> is a tech preview.)
> 
> So I am aligned with Julien on this.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.