[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.17] Build: Drop -no-pie from EMBEDDED_EXTRA_CFLAGS
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 27 Sep 2022 17:52:44 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=peLxow+fyZZz86PyCAEs4UsoiHFSpvnKnCocSF6eHIE=; b=WGPSzq9UXWFxy2DzzQPCo7JXGmQzsLm0xysCs1BagzVT510tjZViyNxalj2Nq86Xqor1B2vYwq6gIi8yRxrpU4wMMWP026md+C5QHwOfNkU/vQAjJXAAiGPyHJfN+JuOJV0FqL+L5kYyLuff9zaTpJD6Njt7oMGSftoXZ2rSBI1zccjuYbm+/AluflXQ/l+WIjFFgCCEYbfu1pnwBSD3wOt5ufImSMJNwQt5782KWazOK+yPDQF973d/IhPvG9PlTyiBMJ85szH0aOyaj7I7+pwxYcXxo38DauoM1Fcauh8rb1hz9xULGWMmVrYlTuF6iuhqmdjl6fw6G+xq6Wbt1g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dBOgL9NA2skWMIkbHkaK3WC9jA0jsKEorr0Axzh5leTVzlvnhQEMQ7CBrC30LvDEVZ7YA34u8AD80UTVW0dRMUkhFCOF0NQY9/PwCgpWToY/kbbikgY7SUnUkAASS0YQg6/88LtP1UN1/+zOonTZ72pNywEDFWjbYw8LrVEfa7rqiwMFJxhJVF40If9iwWtRvL65W48Al10wbbV7oQizxg3AIotnyz9OXdUaFQR6JQ1vhl7tCwffr3w3hRBrXtrZXQP78HQvzE2rxTtX+8u8xOEiNA25c1Q/lwwdff9mL3y3eDkOoQjxLd5mhhGCNE6AV/N2+vhIJK6MhN0ESy1dcg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 27 Sep 2022 15:52:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27.09.2022 17:47, Andrew Cooper wrote:
> This breaks all Clang builds, as demostrated by Gitlab CI.
>
> Contrary to the description in ecd6b9759919, -no-pie is not even an option
> passed to the linker. GCC's actual behaviour is to inhibit the passing of
> -pie to the linker, as well as selecting different cr0 artefacts to be linked.
>
> EMBEDDED_EXTRA_CFLAGS is not used for $(CC)-doing-linking, and not liable to
> gain such a usecase.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Fixes: ecd6b9759919 ("Config.mk: correct PIE-related option(s) in
> EMBEDDED_EXTRA_CFLAGS")
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Perhaps the Reported-by: Stefano should be kept, even if you noticed
the issue as well?
I would have preferred a mention of the questionable origin of the
earlier misspelled -nopie, but I guess I'm not going to insist.
Jan
|
