[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.17] Build: Drop -no-pie from EMBEDDED_EXTRA_CFLAGS



On Tue, 27 Sep 2022, Jan Beulich wrote:
> On 27.09.2022 17:47, Andrew Cooper wrote:
> > This breaks all Clang builds, as demostrated by Gitlab CI.
> > 
> > Contrary to the description in ecd6b9759919, -no-pie is not even an option
> > passed to the linker.  GCC's actual behaviour is to inhibit the passing of
> > -pie to the linker, as well as selecting different cr0 artefacts to be 
> > linked.
> > 
> > EMBEDDED_EXTRA_CFLAGS is not used for $(CC)-doing-linking, and not liable to
> > gain such a usecase.
> > 
> > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Fixes: ecd6b9759919 ("Config.mk: correct PIE-related option(s) in 
> > EMBEDDED_EXTRA_CFLAGS")
> 
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Perhaps the Reported-by: Stefano should be kept, even if you noticed
> the issue as well?
> 
> I would have preferred a mention of the questionable origin of the
> earlier misspelled -nopie, but I guess I'm not going to insist.


Tested-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

and committed



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.