[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to ordinary RAM


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • Date: Fri, 30 Sep 2022 12:53:46 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J7061ZzpFfw9cltov4YtMRU1Bm+P+oDbBUi0e9qeKnw=; b=PskeCwYpiRxJVTU+6hKCyIC1QBq6ZFf7+u0u3bfl5mUbtsiecpn4IhtcLrzKkzo0O4BJOulgGwMYN2c/CSuJrBS6ncy8uVkai3Cu4oIeMfWvTDDIb9mfeUXoChUgeGDxUOCcETj6b7k1Y4TlZWbOA+/jgSksCL6pokVqlMy2PEMW6+P+egcAWyXU5f4alEV4/AuKWjAZ4oUkoZYSRWKLZ8B0oPSlyD968mZxdWl+sIou78RGeijqsfFehdWFyYbD2w8OGJsGcQuqeMt4qvEejMdLA9znONJQYqRUjl3B7njlE/iLBunIIYlOq9TfnLieb6AvkugP3gDoW9pXj2vpDw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dHDkf7kzY8IERtupepBlHZOTeD2Lx7cvGCo5g3NS8Fkp2JhOJnloaIWuLJPziE2Mf1o2YRKchiPjPstAG8Rj+1OWG519UYk1qwCZnQbZggtbOPix68PIVV4PUjxFMN1lXe3TJtrAy78jTaXoodyUGCBQd1O68qAups51Dg9uxhsxd4JvNoQN0gzJ/HbdU3eHQ1gGm+PvslQ4uIQemnK1zBgQ1dLwhCKpOBa0kdP/bkFh5mI9zkKJ8VwfK20VBd/AB0z2r+TfWcY0zSwYtMjJdAvmX/DRb5tk5cekHFO0w0ZE8xjkVnYoBMGTXuz+YPBpPsPuaTPY3AHU9x4zvP9Cwg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
  • Delivery-date: Fri, 30 Sep 2022 12:53:59 +0000
  • Ironport-data: A9a23:fKSKsq7RD3rZYrxOikp99gxR2vbMJc67UCYv2ybI2n9qXhjvZKvfOBssXYv8Wpfo+PeyQoVEoa+/cxN6ZIJ+4YuAx8zB1MK+9aFtG1Ws5A2WgEhWToypr6DmCQ5shkJMLLsDjgZpzCWkm4ZkjSK7VWu5Z6faIw6/B3yNhnyGnCyiuGTnhoQMSBwPtd0fB3dE9yZA8oT4hGgLjMLP7qUquXjXWGDyci335vdvkTKnT2ln0s0N743uQd7RDqHJG47eyF5tARZmD6pyklETFmfg+10acZPqP+R0BDYGTVea3ejJSeU0DohZaBV+UFoFzXLHAt00SkqqdbVfiqWtdAKwxJKfMXeDTOnqFnBYsiRj6txcSRzkie2HiRbB4qp/gwhW0oxgkrQFlAR/qBaxTzsGCxhLxoK0oFMBVSvnsJ7d/A/Mszf6xJzpVMY+4xbJm+uy77e92AKatI/2cCjdvuUy3TycUelu9O8dH4jCz/ejMBzHqn88lOyNiMsKtpP9XjETIrZtcvZhtfys/JGvV1akNCJ/qtSdVm27+/opUPr8nxjqiaoiby3Ch/yb9Wwh2ZOsTfCustnQ844r/oKGNxtjQDEeXqcBzTy+0BYynv3psbbKZ1PudOVoDW2+WZG0axHHhkEV2R3jctaov5QGShfoZc1fGdaY9HQJUMTR0gX+NPBW3qTMS9Ol88DYqYWyIYN0L/tL8J7ADQoXMngpEk1obBHTzp8r8+nfeeCt6uzSxlWEF7flWV5GwBnzgbtujdsiD1x3+ZOuU+Lk/83i6Lnjx9fHX2z81AIZ8MFGxJi0fM914w4/Yz5Oxu/3vN9ewVuXdZoxGDLv9vR1PXQWxlFZo0T/JJM4mqMleciuwRD/lWYWmTidqNfj2Vs52ODeMq2N+sGvnwE7uRqCFCCLk3NaptgStwyEqkXMm+ltw/xjuCHGlIM0WDVjGOy4VewiuKqDp6vM141NxBXkMz7YzLP9uT8bvfa5fx17RI2RCQFEiAfzgS9VqfPNZOr+4tXxVkZEWYco2fJQIzUOEWlKykDmvQVToMUOLz5fqzMiBlUBaWjajCrbhdnrACrLYzzV2tUh2JdgSxc1NnfeaHEcek1dJwd78jKVShT9nzjZ2tBcdaVX9jb3pKHhMIhmq5PU0kN0DHRMJvCkIk9aBoPAd3IzduaLSP6OSoRMpbj8FYt1Cz/es2pN2k3Fkx2wJ+QfSBDt9tfDefpICnoWiG5YZNfJhmkKDfoNay3Ua/rxKPqh3Y8n7kHx5DmqYe7EPUiFrxBMpRR5OwvX+230Pir7xUUVNbxnptzKKm4RR6rYiC4cgeQtxrsxu0u7aroA7y1rv9ROwFkOitZfFVYBqQWyyjg30KJ18o7qPMmMB3UYqbMd4FRaXsKiSXxKOkZCWnQ8wz+rabxrIPq1epZ70QCwq+RMafmGdpUvJ+8bHIXjeIPd9ygdO7oHcE9d+z2dxnnZKLzEveeeix5mY4MJzDWS1V0M+dqVK7Ck17F4FIxwnqC3r8HTCn1H8ArEcww0M4uc3okLRZhXtwbwc7sdJli4AA1fpFpMhyHH29a7FbQZlnkvSYAmHEu+CgawZy4Mc7MSIz0gluqWA4bsaw3ygjdN3as6KucDFSDTMkawrGg9qlDj4DykgzZzWrGlprAa8Wz1itKKD+1DbQkcUjDgCAO0WgWXH05Xr9QHQztkyruEi+0QmTfdoam82rBJUi+XmYblJIfTv379ho6Y87QuI5tqFAqVddUOtSgKWde/swaoDOKMywQjeQ0B01cq3i3TUb8hQDZI62uqZn2ikVyN9Er6bkOYfAZIW7YsYIduSMekusdN/WZ5ah9vVMh+lW7FDri8cvToGXOnJjg7wmKNqH1sY765SlWCOYG84y1DFrYg6oIdiIs5bLk92cMgGQRPZpRS65NTFFnmi8vmxaWOdEUqg7Vh87nUnkmaJPzA5X8DA387XS9XsqjJeTz0qraXX+tXNu9/Y9hIQ4v0TIpontdFbGSjgeWGpukd/P0SbECT8f44DEEj8HP4WJdnh6i8oN+TVs+58ZflLaBmaBMIe5IKqgxE60iV55QjSYN3rmyDpt/5pTv/8JGxBE5IwgxTZ8x8Ph9Y+/v/8NAoapJYMx5JuGmVkzzKuEJUK4tq12dpc+QXHCuiFXXy7NRClTBfckYH8q4wl41gci76QtYTXvBfdwaxrdb95p0TFWvKZkAyAh/eclIMtoaTNlZfXZiA8Pf0cfNJnGNwWbCz5KVe9OeqHgBlwutwNKW13P9a7vrp6YoJvobjmYmGb6Gg9HpFQdvOOfFjIWPku4zlstlFNz+RIghHMw3HpvWVOvvI6m596mrEsfwVbp6LYtjndzBX8oVb/yELUSVj35v8uAx1M6iD5NjWCnAEyRUi+CZGQ8Az33vwoPqj/lKzRLYifLNZlcfs9M0E3eXVBval2iRonYu5khFwp8OdUgTT6EyuH7jUZai617eDrEVqp4/82MTqjRy0CNSMg1Fks/vcPyevEMeEkXiMjGtozV/Xqo1JCAYLb8AI3ataZSI2mHz8BwbsW95p3rcSJpE7sSW+yPO6wfUrRbqwz4s7FhGTWmsw7lq+LEwsF2qY/oO87zqcayXG2I4l5hDlkNzv6re0NHbcLp35KKOx1XcDpC1BNiRH15rSjI8OrCD5AWAcRzKvoZTGDoIYmLkSbNSNsBSqyyssrQ4oCW/2fDGYAU4pYLjzj5KsAvg4SRhSG5OUcNipMAQa6jAS3tys5GY=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHY1KFbLsYTqKjbvUaNuuSOaOWfM6337hgA
  • Thread-topic: [PATCH][4.17] EFI: don't convert memory marked for runtime use to ordinary RAM

On 30/09/2022 08:50, Jan Beulich wrote:
> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
> higher priority than the type of the range. To avoid accessing memory at
> runtime which was re-used for other purposes, make
> efi_arch_process_memory_map() follow suit. While on x86 in theory the
> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
> E820_ACPI memory there and hence that type's handling can be left alone.
>
> Fixes: bf6501a62e80 ("x86-64: EFI boot code")
> Fixes: facac0af87ef ("x86-64: EFI runtime code")
> Fixes: 6d70ea10d49f ("Add ARM EFI boot support")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Isn't this also liable to be the root cause of the crash reported on
IRC, where a read-only page was being inserted into the heap?

~Andrew

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.