[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to ordinary RAM


  • To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 30 Sep 2022 15:07:48 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bzLpBGp7hs+UwkFZ3efQGLxJLr0RpDbq77EgNcKa3jQ=; b=VVyZjotN3kAZ+P6rZpdIFlSj0SNaETjpfUfsvjLOyScduFdO0kzNEiGiicz6zKSOahED2I3hTeF2PH+BeoYzGZFyXvQnKMiB4z94xWbi6o2INut2CsBS/zlVyJvSb/jFRrmhMKt7kFcU81/2eTYWLKpac9qN6flGV4uq9ddfq/vfcX2J55nwQkLFTU2bGMAZrm/5frgzmILnBgINlOEiJFJnUBla1gJ62EwdfcjC9Ha+XOtE/IxKigL5T2ixfHWnChT5ggsBH6c3fcp3SSWfEjQutwhefz7YRr399bxwfK8WmPm6cf7PYC2GHHHQrsrEF9XMHuaxy9zpJNyu8JbkWg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CgQ8V09LVWLjXwftwhDJ0pXFoHLvGNRqSd9AZsxIWD1BLNGrlVlNoogRkMYvFHuC9cZYi+a/9CVa2Mra5+VwzJcOmlPARYtIVoJOqheuZBYC92DAFINW3Io7fnT27TPAx9P8vVkxaUJydaBj31sVi0wh9d2U3X0haY1nxtWiZImxbc9RuSPMCjnxENC02WHCsW2KV3DizXrk/bLwGH57zkOLL+SbZsNjkPjsII0wJKezssfYkqg2kfYZqnfWW28yJWDci0kMT/ELHb3YIwq7+8Yl8XlDHOXzf3tgqy7NPlPMKEB9o9VuyDUi7Li0q8uXQIyQzIBMUDOEXGc2EaE/zg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 30 Sep 2022 13:08:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 30.09.2022 14:53, Andrew Cooper wrote:
> On 30/09/2022 08:50, Jan Beulich wrote:
>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
>> higher priority than the type of the range. To avoid accessing memory at
>> runtime which was re-used for other purposes, make
>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
>> E820_ACPI memory there and hence that type's handling can be left alone.
>>
>> Fixes: bf6501a62e80 ("x86-64: EFI boot code")
>> Fixes: facac0af87ef ("x86-64: EFI runtime code")
>> Fixes: 6d70ea10d49f ("Add ARM EFI boot support")
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Isn't this also liable to be the root cause of the crash reported on
> IRC, where a read-only page was being inserted into the heap?

I wouldn't be able to make the connection, I'm afraid. What was asked there
was lacking details, though.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.