[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH][4.17] x86/NUMA: correct off-by-1 in node map population
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 4 Oct 2022 12:26:52 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XD1vnsET9GCzUIm+dVy3YUvbCvc18cl3H4qHAJcprc0=; b=Rd+XcpEL7SN7KDxohmXk4lTctWNEdy3CBgMiYOuMGhQpnvNZdmeA7zbZdT8efo1OQ5IbEew+nJHlnDWv11+zvzXZztAH7xayqfMwWyYkoVlAnNRDhdxXOvjBfp3s5SZlpJrlNTBbL+VMkJb+hHk3Tfj4ScF0WIh1y6PdvhudqUkz8sIQkO/AJtg6dDcCKUawBhlD5c8I6eWAoH8I1jU+yQkidjUdWZCiJtata+RU05klmFPqgl64/hozXmsQiDUaD5z9GG7AWhoBtWeSgzTWAiJ3JKVtNxRWVkhvbxD1zKFRlDQBLQjCzTMGB0Ob7BRDisUVqZXVmwZP6Rc9B65fuQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dpj3hj812ExuI3BD6cv9yuCILuhG9GspE6xNyyzKs/SLZH9z50JjWRJhZ9+v86OfAgX727HDP+rH89eZlKk7t2ou5Y99Xb8StayxWu5DNq/JdCkNUyfBunerN4vAv08NkZWagvJw4cslPXNtT5h9alPA4kZ6B1WGvuxP9GvmCplMJOm8UvQMXp/G1JtJrjwOA7tmevY9eJ4PzwVSpgLVIdUGW0cFGQAaauB8QwvrQxGUWBnkWGx10vJ4jCNEu/peIau0/5oDNMM1LEDIsf3kNiLYDEnLcREp6m0dhDK2CdB2HVBexwpsUbCiWVRba4JtrPsyr/opJ0LsBJC9XHtXLQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Tue, 04 Oct 2022 10:27:22 +0000
- Ironport-data: A9a23:k5JKEaLxAym6EYKnFE//H55yvHf4RhNe4xP0qkmnJc0pyRJZ0RWMlPhd8sEGEan5YGQtjswdUusWqfUZCV8fw9TjAerbME2vT7P3+0XZ2uczS8WyRM/++sjSsjFWMyDg0ZGDz6fpM8T0ZtKpAB+CfeWy1D8BfQUP2PpWY90qHIb0azKmwjeyHI8WlqKuHW1F0epPqSjqevL6CcCEIKc+M941qSAT80mmRg4pW7q3Evzw7MNaokc/yIisfxPljSekplkqcNZ1U215kCy47f5SwVE7acC+psrpUke+VdPQRILjGWMEb/vmwsMZAyZzlk5k5J6G+XrGN9bfpbSf4XCfL4/8PYD7yytXahD22O4UDBSl7ETA42++RxfxeQks9z2n0BDBwVeNYApUhNlCd2xjppsoIJ/t8TMsCYTWW+1mhV+AgsWDyvipBzYBIgyGs+w6iX8xp/OdDCbnnTp+pTkhmw86z9JLfjMmgY3rmRnfSwhiYKUdgTkLLYQuq9C3lIPU2dAp5xVahBjdTSSvJhFVFrisnUx5mYq+N+L9RmdeUBW7eNvA514E9nS5h+J0rSfreSUtUmFc54gHcpeO6+Y04jCUPwlDuR+/OqndU5VNhHAlUFp+ZpGwd48DxZn6U3zn3FFtFp8+aORYrzUx0vHAdetuscB8+HyZWTQRvrtGxUL1cKY2N9H4n41RH0kUAYWO5hiyZ8+easUN2Khn83j4gMS2raeRAhzXXL0gG4bu000TLjK0OdscdpxaPZDHwqUMRLYZc1OQbQs5/fGUu65+gnOf0l2FLBKblIYkPsVvVZ6yQMfr/ucZGDvOtmwjDI1q/XynjTq2jGR6iB9iqpSqbWzF40b2KKGz/m7vA25Y5fWY7DRoKR6mGXmmpoIJeXVR+H3wFmSriIieoAOVcgYccmiMIt4D8AgFWdm4jmVMqMtyNo959E76tLnXf5tofEagGO604hn30WLk9xJwe9sLRf37SDz9HgRI2mVfgqJOj3aYY+kzRHsnBpFYUpc70sasVp7nZKIEVHlV00lguvm/0xvLkOwCqPTfa3jG9AiYuQqo4OK///dtePuEZQqUTn4nanIC5dpkp2G1LBzQ06vFpIx0PIavB6EPsHkFeFbw6YHM0d2eH8GhwZN43YniqGcUwHTXqLyh2q2NUtoAp7TMLW/7S4uducxlqKmwM69K2YxW2t3MZmo4xS2lz8hh34JRtw1Pok/4ffVkv/oJU5RUkXTfa34KC4ZK54MkcfYt1CguVl8QpYE5AyOBL5Z9s+25cJokkoZlAh3UhuFdldTq+GjILecs+KQ8MB3m0tAObjpkz9AhPQcG5GYUWh/+7FJXbcYU2BIb/BDKczY9PV9SQPQ44LLCZ7KPCzxfX9K1ZPFG/lXhKFYC62LfvZ3Himz+6U+xwEW+hA11D1J4YtrJPPM6/PUd/6UCPEOOYpeuIFzqscupOaAEuf8JYF3Hz7sfm58rHShfq93dtjeufjlCXRNqpu5RjrhRlSKATkRrX6YOOwg7gr1mC3lbegeamXQ9v9gB49+TuCpGUnC7fYmiUkzIo4u4uU+GNlHbZvNRVOzuZElG8f4rbmbDTPCrCxkiipyDYhzINmZAXCXRMcvrIFyB8h0HKLtZ+qaXnZaBJM1e5mmBlcrJ8Aeg1hZTa1z6MPme3YFK9VhPwBtEX71FlY+xu/CUfp6t5RVNv5c0Rylxgi8naTrNcqJGyMaZrV8ovCcxnsuXin56ZURss9jEKc5LKNwDXVWouUfUdsibcyMqRI016RU8io8g/l687ek07wxUyXWyVt3MKbUXbskw4OvdQE+iSowSch/zoP8Sn6MzrhXdtjUAPzSKbKJJe78oeFVmOsluEO2KGeqdOt6pMj7IYUU3ts+Gl+qiy7/RyJV6h4MEtK8IvNTgKKLYJGenhEufwCOqUwjx77MVQaVJOrhIme1Z2ugrRREu2PbK1/z89b2PvXKyuv437EVzQqhSMiHcAsj4AUdlpitIYENVGu8fALzMejta5Fr4nqg3zpKaXOr+xlBxOzZsqhrMZTbIa7bkweAAIjM/f+SyrIwHI9UKcUhhSk/xfG3W92C4zX4EjBuozYv4zWyJkNYw99CN8SbTcDJOOOzBp9pqPn81qM83xV7+A9iUKIflGTXyH/Ma81n5Dq4Pqo6sUhwtQhX5FVd5MCgtyz7gJMh+8sYYLsmXSFQs8hbItf+Z18OG8sL4ISXuk3EfkCT0L7h6Htkg9RN9q+wPrK/RgMVo5qw+xM/6l42sRY/+mpFMfUt9HyoV3KJGs0LC/eHkOdTCqYH6uF+IcylI+veve2n4gSX43d90/xcc+pHBWOJzgtGdP6CpXuu4HQktGQykCwZcOBvX5a8Wt2GG0YJ/VQzhmPBxzhQ/kYsIv1RONFZ4XwdwED5jc5Z1pmjD+l06ZUr+B1ml
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Oct 04, 2022 at 12:13:49PM +0200, Jan Beulich wrote:
> As it turns out populate_memnodemap() so far "relied" on
> extract_lsb_from_nodes() setting memnodemapsize one too high in edge
> cases. Correct the issue there as well, by changing "epdx" to be an
> inclusive PDX and adjusting the respective relational operators.
>
> While there also limit the scope of both related variables.
>
> Fixes: b1f4b45d02ca ("x86/NUMA: correct off-by-1 in node map size
> calculation")
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
