[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH][4.17] x86/NUMA: correct off-by-1 in node map population


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Henry Wang <Henry.Wang@xxxxxxx>
  • Date: Tue, 4 Oct 2022 11:21:17 +0000
  • Accept-language: zh-CN, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ReAYRI367OZFIFxwfeqxT0fiQMMtJKjlN9MiUmcB1Hg=; b=V/YtJYk0qMghMbPO72ZB2PSve6mT+lii/IsTt+GEKeWZ7ddmo5glaU85VTC5GvbLEsqypyyIhx/67/M5Jyn9Oy3BPEmizvlyzijsBeKHQM2eftJKH0LI/DAUUWpWz6/sbDR91BQxlzFhV8y5gZamUcyOkrGbTpuupTWR1PgfXy3Ac4E4DKbT/gbE+QCxjL7iJnyoRaJ92SXbJxR81LiNXbi2B+ETAhOWa/0JB77FDZrwEmZifSm50KF2LISn49NsuuxvE/KWGHdGOTgAiJOIJuG4SGkyyEFjFbMj1rjxpEqEuM3pzV0e/5lGNqBSU4CzoI6XNZ3GthRwKq3GMTFpJg==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ReAYRI367OZFIFxwfeqxT0fiQMMtJKjlN9MiUmcB1Hg=; b=ZPlzsAf+9tkw8ZpJW9oNu6sbMHu8E+Lp/TMVs79JIs6vTITl96VTN6HYQ5Azj7Agm2wLyAKLGDT9wIdCGcXdOykqc6C1QkmLDp7EcHNxEptV7uzU3cunUb5xFLIS+ucki/DeZIuuuDONfj4GZeiDO/RcCRGY3L4MqdUoxVWZo/F6GM6Ba9IdKwQ3vA2gyfJlsoSvPXAOmfUqxPP7xZGihkiVtnDr1bRG3m5BkKdAh4cxvmoqUcaL92qX2jHlQZarUYvcyh5ySLSkJ8vBewPIm1kAkLUA18x/jJUHbIh1JJ0k7LK8NWqS1OSa9MnSBVohILzXkrsO9H+S717dN1fHLg==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=CPoytFmEjaUiOucyUp+OEpwIZZdrtzDCsQP5HyNb19kSGui0qWLdPYQuPrKuRfNh1dTMfYMFYYw5O1YRqRjdDttk42uXDB/WAi1PJVOKksaA9MpE4w7Pn+TmgKn9UxhZHl4xcx8l56HuHMim6BvZun3P9L5Lh4h1XEH9uNj0+EQr2PkTpEtRoFaX1w76Ntxi1z4YAKbJsyl+ci3237pflSG+S1YH8zKrbCkAEa1A+GrWa7mffbbo6Lj13Kf+PC7uRIzQVHzIOD8J6+yYEPZjwDI9a1bBg6XNE80/mhpkBSBqbwAaPl8I5mx2KdFixdJENeU/3PoPwNYCXDjpLUL6NA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bm5JHXNluK0oaEpiV53SXbJrxlCOoGGYC7UvJdPTqENNjxgW2qH4Oxrcpq1M+Z7jG0u7wSqHjEw1uQNnCi7yPjChMzlTWzivvbbIqiYgwq3UdkXi2tTdFxspUU8BVI6F0z0BB2n/Dl0KfUj5eEB/4FHW2KyYHTch0qSPKESpKn5eFb+kCA7Erc3dHOdmbr3uqjfbCs4UEg8WltNSaHyZgN4UdIgdFRp0kv/qbv+nVuBPoXGATJG0R0EcWWNMEtxKyhx+Ik87JYYWrhI9BlsiECv4JcBM1paw+AinOg9DRfBmVWWJJhnPn0DbWIz6TKIi+i8I9Kb1IMB/txQAPg3Smw==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 04 Oct 2022 11:21:45 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHY19oJEykiG6eG0keCV/KH8DJyVa3+FqTQ
  • Thread-topic: [PATCH][4.17] x86/NUMA: correct off-by-1 in node map population

Hi Jan,

> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Subject: [PATCH][4.17] x86/NUMA: correct off-by-1 in node map population
> 
> As it turns out populate_memnodemap() so far "relied" on
> extract_lsb_from_nodes() setting memnodemapsize one too high in edge
> cases. Correct the issue there as well, by changing "epdx" to be an
> inclusive PDX and adjusting the respective relational operators.
> 
> While there also limit the scope of both related variables.
> 
> Fixes: b1f4b45d02ca ("x86/NUMA: correct off-by-1 in node map size
> calculation")
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks for the patch.

IIUC this patch is for a regression that we must fix for the 4.17, so:

Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>

Kind regards,
Henry
 

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.