[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
- To: Jason Andryuk <jandryuk@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Fri, 7 Oct 2022 20:00:18 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pwdDaWVuzpSISfnq0sYokkblNP91vPNR32uGTzRmxsY=; b=MwQgMIYcBH8FxgnSq21irwWP0dzxzAnKgQBlbs0t5iYqD6xj1BKE+F0nH9wx3FborKthS+ShGbsF7qG0YRHg6jNfgtkzmiQUX7nFq9MYkqfgvcoyOtY7j3cKgvkiSvMVABp/Vh859f/ARmlfhwNf8cVVUpHcgy8IlHN3O7P5+TYUNmAcCsVp4FggEzRuQi28W3S+YdK42GN5WXGBBE74WaKzkqJyoxjhf7MPafHKTShtnNv0qqVcTVtOh0cYPa9U2qNLlwvXt0BOMvytuIglGE58gVX1IrtrWubguZXtAfruXtTANlm1EjTwJdGWZXsoa0/1xqs3knkC9dazJcpEiA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KDgYrzF03HZJhnt6feLmSxodWZOMgBuW9The1VsaIXIVJ8tAvzOWfHVe3QNSqrZHFvqeuc0y+BzQ7vcQ2oNI/Qaw2cbxyXlaZzDrvcYg7XlxnaU7GSmW+Sg79PLHufSo4i8RVBz1Wm/qhnUeBYTEzlrCiYQSDw5QpHJN1XqiwnIs550FJGuI/uTSKsstsykf4BG25K3Y1gM5khM1TXgguvlirHaKI27z+lS30+H9X8jhxnpLHRq2+S8IfyF8ScxT0sKtPQnj0tG2R13BYPk7U4K7QCZ5w22Rd5opuKDYq6LaYyI3bWRyqCNtK/HTF+2A3NXFt/OG/4ibiMXujHUX0Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Christopher Clark <christopher.w.clark@xxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Fri, 07 Oct 2022 20:00:26 +0000
- Ironport-data: A9a23:F099j6B4CqA76BVW/+fiw5YqxClBgxIJ4kV8jS/XYbTApGwk1jYEx jcaDWmDOK6PYDekfowjPY7ioR8BusKGxt5gQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8pWo4ow/jb8kk25Kyt4GlwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kfEow4wehlGloTy vEGcihTciKet6WflefTpulE3qzPLeHNFaZG4zRK62GcCvwrB5feX6/N+NlUmi8qgdxDFurfY MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWAI7gvL9cLb4ECKpOB1+JHrPMDYZZqhQsJNk1zDj mnH4374ElcRM9n3JT+toijy276RzXiTtIQ6BuP/ptFJqXav2UMYMDELaEeYnsnooxvrMz5YA wlOksY0loAw/UqnVMjgXDW3pXeFulgXXN84O/037kSBx7TZ5y6dB3MYVXhRZdo+rsg0SDc2k FiTkLvBDjx1saaJTmqd+63SsnW5PSEPLkcNYCYFSU0O5NyLiKE+iAjeCOlqFqGdh8fwXzr3x li3QDMWgrwSiYsB0fW99FWe2ja0/MGXHkgy+xndWX+j4kVhfom5aoe06F/dq/FdMIKeSVrHt 38B8ySD0N0z4Vi2vHTlaI0w8HuBvp5p7BW0bYZTIqQc
- Ironport-hdrordr: A9a23:vH6BS6wBDUhabx8aK9IfKrPxj+skLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMQs1MSZLXPbUQyTXc1fBOrZsnfd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadu/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZebxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESttu/oXvUjZ1SxhkFxnAid0idvrD AKmWZmAy1H0QKSQohym2qq5+Cv6kd215ao8y7kvZKqm72EeNt9MbsOuWsRSGqm16Jr1usMr5 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGLf2RYUh2rD3xnklZqsoDWb/8sQqAe NuBMbT6LJfdk6bdWnQui1qzMa3Vno+Ex+aSgxa0/blmAR+jTR81Q8V1cYflnAP+NY0TIRF/f 3NNuBtmKtVRsEbYKphDKMKQNexCGbKXRXQWVjiaWjPBeUCITbAupT36LI66KWjf4EJ1oI7nN DbXFZRpQcJCjbT4A21reh2Gzz2MRaAtG7Wu7BjDrBCy83BbauuNzGfQ1YzlMblq+kDA6TgKo SOBK4=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY2oN8A4y+jZE/1ESf3tQREpmAra4DWdCA
- Thread-topic: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
On 07/10/2022 20:31, Jason Andryuk wrote:
> I observed this ASSERT_UNREACHABLE in partner_rings_remove consistently
> trip. It was in OpenXT with the viptables patch applied.
>
> dom10 shuts down.
> dom7 is REJECTED sending to dom10.
> dom7 shuts down and this ASSERT trips for dom10.
>
> The argo_send_info has a domid, but there is no refcount taken on
> the domain. Therefore it's not appropriate to ASSERT that the domain
> can be looked up via domid. Replace with a debug message.
>
> Signed-off-by: Jason Andryuk <jandryuk@xxxxxxxxx>
We're into the 4.17 release process now. A bugfix like this obviously
should be considered, but will need approval from the release manager.
CC Henry.
~Andrew
> ---
> xen/common/argo.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/xen/common/argo.c b/xen/common/argo.c
> index 748b8714d6..973e1e9956 100644
> --- a/xen/common/argo.c
> +++ b/xen/common/argo.c
> @@ -1298,7 +1298,8 @@ partner_rings_remove(struct domain *src_d)
> ASSERT_UNREACHABLE();
> }
> else
> - ASSERT_UNREACHABLE();
> + argo_dprintk("%pd has entry for stale partner domid %d\n",
> + src_d, send_info->id.domain_id);
>
> if ( dst_d )
> rcu_unlock_domain(dst_d);
|
