[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Jason Andryuk <jandryuk@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Sat, 8 Oct 2022 01:12:12 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vNxP3LEs07NmCGRCKog1G1IpJpiFJh5GDDGw6HO/dAM=; b=hqE8F07Esk0Vh7lYlpQ6OKnD4ZS+mjeF7U9VWsONgBV4OlMUo2kqZONA3ZLXGs5POHOKyFJlgacmcnzbfB+5L/O7cjPuV+qVlKz1JGK9zravX3T2kra9JgNLzNkecq2Nr7IJlchChJ7x8TMPt+jKo4oVCm0ZDcP66c++IhlVaolHelLcYRw/jpKMujo3fs+WdqNx4NRt1y4PCdLbgEI3dg8BSz0STq1KROFWyEAFkSXhD37LiO19iOEaAyJXdHEv4T30hPHUo2/xKcn+t6quSKWQI2esjtJgH5W4XeVWlal4SL9oRdLbELYAHZnja+tBEcV99Gav9fWGcIk97h7Shw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vNxP3LEs07NmCGRCKog1G1IpJpiFJh5GDDGw6HO/dAM=; b=O4BgjhcWsGK5oKKYpsbdSDK45n8M2vUVgnhjIUymQeaFx2yNZn6jnf1riuM+wjOdYDEKLMGqmAEezG9BIFHUhexomtIftFYPy6s4upKAx84ogNzfGskz0s1OXixd3A7hHuCKMXHKTEXf7quX9tPl82cG1JC13J5mof+0bQdD4v6HCZXdqvOD/xoeRwGILaf0GELab9qbgKHCmAzKlQaJTFrXWcd8pwM8n0Q8BdhHXjCuRBhuqDBQD5pS5dX26w/bhDO+K00I7PPckN026GaKfghm6WCNDv6s/QhC/vEh0p+gR/RrIs7hy2lZhIkFT9+L+jGtN/ZvJgwb6YEq79Ct5Q==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Dk1BAApvvglQJ0oO3vW/NVw36ozmpNNFpjbF4SJonU274khCN+uojKlcvHGt7LW3KJvoRWatuEibQC4aNq8JjIMHBp/T3MT5GdXadeIQ/E4Wq0OCxbfdNiOTxZPZr7mkiMhNz+cFGYAxM5Em+WUa+zA/wB0RFhB8P/rNub1DtBo5WzKz/0XDmVVWMmm2RI6j6RVGT6BfU8LAxWgDRR3mlklxyoqLgvxrBWac8h5LW4O0ovxitLxeFhTGrMUzlVAFOHpw6C2Ps94j+ThLdWYAK9vMgpcSWhbJBnHO9EBob/eNCGiZNL++zFSMYRkkbnAVX/NxqFxiNwxOCwWtZuiLjg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RakXG8oEmmmveUDD5Eav12WRBFNlzPiGGbRwugUVItJGwsXibEbMP2EB5SPLp1HtSHUPhd3/EPRlAdMOTIxgcBXJX1SIgc3a/IBzGmcg6PJyUpqm9f0U1vpSBJ2smt8X6igSJk6aaJeIGWsCc1ObCuQrjb4k6j8rf7UF12QxFLzwoBFmSZqsFbRCD1RJvUDu/Ew8p3K2SSzTT1KFq3G35PxM4iQMR9N/YVYq2VVJksrNLw9Sy25pkSKrDQjyOzqxN1Gsx2T3e6JW7qdr5WE/KRQCzJAdgbX91dfM72uuFCEoP+8vwB+ESOqFivuCOMkJiw3frS2tgu2TeX+mUUplkw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Christopher Clark <christopher.w.clark@xxxxxxxxx>
- Delivery-date: Sat, 08 Oct 2022 01:12:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY2oOIAk0kP8Ly4EylVwyMRp/g6q4DWdEAgABVmDA=
- Thread-topic: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
Hi Andrew and Jason,
> -----Original Message-----
> From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
> Subject: Re: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
>
> On 07/10/2022 20:31, Jason Andryuk wrote:
> > I observed this ASSERT_UNREACHABLE in partner_rings_remove
> consistently
> > trip. It was in OpenXT with the viptables patch applied.
> >
> > dom10 shuts down.
> > dom7 is REJECTED sending to dom10.
> > dom7 shuts down and this ASSERT trips for dom10.
> >
> > The argo_send_info has a domid, but there is no refcount taken on
> > the domain. Therefore it's not appropriate to ASSERT that the domain
> > can be looked up via domid. Replace with a debug message.
> >
> > Signed-off-by: Jason Andryuk <jandryuk@xxxxxxxxx>
>
> We're into the 4.17 release process now. A bugfix like this obviously
> should be considered, but will need approval from the release manager.
> CC Henry.
Andrew: Thanks for the information!
Jason: Would you mind adding a "Fixes:" tag following the rule described
in [1]? Thanks very much! With this tag and proper review/ack from
maintainers:
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
[1] https://xenbits.xen.org/docs/unstable/process/sending-patches.html#fixes
Kind regards,
Henry
>
> ~Andrew
>
> > ---
> > xen/common/argo.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/xen/common/argo.c b/xen/common/argo.c
> > index 748b8714d6..973e1e9956 100644
> > --- a/xen/common/argo.c
> > +++ b/xen/common/argo.c
> > @@ -1298,7 +1298,8 @@ partner_rings_remove(struct domain *src_d)
> > ASSERT_UNREACHABLE();
> > }
> > else
> > - ASSERT_UNREACHABLE();
> > + argo_dprintk("%pd has entry for stale partner domid %d\n",
> > + src_d, send_info->id.domain_id);
> >
> > if ( dst_d )
> > rcu_unlock_domain(dst_d);
|
