[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 2/2][4.17] x86emul: pull permission check ahead for REP INS/OUTS
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Tue, 11 Oct 2022 10:52:21 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O/cdhmkn5SLFEzarDHl5c+nSjvJbxMYydiKVlDOEM4M=; b=b+xsW5evJmxlzkuQmrlWWjDHs3zu5Hd7kVE9UKEYaEJp4J4n6NNFqTm9Bdtvc5PWcEbcsa8dzJtBNPK+YpHBlIY+bYf3t3VYqdvR1CduV8tkqS9sJypes9LL1HmGFuc/CqDvIuijppXFdDJWesOjq4EceOWPLakjUCgB7NPoARh30wm+DREqD+btOxxrT1vdbQeduWJC/TxD3Gh1N6Cj5MaXxkdpwjjvJ38IxPPf72bGxeL6Wg6qwH8+a+uOa//xbnPmEiwgjwK4ozo3egHZHAZES3iuM4wpmIqkDZYtXfNYD/HWEJekRHAW1WGPZJVmDQ/lyGPpZHe1l271/hjuuQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O/cdhmkn5SLFEzarDHl5c+nSjvJbxMYydiKVlDOEM4M=; b=acGtO5TzWHcMGr09kehMKlWUBfTgmOv05xOsIRv7bwasDM72CfG0gxbzlHmxvl8ezWDNwEXm4BXC/8yfr/6BBj/rXEPvU4WOz9efDJWVVAK9bK3EpX6BJaRhC5iseCxKD6VdxtelF6KETIaxBu/V0fm7Nw+dujdM9fDHVBLvt2S10HOJ2kfl5tHQFjTyc1po2k2WXbKNojK47SLS7tJ2bX7RBDZHTbHK33GVs1gp9yd15IqUIiQJzXDgYQBxnUJtwQiE9VwSSd2EXnNcZEJRzfea1Bp48k45S3PMJv6Czh4Ihj2r5ZMIQ3mSEseSuC68wVEEsL1JsE5FeAN4nIRq6w==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=f3AUoKePr8HP4nTThWehX+lyRYgctNu7TzSfJP/Rlj7ncRlDuGX2wrXV9p7C+a59ZurWjohgjaaCPHkLolMc8jZER5T2Zlqu1tgyuFK4ntMnq4kytagIS043c4VS5SsOAKCqSn7dRb//uQ4I3dDd+4sBz1bP8QIouKHfLSiu11aBre51GPCJOQk/j5hHokJx9axzDbBIT4818YTKkHhdKDSSomTakJuC1F5OxPOuByjJ+bciIXMqKv76OeDdGpwHLWA0/xLazlJBHoAq9JPXi1U/4gOgrgxqvH1/ZNIcqspSBqWVUNFHh0gZlPLibBBMEjDZqOzqTvWpIBElo6tY6g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dHXqLbEsHiTA0F//2vY4b6XrkQBQEj893UXCuuzg+MuWf6LRAp9akVy11aSOFqc2On7J+V7qsmmaRKG3T2RoAPoEzwxU7MNCwLdhQXL+GuaRLNbenHatIWIiBUL5rkIUOzpZc72T25ZJkJBC8wyeOwdafTgneGMf0moMaPV2MZLA56zHyys2GpAyodFu1P3LKM+JE9e3b9+hfugCANRKzQioITo1YJh9Apct2ctMrikByesaNXwzitVFHQtYNI3xTdEzYaHzotuh82BTranHMX4nDPm8+HjNiJWL03S8yyilwjz3ng16x0m4LP9lwiM3Eg0ggaBYOnLaKPVwaLlHaQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Delivery-date: Tue, 11 Oct 2022 10:52:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY2YU/ul6th/D86kebfP+n1ma7Bq4H83eAgAEPrYCAAAbpgA==
- Thread-topic: [PATCH 2/2][4.17] x86emul: pull permission check ahead for REP INS/OUTS
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Subject: Re: [PATCH 2/2][4.17] x86emul: pull permission check ahead for REP
> INS/OUTS
>
> On 10.10.2022 20:08, Andrew Cooper wrote:
> > On 06/10/2022 14:11, Jan Beulich wrote:
> >> Based on observations on a fair range of hardware from both primary
> >> vendors even zero-iteration-count instances of these insns perform the
> >> port related permission checking first.
> >>
> >> Fixes: fe300600464c ("x86: Fix emulation of REP prefix")
> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> > Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, preferably
> with
> > some of ^ discussed in the commit message.
>
> Thanks, I'll apply this provisionally as I'll need to wait for an ack
> from Henry anyway.
Sorry I was actually waiting for the review/ack in the Patch#1 of this series
so that I can ack them together after they are properly reviewed...
> In the meantime you might clarify whether my
> responses above (which mean no further discussion in the description
> for there being nothing to refer to) don't find your agreement.
...Since IIUC this patch is also trying to harden the code, so as long as you
and Andrew reach the agreement of this patch, you can have my:
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
