[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [4.17?] Re: [PATCH] x86emul: respect NSCB
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Tue, 11 Oct 2022 10:44:23 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gDDhC9dVVuqXaO8kimaQS5XB0AfnLhjX+Pw6ixg6hgw=; b=KR9xEls2ldEH7T9vklDE8E6ditbdoEuRnXU19bDnGakYaXiOoiBTTqUAO8P6XKWzxuVw6OuPwY8dq5905LA84Fcw0M5I3Se7y29YSr5MJilVopb+BfrjOZXAUkCAd/8q3lrZpNmdL/uQlpccNRGsI4ZvJOKFS0RtaxM27BLm6JsLtcjJpqzHbEXqPbawFyKS/vYjjkzjrMcSmUKKzL/pQa3eomPVYXlWhp/1PmkijzyQ+otWbm08ehzWO9PZ2mtONYJw6N1W2TIn0NHAJxFE8hluNeYtbf+hvlI1zZB0mlinndhCim3BtyDx2BYP9y0ujpQcMkXvqlgdRRfXDx/JfA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gDDhC9dVVuqXaO8kimaQS5XB0AfnLhjX+Pw6ixg6hgw=; b=kWRED51UOO53TEHDviG4PtiRC6f8GeZaUwYWuuDTsfOMscofwRQtuiM4Xy3LGngTh61PAxShSFoBiNubbPYQt7DEkYjhc765iKSLBQU/HIrHBojNr18Pk5Vu/OWhquhr9GlR1LPTbEpQTM99QrB5gZvBc6Ouaf0khTZKsebHfn6W/uD3GhGLGBboazLjMVbvbEa4857do6m80SH82pkJ2PjqWJ13nB0KgYmveqG6INQQeHpo5c89o3WtOLyROmuLg1R2a46vmd9K/adkh86modHmr8T9voAiLRSea7g14m/fn72piAd3aV/WE+5KzEPYUErR/lDwbDPDfhYIpmvE4Q==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=mppKK4Xo0596eqIlNVIEWDWHakZd3IK3wDPxjKLvOdXzbzM78SwpIlkJvYxFvPsn82t1DQL25jmQE5+xgnVQbsyTsPY9WaJR++KnquMnRGxGEAyTPgyd03FnrWBb/l/FQyyYhfdXXBMyYSj39hMNuN88y9Y8lzGk9zbDUYCbTzum5JJtcd7yHteskMWgzodagUiXrs9Vs9+0tjgVcBs5o0Tn+/2OA6BHJrgJrEqsdPQoT/HT2GuCVefACModeAu8+IjhJR2J49REx+eyJHJv+ym2mAdl+9XQAt2izxLSXAoFNfM3553NOi6owgYwZoyJcKChP6/JsN7/gn9GRy8kNg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V2pQBBtMxeRyR8+7ThO6dbUxg5KMfsSjLm0FR4VdHAS3C1KRbGw9w67lZ3WUljhFNITW8Mz1jimkkB0Wv1VEktD5QxYuSu2cmOPTqYi/wdzY5laoQlFjxPKbAv38Y6Nt0Iif62TCHSZNKzzGOqMFkdBNUsDT8Rc0I4IfkYimgnuMHH0fuNBNLh7mu75X9xaEY1RTQOyKWHtAFjulEmE+XpK4uA72ECLfzwJ/I6rU44h0SRcOhwYtkTds7waU23jHqNWYueJZ6jPgopJMsistHJFuGgZrGDAML0TInMJ82UyBlBh9HbNHbwu7fAfAaYcEDrE5Nu3biaXOvewQRwaN0g==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Delivery-date: Tue, 11 Oct 2022 10:44:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYyNQExUU6HB2zzUWbaDsrkt18Oq4H/XmAgAEhrYCAAAmScA==
- Thread-topic: [4.17?] Re: [PATCH] x86emul: respect NSCB
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Subject: [4.17?] Re: [PATCH] x86emul: respect NSCB
>
> On 10.10.2022 18:44, Andrew Cooper wrote:
> > On 15/09/2022 08:22, Jan Beulich wrote:
> >> protmode_load_seg() would better adhere to that "feature" of clearing
> >> base (and limit) during NULL selector loads.
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >
> > Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
> Thanks.
>
> Henry - this was submitted before the code freeze, so you weren't Cc-ed.
> May I ask to consider giving this a release ack?
Since this patch is simple and to my best knowledge this patch is trying to
improve the code so:
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
(If it will not cause too much time of digging, would you mind adding a
"Fixes:" tag pointing to the original commit that missing this
` vcpu_has_nscb()` check when you do the committing? I think this would
help to identify this patch as a bugfix so it is more reasonable to commit
this patch in current phase. But if too much trouble or you think this is
not really a fix then just ignore my comment...)
Kind regards,
Henry
>
> Thanks, Jan
|
