[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [4.17?] Re: [PATCH] x86emul: respect NSCB
- To: Henry Wang <Henry.Wang@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Tue, 11 Oct 2022 11:13:06 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DxKKZvA+xwRFz4ieq7pKElvtN+v56YSUwmmWRv544k4=; b=lfapv03Fxh53RQSIvnTZBgLC/pO4cLZaOoSuKVVrRsdth4w/e/JUF0QryLQ6m5PBmIvQiTH7mFF39J/zxz2jpsywt9hW/UNuG3RlUJBm44l1aiNPC+QUTWFctS5uyIvnT/cwunrt/Mj39iJL10icAJc5hh07dFygomyEJy1UMBGONsIF1V9kxhv6OC9ODOB5Xe59HV85Omq0LreVtR98Ct9y/ze1xcN7Zo99fbu+Q6PhxA3M67+Ha5tWoR7WPUzAZh1V3rrHBid6djtbudWS9aJHmH2NcdVStYcNMWhv4uRYbRFbqA26EW7+ImI7ZGBJah/YYM0C+fRWn+KJ2cOw8g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iUoyRt0xHHjnK0GngtGbQYd9B8zMHXHlzgypZJwIQqJqfTTIC53jmQ9ZcFuVvMnlex0+3pARgvZNAeeKeUfEi8UWU8sqMuyjVzThRiQWQtO5c3ZzK83V8JhQNogMFCEo0P6PQQTMopqGxeH39jKeO2C1A3YWv+fzw1PMfxiAx+e+eXK//RpSQ/uf+l2N4ReeLNNUzmgFT5yK2y4WRhtq+i8E2xItPyXhnK/P9KEufYKyIobAGyz0/uyVGLbjvHCX6ojvmZuQ42fyvO9jbnlfXJ/Vy8vVoDeHzZuhOCDtiwqhjph670WlkofWdQbflcHyMiFLUGiVidIMuujB66v8bQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 11 Oct 2022 11:13:41 +0000
- Ironport-data: A9a23:KgMzEqCCegpyzhVW/xviw5YqxClBgxIJ4kV8jS/XYbTApDkq3jxVy jEYDGjXa62NajSmc91wa46/oE1SucDWydUxQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8pWo4ow/jb8kk25K2r4GlwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2k0ZoM3qrhGGlhq7 NAYDTUtZA+Bl8WplefTpulE3qzPLeHNFaZH5jRK62GcCvwrB5feX6/N+NlUmi8qgdxDFurfY MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWIE7g7EzUY0yzG7IAhZ+b7hKtfKPPeNQt1YhB2wr WPa5WXpRBodMbRzzBLVqCLz1rGTwksXXqoTTeOAqtNBmWap/UMsVDlOWgSC4r6m3xvWt9V3b hZ8FjAVhYg/8la6COb0WRKQqWSB+BUbXrJ4Eec39QWMwar8+BuCCy4PSTspQMMinN87Q3otz FDht8PkA3ljvaOYTVqZ96yItnWiNC4NN2gAaCQYCwwf7LHeTJobixvOSpNpFv6zh9itRTXom WjW/W45mqkZitMN2+Oj51fbjjmwp5/PCAko+gHQWWHj5QR8DGK4W7GVBZHgxa4oBO6kopOp5 SBsdxS2hAzWMaywqQ==
- Ironport-hdrordr: A9a23:frPXRanXgxBUbuKKqnPkeetF4qbpDfOPimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPYf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcRcsvy5zXMISdOUmRMXee r30lMd1gNImjTsl1SO0FnQMs/boXATAjHZuAalaDDY0LHErXoBerZ8bMRiA1XkAgMbza9BOO gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4ZkWUzxjIjLH47JlON1Kk3VO 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEz82IIgMgE2nsQ/pM0TJdJo+ zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBOB1vd75rspLkl7uCjf5IFiJM0hZ TaSVtd8XU/fkr/YPf+qKGjMiq9NVlVcQ6duf22vaIJy4EUbICbQRGrWRQpj9aqpekZD4nSR+ uzUagmccPeEQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYyNP7HPEYuhoQC0yvtYIRC5F8064H/XmAgAEhrYCAAAwLgIAACAWA
- Thread-topic: [4.17?] Re: [PATCH] x86emul: respect NSCB
On 11/10/2022 11:44, Henry Wang wrote:
> Hi Jan,
>
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Subject: [4.17?] Re: [PATCH] x86emul: respect NSCB
>>
>> On 10.10.2022 18:44, Andrew Cooper wrote:
>>> On 15/09/2022 08:22, Jan Beulich wrote:
>>>> protmode_load_seg() would better adhere to that "feature" of clearing
>>>> base (and limit) during NULL selector loads.
>>>>
>>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> Thanks.
>>
>> Henry - this was submitted before the code freeze, so you weren't Cc-ed.
>> May I ask to consider giving this a release ack?
> Since this patch is simple and to my best knowledge this patch is trying to
> improve the code so:
>
> Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
>
> (If it will not cause too much time of digging, would you mind adding a
> "Fixes:" tag pointing to the original commit that missing this
> ` vcpu_has_nscb()` check when you do the committing? I think this would
> help to identify this patch as a bugfix so it is more reasonable to commit
> this patch in current phase. But if too much trouble or you think this is
> not really a fix then just ignore my comment...)
There isn't really an appropriate Fixes tag.
This CPUID bit is one I managed to get AMD to retroactively add to fix
an enumeration problem they had no anticipated when making a change in Zen2.
i.e. the CPUID bit did not exist at the point at which the code,
modified in this patch, was written.
~Andrew
|
