[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [4.17?] Re: [PATCH] x86emul: respect NSCB


  • To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
  • From: Henry Wang <Henry.Wang@xxxxxxx>
  • Date: Tue, 11 Oct 2022 12:32:06 +0000
  • Accept-language: zh-CN, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kZo+0/jmC8tf0qBn/Jl7wbtEWwCnGQKx+gcTW/4eJTk=; b=C3RXerq7mXlaaBtEr321uW8QyS1qLVC7W0BRSwyPiuAxQ3itazmbGWJAzp0J1JnQjNApDoIZlmTZoIR7SfGKQEFqPw2efNr3lYcNS/hljZwfzpE82HrZ38YSP1EfI4w42RLQNfjkbSefr2474SB8xNbjIdsgelD6D8Ks5651SlZWF40LjKLeMUO0Uu6zI1OZ+G1FUz9UtivL/GDBtvqKsCk6PkPcFYeQN8phMhaf30LSyXT689CF8cxqqsAO4G7dnTWaf5iCSCCQ0XqgxOQ0/bVJGWvxyR7/RqHAnEx6+SL18eyZj5ygaD5dTXSk7rZEjRtS0kIL0+4VRn0KBHOmxQ==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kZo+0/jmC8tf0qBn/Jl7wbtEWwCnGQKx+gcTW/4eJTk=; b=C1+ahuKroxbAtn1TzuCwHP2Qqmwh8pkEUX+5xu2W9VVqjWdMBqVhriQK3HImwyJoCSK+ukPhS3WS04uCDR45XsHLNxpUIOI1BD2Dms14zmLBb3mqhPYZRzDZ5vy+DXULxhKhn8wSe/uTwRexjTekL5M60VNNQJJ2/lD+AskJWTCR6FBmJfjEbldYHDxrgGljbv6Tw+WIMyKw1b7oaJIvo+5BPs2qPU23vu2UJKnQ/bkK/8AedJiwRPyrQUQriy6SLiOAJ+BQayKm135GK+9V7ircCWdndl2tUPofSUE4dMzM1tALmYnJPmaVqIlQ3jEs/d7WSpCVkuBT3DWTLt9UHw==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=bovRSMQALX2r+Ts2sHAQqPNxF5ulfu7oWHofW+PFFRi/GLQFqBCs7tF96Kx6zRgbOSu5F/47Emr6HgOFPJPqGWG/RUR5N438HQzM6dqaB5NfZ0UW4QsVffmcOU2MLy2GzrWxaUqV1QSaVUITcM+/GXb55D5cLHtS5+N4uzLprq2+TzR/KEzi2Dozf48XqR80NzKSf/AFhVMV2Lqc0q8YDOMGicfFfxaqrOI+pnDbgOeC2Dx60tqxlotoAKS92mG/t+PfDazIgC7AJDl+Cabujh8K8LGiZVAytskNlJD3RrOiGjYLrlc0Hil0jaXmGlmaQLRSX0yBAg8s7LFlsI3tBg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N+/7Yx2Cyw2dDnsfx+TMMhaKIs+8XIP0D+9FAhfVFFXuB3Uku+ro+U/S4HvM0q79sYsP8ngMd1btPbEG4fqK6PqN0wKhz3ORq/itXbhUmIXNL6nTJ7dGOYvPNwaBjTBxEfc295keti7f7sSkX1b8I7j0dqkor5/uP1PWzdQw8ioHeD1bmNf41v1Huejkoc0ZQvIPp3Fp9TAvfFYel/qXSxuvv8y71k2tagzmhLT3ey5p/Qwtk4zOOWpvqBNn2oH1Sdt0rh0oy7FabFdDVJ/t9M77E7ne85OMW4ntiHpjC9ZUZC2S3tqu8ZhGv51oEqiZ1qrMmWPf8yOzLALDuE1rHw==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 11 Oct 2022 12:32:40 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYyNQExUU6HB2zzUWbaDsrkt18Oq4H/XmAgAEhrYCAAAmScIAACn8AgAAV25A=
  • Thread-topic: [4.17?] Re: [PATCH] x86emul: respect NSCB

Hi Andrew,

> -----Original Message-----
> From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
> > (If it will not cause too much time of digging, would you mind adding a
> > "Fixes:" tag pointing to the original commit that missing this
> > ` vcpu_has_nscb()` check when you do the committing? I think this would
> > help to identify this patch as a bugfix so it is more reasonable to commit
> > this patch in current phase. But if too much trouble or you think this is
> > not really a fix then just ignore my comment...)
> 
> There isn't really an appropriate Fixes tag.
> 
> This CPUID bit is one I managed to get AMD to retroactively add to fix
> an enumeration problem they had no anticipated when making a change in
> Zen2.
> 
> i.e. the CPUID bit did not exist at the point at which the code,
> modified in this patch, was written.

Oh, thanks for the clarification! Then please just ignore my comments, sorry
for the noise.

Kind regards,
Henry

> 
> ~Andrew

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.