[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2][4.15] libxl/Arm: correct xc_shadow_control() invocation to fix build


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 12 Oct 2022 15:14:05 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/CHBNsqkoxu3QRtQarXnQNywHDbKb5AzSnkC0FMUZLk=; b=Y7bbhF+LDdIrNxx6wFiH7CazQbUf2Rhwbx2tG/yhDLpsUI1Eisnmd2jIwU05cZMiNl1+bnjzFs+V7+zMGGkAvr3TwgBscr7imfn5LGu5GnDzqiyCG7qD+l1tIl135f5GG/5977yrFlfhGCt9ggpnbUi9azWjwMebiuD9jUz8ZezZSqj070NbCeB2f4nOCvx1BVtg7lcj5qltQD9abJ9nsvYEFLCxL1PMqNufwlgNV48neXqD8s4nOdUZfRUzsnIcjBgFXssDyKgNdohUe4T4DL9eKw8Em8r420gep7YTmNrEKP1v/N+/YAw+s3N3O4ucDNNlg+lYR/xcoimG+L0rTg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ElJIi5bTV3sLomo6HwEE7wGiIXlMKCaBpBjcudOLzi+DejfsdMF3IKza7nrWiNNvy5RKS3h4dS5Z/IXGxb6tnMluIcLcDp5frwbmBY/2gzAy3m/s6yJI6sry11QAtOVcrXy/3M4gDdgI/4jEb1EMV95ayCB5cV8ZD+jzBKZkvx2Z0c453S26L/gZNY8GCXq8N7DeLZjw2JMfwoiKrB5iMUDuSKn4Zy39S/SkQ73EtOWRihkD1oj+nuKlPgUCn906nk6MElntk48GoMHafCnnVc8XS0T/2PSTGXzX2tnDcdoU7jW/WL/dKeYSbpPF8vnz/na2+O6IhONqSDm/jTNI7w==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Julien Grall <julien@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Wed, 12 Oct 2022 13:14:12 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

The backport didn't adapt to the earlier function prototype taking more
(unused here) arguments.

Fixes: c5215044578e ("xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
Also applicable to 4.14 and 4.13.
---
v2: Correct oversights.

--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -132,7 +132,7 @@ int libxl__arch_domain_create(libxl__gc *gc,
                               uint32_t domid)
 {
     libxl_ctx *ctx = libxl__gc_owner(gc);
-    unsigned int shadow_mb = DIV_ROUNDUP(d_config->b_info.shadow_memkb, 1024);
+    unsigned long shadow_mb = DIV_ROUNDUP(d_config->b_info.shadow_memkb, 1024);
 
     int r = xc_shadow_control(ctx->xch, domid,
                               XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION,
-                              &shadow_mb, 0);
+                              NULL, 0, &shadow_mb, 0, NULL);
     if (r) {
         LOGED(ERROR, domid,
-              "Failed to set %u MiB shadow allocation", shadow_mb);
+              "Failed to set %lu MiB shadow allocation", shadow_mb);
         return ERROR_FAIL;
     }
 



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.