[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH][4.15] libxl/Arm: correct xc_shadow_control() invocation to fix build
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Wed, 12 Oct 2022 13:16:01 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=coVUI+OovziYU9f2aKGAN07Z7YqMva50yfqK3aKrFMo=; b=YvGfmOWQrn+7vfExHUqAoEsUHjC09DZBOt8uJuBe7HL51n+Nz0h2rDorRYSTrkLfqvoj3kVzac6+6kY/yNwMHbnb0geFYvDZlPx3TnTWqMNk54SXKJatA/3TdlPFUZXt788prstmb7W0kYmLVNfn+Wti8KsM2ORHa3jQOD0vjp0gUpohbWrKE+A0vE4lcM7usawkbo8FgQFwNqQ/h1v3NDL8jnkfl5TnnEb9xOBTykTtw+xhlL+M7QYnG3yrwrpEyXakocXHM2zHVbks7hYtHE65fyq4hxqv/ulBFHxi+WIBdsGprsIutBg7SiYfBnF3MloMdxjBCFexx8j/rCT0tw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=coVUI+OovziYU9f2aKGAN07Z7YqMva50yfqK3aKrFMo=; b=fF00BIqf2xLsGVhGRSsQgET/cOybmvhkKe/nfJwwniugdSNL1+ywaWB/zgETaE7dJIEWqSlEl8l6cloA0ONgd03cc5bGuxL5Uuz9jlOKN7ac0RqDN4NzdMX2DBwuFOuZ6gDe/ZnVcrnMfB5GIpp2SHyXjz8ryAtL9sQJC8bQxDxbSKAI7GA9KMgRMR/6YCTM08ZmAi/O9bI1V9DKenbMkpLM5GER/IZ0r6UR0LWxwbzSH7U9wwlUDH88L4dTb8suqkHTIRRw7DGx7eFXszlp18dAAgxDldqiVftS0EV2xEJSYV/dNH1wLYllmI0FisZuvWSOU9tqelcAMr162Ttd9w==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=C6KCvZldk1Eo0kJF6+XzZ2LBXGq1XwYWJaP9Vy0+5UdB/QuTPBRr7G+hRrsTlWh3cvy/UfI57JNr8LqLnucf5nlEnvGIujkIlqAfT9WcAp65OlFKfH3SuBgxog6j/wqfCufMUwBLqIG1WK9N6MYSuHtldxbtIOPXUQse31KwUR+vpJJpbnPxQL2jj8e23fVkc6o4IFnkn03O+OORfcYtXFcaAQh2+Tpunr4E85axorRn7na7qY6Yh7cLtsVpcip17TaL6dnujkSYgkh8+lvDzsfLCyTLEF7j4AoD3MR7B6AiwGTt2jSUzQS6+Ktuom0C/uDwM1zAV/5O12rjKH6oVw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f4OrZBi5/KWk+/qjROv8/3hxyOPUJNLKuSPXYaj55F7WTE0K238rseIW5lJTAz2LmdSqHvTGfh26AL54uk8dZVfg/J353QI9AvXmuZyFjExnxWhvLBqeF/ZsnRKeIoMaHKcO1ElyCRjtvheswTaAmeR2jcyM8mEriVWC3FCj2tk/pGamAzPzlbmBkDA8trVjduOK9li7XDRx4xid2/VA7pQvxn+oAj285FrgfglgxuE/X7buazqcelBaKosnBwRiHWw0QrXL3IgpkQM9WsYyKYqd4CEZ+GGAs6LzXmfnxLrgCoCqRKWtapTzTFK4qGI+6zzg8iwf0zT0+WShY/uP+A==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Julien Grall <julien@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 12 Oct 2022 13:16:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY3jtPuivbdxpwvESMJg2+jrcZsa4KukrggAAB8wCAAAA4YA==
- Thread-topic: [PATCH][4.15] libxl/Arm: correct xc_shadow_control() invocation to fix build
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Subject: Re: [PATCH][4.15] libxl/Arm: correct xc_shadow_control() invocation
> to fix build
>
> On 12.10.2022 15:07, Henry Wang wrote:
> > I thought to send my patch for fixing this issue tomorrow, but since you are
> > sending...
>
> Well, I was hoping to get something in before the day closes.
Nono I was not complaining, sorry for misunderstanding. Actually thanks for your
effort here.
>
> >> --- a/tools/libs/light/libxl_arm.c
> >> +++ b/tools/libs/light/libxl_arm.c
> >> @@ -136,7 +136,7 @@ int libxl__arch_domain_create(libxl__gc *gc,
> >>
> >
> > The definition of shadow_mb should also be changed to unsigned long,
> > and...
> >
> >> int r = xc_shadow_control(ctx->xch, domid,
> >> XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION,
> >> - &shadow_mb, 0);
> >> + NULL, 0, &shadow_mb, 0, NULL);
> >> if (r) {
> >> LOGED(ERROR, domid,
> >> "Failed to set %u MiB shadow allocation", shadow_mb);
> >
> > ...here should be %lu.
>
> Oh, indeed. Why did I not pay attention when looking at the reverse x86
> change in 4.16? Thanks for pointing out.
Well I made the exact same mistake here before I did my local testing so I
think this is quite easy to ignore :)))
Kind regards,
Henry
>
> Jan
|
