[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()
- To: Julien Grall <julien@xxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Thu, 13 Oct 2022 12:49:06 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xf+r8Bc3QMJLG5H3ag52ZoXOW4MPEbB9Nsco29WT7sc=; b=EFs80SA3mT985AMMg1vZZNVYfNS+a0obURiLf67AUskltTrncSdsU/PuZbKKiz3wqIjf4VSsoSmos3d53qNogTBfmyYkl06HPtlK0L0NEHtF+wSaCeZj0oFAyzqO2+5g3MjeO9Ch61LjEDJ04mTGrDku0FI0v9Hv7kdIyCCchw0fO7cqal8IN3dVnyg8gyHcsPhmV2mag3UmsfYc3SVtWx5f6tmzQo2B7FEyhPRY6CGeGJ2BcS7M4MxrVCaFb100U5Nxn8q513ClP9Q0wTRrH3GN0xKX8PUc/BvAq3M+Z/M8147ZjAy1LuGVOUY4+F1ieCGk88z1qQ6IzzDCcH2xUg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xf+r8Bc3QMJLG5H3ag52ZoXOW4MPEbB9Nsco29WT7sc=; b=QQVgJky01nEGDlM3jK11V/GpkxkTXpYy867QGOEnISMoZS29wQfjT3DBqOUj9yw/439KC/ytCvypTU8xeRXNxOkE2zQCpREyW9nTdFA95gkJPBvCfsr1BDI1f1FkIjS4SZqAmsurH+51W9+7TikvTOsd8DJuN9yrjfcwEUE61A+ZDLUbgxhVMcZg7xidW0ficeqLE9lmwzTSkr4ivJMX/1LvLV0z4Us4QNk2WSFmznqJDObu4Wk9intBtW6l8Le3kp7dytIN7OwsQmCvNsE1Id1HccFdOK2UJoq0q7yWmDWGsfchvrRg4r3TzP2kWaukxcrg/pcqY2k0KTmXuUbzLw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lYETr7cDWIs6bPL/Yst3SiBX3q3Fy8GwC+5WNLJ4KYmRd3yRicXVPUyVvROVpJlRnr2MhaltidshZeHeh/PIwYZaw3PeyyLrPl7KmkvMppO9t/J9dbGbK/8/15SPDWaAU4quXq2szfF026id71ZFcgyC9S+E0lhqJW/tSajOAY14JoQmPvi4C67wC1yRyWc1SvfeMPA1MprE0kcPPVG6QxFCGzKWa6OaEIX6Ens+wFaLzjBG14afIY3yCe4K6hLAlAnJV3H3vjd3wFeYPICJ8Y6nQ50wJtU8ZQ9I8sJNXCCpakh0E1gQs2rxPoMoeUG9FKs1RR9oy1mVIzQ2ZucPXA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mHREdVwTHmB/QReUObEjOdarOCM0XfYFE1LnZ3cZDhHWAUyo8fOmNxafRfS4tyUHAOK/SGfecXgf5PpOyd+vMV3Wt8sG+RNKMY7EwjKvX3ZD4C8eclk4pd4OPh2HQiDJjeUKLPeM2xUPjdbfTWpGTYvFF+zcBA2jvXiWx3+lmabDJXNRtKKT+Eknd+p5qaUocE9bULkkq53AQOMHbASYJZ3PtkpIwoGBbt4txwU1iHH83BfijUhxdqHiIxXbCZXRjDEsaPIlIwUiELsxPqiK3T0gIQLMxubRAtkF5sOgAQKc1PjGAQeNXw0NLoH53KXKA80EkKRmkH90YfjTqfpVwQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 13 Oct 2022 12:49:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY3t81xdeRddBbSEGLoF20gErPe64MD6gAgAAAmHCAADWrgIAAAFWw
- Thread-topic: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()
Hi Julien,
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
> arch_domain_create()
> > I think in Arm's arch_domain_create(), all the error handling are the
> > same style using:
> >
> > if ( (rc = <function>) !=0 )
> > goto fail;
> >
> > and we need to keep them the same?
>
> We don't have too. I agree with Andrew's point. How about the following:
>
> spin_lock()
> rc = ...
> spin_unlock()
>
> if ( rc )
> goto fail;
Yep this is my current method of local v2. Thanks for the clarification.
Working on the p2m_teardown part now...
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
