[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[for-4.17] automation: Build Xen according to the type of the job


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Fri, 21 Oct 2022 15:22:38 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=42HDqeoTp2iFQDneQaRiYdhWYX5iZ0QaGLIVWemtNg4=; b=nSInzib65va4t/vWxrTOvR1iuY6YBESJr+rpjNDonsyktP/Ez8inFKDfBtmS0NWMBATxJzi485cS7SVf2luA01F7k1taln0yVPJscFypeAJl4rmDP4kF7dlsf9entpnTKPrYZ+INpEI9/rN3foDFuZLgvYjlGySVJgf7WwdfD+Obsg5PrIs+MQpRiSiF71uK/AJfvZlZQrWukQvnjHu1EoVe/e+r7B0nry7ka/VlSKe80GxZHOmhWPsOvEh67Ok0/0uEOHjg82BTpVEr3uEMV0Btc3zykVanWpoDeTPdn1B8xtNCSGcF2/p6FcAVDImL9UfAMu5ouAG1mrzIDy+Ihg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JCWgwozbxZ61cm9wexhEIwNLK8exdWF/0CdKzbEFbLYX5yhYjBjNm2NnggzbZiLK7WkqOOZsUmwQ+S2Ge4qeknxsDWGVvHDR4cKFKy03W9BemixnMiVnFACj2SvRkvmu/zCNp3OKF+9F0S4O8T+QpX6yXsalWj1zvTOmoeP4LUYzrcH9U7bNx2ZqAtnTz79AWM8ZIlOnx97H2eDjgy9tSS7O0y9MpUzM3k6O/epYZWDvSw5wHZqGKwWRaqQVyVsonp6yf4zKrGn7FvJgTL4SQKv7dtPpZ9vlEU/xQw5A9KDVCtSoioxs0J+52avmLDSpzJoPf3jgn+YDtQYXF+bNeg==
  • Cc: Michal Orzel <michal.orzel@xxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
  • Delivery-date: Fri, 21 Oct 2022 13:23:22 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

All the build jobs exist in two flavors: debug and non-debug, where the
former sets 'debug' variable to 'y' and the latter to 'n'. This variable
is only being recognized by the toolstack, because Xen requires
enabling/disabling debug build via e.g. menuconfig/config file.
As a corollary, we end up building/testing Xen with CONFIG_DEBUG always
set to a default value ('y' for unstable and 'n' for stable branches),
regardless of the type of the build job.

Fix this behavior by setting CONFIG_DEBUG according to the 'debug' value.

Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
---
Xen used debug variable to control the build type before switching to Kconfig.
Support for GitLab CI was added later, which means that this issue was always
present. This is a low risk for 4.17 with a benefit of being able to test Xen
in both debug and non-debug versions.
---
 automation/scripts/build | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/automation/scripts/build b/automation/scripts/build
index 8c0882f3aa33..a5934190634b 100755
--- a/automation/scripts/build
+++ b/automation/scripts/build
@@ -21,12 +21,13 @@ if [[ "${RANDCONFIG}" == "y" ]]; then
     make -j$(nproc) -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config 
randconfig
     hypervisor_only="y"
 else
+    echo "CONFIG_DEBUG=${debug}" > xen/.config
+
     if [[ -n "${EXTRA_XEN_CONFIG}" ]]; then
-        echo "${EXTRA_XEN_CONFIG}" > xen/.config
-        make -j$(nproc) -C xen olddefconfig
-    else
-        make -j$(nproc) -C xen defconfig
+        echo "${EXTRA_XEN_CONFIG}" >> xen/.config
     fi
+
+    make -j$(nproc) -C xen olddefconfig
 fi
 
 # Save the config file before building because build failure causes the script
-- 
2.25.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.