[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [for-4.17] automation: Build Xen according to the type of the job
- To: Michal Orzel <michal.orzel@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Fri, 21 Oct 2022 13:31:59 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U7ecJ63b83PMhoYMKYCzCTrAj1icQz4tQWStVl75Eks=; b=DY/3LP90DtBZDkRCad+iSmLVqfhqkAj0w6rSb6sd3uAW22JPcSNEa49isbDVzn/Xah4YblrX44beZnhiYSYx2ae5gcgrXOKY6xLmwIYM8gYVszvpNjinMGctmW+X/SoVANpW/iYULcEbfbif76QgnHHO/YrWhGZsJArSqRzQIyvQiyQZa6FKY2i86IwSfLQ3LiiCxNs+a4XiZBdPxjUMiF3Srl2kNzOTe6k+CVNSxZYyCcuuY6mi6g5/40rQoZ5LqbZS12RsuhVNT+3lp1alFEalZg5roOoDJhB9gs0ZvonUHwoxwwGwyP+Pj0NZjJ5WJe6n/Km0Td23vByDTyFjjA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MSSH40t++3t9mmbq3DVSbgUJWrZpnx3rfFhQrwwh21l4knZs2HfOcYmcZMfqZHfG75RDAREUUm53RSKUbxrlAZV+zLYHw+F99HzOJZ0/gR8/sw7mJtM/5vM9slA0q4x08b5Y/x6SPXp/yAVLK/Rdd+XlShYew4nN5m4pi+RTd5F/Z+orMk/qxfua0R2ObS6SMZCf5KACXALqWc30xTT6gwdA28kRseWxJu4yzqOUtKkgh+86QmkqiunyU3uzJ4vZ9lgrY/Grp241R8wHAmA/gGmqdWw/9De80Bw1y+obFElhBsn+LQiZJJSn5YkBe2XR+wh8erkY6ar/l0R4J5PXfg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Fri, 21 Oct 2022 13:32:22 +0000
- Ironport-data: A9a23:e1U/86CxOQy1CBVW//Xiw5YqxClBgxIJ4kV8jS/XYbTApG8h1TIHz mFNX2rUPqzeZGChft93O4608kMDvpLQztdlQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8pWo4ow/jb8kk25K6r4GpwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2l1BI44uc10AFpxr 90VczMgVj+krtq5lefTpulE3qzPLeHNFaZG4jRM6G+cCvwrB5feX6/N+NlUmi8qgdxDFurfY MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWAI7gvN+8Lb4ECKpOB1+JHrPMDYZZqhQsJNk1zDj mnH4374ElcRM9n3JT+toi/z2bSQwnuTtIQ6O7uCr/xz3hqvxTYcCCNVWmDnjtazhRvrMz5YA wlOksY0loA39UerR927WAeqrXqstxsQHdFXFoUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3 UPPmMnmbRRkuaeZTn+1/b6OoTS/fyMSKAcqfjQYRAEI593ipoAbjR/VSNtnVqmvgbXdOTz22 SHMkyE4iJ0al8tN3KK+lW0rmBqpr5nNCwIwuAPeWzv96hsjPdb7IYu19VLc8PBMap6DSUWMt 2QFnM7Y6/0SCZaKl2qGR+Bl8KyV2stp+Qb02TZHd6TNPRz2k5J/Vei8OA1DGXo=
- Ironport-hdrordr: A9a23:2e/AiaN1PIFZm8BcT2L155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+ Ukli1QffibLUmhOF1d7yGdgjUImwxelkMKgWXo/UcL5/aJCg7SQvAx+76wOHHimjUdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KcuZlFkIPwjgYVq3Poi1VIQFI1FEDPx6YghHu UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwM/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+ jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFrxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI SpaiItiYfzQTOaNSSj5uw5zvmWehTNYd3E8LAv27Fp/rvhWbHsLSqPDFgzjsrImYRsPvHm
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY5VBUk9XVwulUUUausYFLiYVWqa4Y2FsA
- Thread-topic: [for-4.17] automation: Build Xen according to the type of the job
On 21/10/2022 14:22, Michal Orzel wrote:
> All the build jobs exist in two flavors: debug and non-debug, where the
> former sets 'debug' variable to 'y' and the latter to 'n'. This variable
> is only being recognized by the toolstack, because Xen requires
> enabling/disabling debug build via e.g. menuconfig/config file.
> As a corollary, we end up building/testing Xen with CONFIG_DEBUG always
> set to a default value ('y' for unstable and 'n' for stable branches),
> regardless of the type of the build job.
>
> Fix this behavior by setting CONFIG_DEBUG according to the 'debug' value.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
> Xen used debug variable to control the build type before switching to Kconfig.
> Support for GitLab CI was added later, which means that this issue was always
> present. This is a low risk for 4.17 with a benefit of being able to test Xen
> in both debug and non-debug versions.
Both series were floating around for ages before being accepted. It's
quite possible that one bitrotted around the other.
This should be backported, and therefore should be considered for 4.17
at this point.
Is there a Gitlab CI run which includes this patch?
~Andrew
|
