[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
- To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Oleksandr <olekstysh@xxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Sat, 22 Oct 2022 00:50:21 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dTOHKlBuV9kI5cFgDUwzJGcibkdLXMyp3fOv54mXaDc=; b=jGXRFpuM4awAKSzvSotOvgDirKEPVFl5qJgCC/FzkOXfBfP2YRApayP/11gLXXZxZ/2x3k7OD0f7nqlMGLXoaHJkATaCagHpws5K5mTQpWV3DLE8zx96BWkQ3BshABgJHqL+FJRMhfEZWA9CLFrMiuwIqY7Q4orbL7ewA1+cvfqYfUqPMagTtxrH7RuMEP06hfYRrTlZHXy37G4+rW0BrpdEHHiCtf2bQ7folp5FrVKqlBDPtRqA3XrRxZnUXhGnOagZzVgN9h3A6ypd7W5khss1yXBuP8krYOKxQ1exO6mzLyycYxVb5pDp3JHR+6wOWgGgehBtB5yl/W7zXcXn4A==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dTOHKlBuV9kI5cFgDUwzJGcibkdLXMyp3fOv54mXaDc=; b=mKnmk/mnKISjyBy/qZevjFe5fV8lbEWqnWypQ4MlQHmbhzAeoGRNR/7SkU7M0oejQi6Gvp3jDihfXn4ZYWugDFNhF2Sh4DihIzyjM+3U98tnbTQGGFkvFz2unrfNfRf/xx8VaYAXC14TU7zCdSGAzImitB632w+M+UFSmDcNrzFA5b2IU6EKAMiT1gj8Dlsa59K/Fl2T3zZobnbVEJi3q6g5ump0BQhT5F3E9pVB3oNSrjvFxKVO8Im4E0gYH60LJ5Opp8py+kZo2FTFBKBhGgcLMkez1XzkYgwMInHBpIvjlDSHd4I9tUTZZRC5QtSCh3g35m4ZTE3Y4ipPN/dDAQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=HqofmzV/7Oi4kavfo6tGjfhsAId1YaPEyrQipv9vqzg3lTfPkLoPhUt5t0cCy39w26p77cBFnrAGBq4+fmdycv4zSS7gPYdS5ZASW8LIIFli5kxT7L0JorzB4XseQ8nF+j2le4xHizOhRZgCL0sSiS7MHT6sx9fOJA9TJPMCd6gYRbyLw+4ETM5UnHZ8Mu2LMC0ATOWvLtd5Pq/eMKfXhuNAon+h4/rptZnZy+MHtKqXjsXYOD/N95Qa00WI/wnCztOsfvgUIiQ/Z8k9Snf/+A8jY/RYbpUlnisFxYwLHFkd/X8HMVZkGA50nu29QgP/5FdEQ/Glq5Fx+AmT8lYynw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MOpl/Kz4P21D4lxyp4+bnZUYPPqHJGxR83WaOXwNNR7QWObt2Ia0Rs8n7iQNP6KKcGvB5A/G9IZi6MntCKgFkehXdey7l4Y/+f8FOVmz9MGCYUb1NTFX1EFknpdERVXY2FwPD42r1rhQNnRL5eBy/hrUT3Bg3TbeyviRbtst+jg7qlnSOW1OzvacRcWcuXV0473AX0O5F9C3yBo4pRj/sndbJsNrINKrQ1tXEmAXO+JhLvwgGgMKCrfdVJd+rLy2iLkichSAc9qGx0YL3Am1Nfg/PiJ8k1nxN5fglkbePxr2WFtUFoqzzzMtU0LKhuz8s9NazL4DPVR+dAgelMa7vg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>
- Delivery-date: Sat, 22 Oct 2022 00:50:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYmuuJ09LC1x/2uEWs942YY/fNVK2FNeCAgABJdQCAAALGgICT+/QAgAAA3ZCAAAXcAIAApa8w
- Thread-topic: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
Hi Bertrand,
> -----Original Message-----
> From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
> Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
>
> Hi,
>
> > On 21 Oct 2022, at 15:40, Henry Wang <Henry.Wang@xxxxxxx> wrote:
> >
> > (+ Arm maintainers)
> >
> > Hi Oleksandr,
> >
> >> -----Original Message-----
> >> From: Oleksandr <olekstysh@xxxxxxxxx>
> >> Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
> >> Hello all.
> >> On 19.07.22 13:40, Jan Beulich wrote:
> >>> On 19.07.2022 12:32, Volodymyr Babchuk wrote:
> >>>> Jan Beulich <jbeulich@xxxxxxxx> writes:
> >>>>
> >>>>> On 18.07.2022 23:15, Volodymyr Babchuk wrote:
> >>>>>> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to
> >>>>>> iounmap(), but not added corresponding include.
> >>>>>>
> >>>>>> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses")
> >>>>> I don't think there's any active issue with the "missing" include:
> >>>>> That's only a problem once Arm has vPCI code enabled? In which
> >>>>> case I don't think a Fixes: tag is warranted.
> >>>> Fair enough. May I ask committer to drop this tag?
> >>> I had taken respective note already, in case I end up committing this.
> >>> But this is the last patch of the series, so I can only guess whether
> >>> it might be okay to go in ahead of the other three patches.
> >>>
> >>> Jan
> >>
> >>
> >> I am wondering, where this patch could be 4.17 material?
> >>
> >> The patch series seem to get stuck, but the current patch just adds a
> >> missing include to fix a build on Arm, so it is completely independent.
> >> I agree, there is no issue with the current code base as vPCI is
> >> disabled on Arm, so nothing to fix right now. But as PCI
> >> passthrough/vPCI on Arm is in the development stage, the developers
> >> enable that support in their builds. I think the risk is rather low than
> >> high.
> >
> > It seems reasonable to me, but I am curious about what Arm maintainers
> > and PCI maintainers think. From the history discussion in this thread I
> > think it is pretty safe to include this in 4.17. Thanks for the ping.
>
> I think this can safely go in for 4.17.
>
> Cheers
> Bertrand
Thanks for the feedback :) Feel free to add my:
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
>
> >
> > Kind regards,
> > Henry
> >
> >
> >>
> >>
> >>
> >> --
> >> Regards,
> >>
> >> Oleksandr Tyshchenko
>
|
