[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH for-4.17 v2 0/5] (v)pci: fixes related to memory decoding handling
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Wed, 26 Oct 2022 00:27:34 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TizVcDI5HtjKEM6LeLrJCwzea0cFMJJKYl5s7pVpJSY=; b=IpW5Rnnt6O6cxnFjuvM+3jYhg7WZz62f+vm7I5XXcUbn3gkntQXkG4zx+/vOJx8ToROoJjZJgShOnTtii3rYxxkc+JG5iqXmaCvaxiaWQmMEZ4hGCw6K20DQ3va4BVA6yfE8G4OCFbfnJRjrNVwHLrDvyNsKY0idYIHyNKtOP5CO+ItcdAsjjMgt+NPyQAke0CtbknCydFUFRUio8AAQW2eDCjDL0t38yqvSIxLUUyQwE+0mAVrcqFFkZb8znbxkjI+ZSxsKieSCUzEHkA2EsDRzfFCQGSktZ+kBX2cBH6ee0oVI1MSDRL+ahHcmehdfCRudiJwR1cpgIVhTSYODgA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TizVcDI5HtjKEM6LeLrJCwzea0cFMJJKYl5s7pVpJSY=; b=WtLgsjdYEilhXsyztv0fjAr18UHN0RwEJxTl54rfgELo+cpRXRYA6MnrIdp9AChNhi/NT1crwBuxXYeCBfLRM6BXeXNhuq61vTvDBD4CsqKQHhrk3Vkmmn2k3FqZ4gsEjFL+zs4L4fTuSSRMfPhQlc4J6+MCxUA1XKfp3w+u/27Tlw49W3La58tio4qw5Bjd32oh7Dt0Kkm/ge8Jbr9KBqVxkKuA77O0FhvCpNVNC4/Bu+0esCshVPNVJekcsB5w1o6nMVv6Q/OUYqJr07OwboF93jJya7DacQQ7gY5EQrYLWbpinhhw3r3E0wDNTVJuqigyO6dhZG2TVW2AVR16bg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=aeffBM68z0kIz9ad5V0JMPEWRxNrpc1MYhd/4okkcr+Q2G7O0h0fO03AEnR74+ZLX80kFRsMb+QIPbHRAgfSnkmdbmwGFyeWY8IdgkaBcaZH2kOEXYAivCh4lVprPgmTH4JgBokr4vnqb0me1CqdAEr8vv+nVeFAh6CFRzxz78np89HuWL3kT3VhdWig5h12L3V+L+JR9gXXbiOlbnLroFp7Fv/BLw5hk7tw8SGKde2KUvpHHM3qMP965Sl08uCIvITWh3djajyhNEMkKUej9TLnJVE3YFOFOMiaDS9ZGo8V3xkhZawFI1AusY/PloTdl6FMHFVhnm+pJQTXOb35fA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C3wF+qLQa2jTY5+P7XIMHVAXH0edlQITsePKfPOZR4NTmYwfGagLQuduVYmn423S/femoXZ1yhyTPNAbIWk6rO1sa7ffnYn9J6acNQJoW9Z48kMtlvc4pDKvM9x0mydk75gnAUmWV8tb+0Gm21uiWQCf0FJHnCupesQuGd5Z4cTy0pSm2460sgYyIEwJIlwwFLo5JDyrhxwvmB4sNAiwCIXX/l0uF6Va1T9/CHSp0OF19b54hqevok0300ErdcNsSsmfqEiI++fhh0S38PFSOeVwsV0p3S8FYpNuDWguNeNUxs82OiWS9qfnySK40Gm6ADNvXmzcfQbTSXYbIa57RQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Paul Durrant <paul@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 26 Oct 2022 00:27:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY6IBWBZfIV8vcxEqNmhmW2Z94164fNKeAgAAQKgCAAI0fAA==
- Thread-topic: [PATCH for-4.17 v2 0/5] (v)pci: fixes related to memory decoding handling
Hi Roger and Jan,
> -----Original Message-----
> From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Subject: Re: [PATCH for-4.17 v2 0/5] (v)pci: fixes related to memory decoding
> handling
>
> On Tue, Oct 25, 2022 at 05:02:41PM +0200, Jan Beulich wrote:
> > On 25.10.2022 16:44, Roger Pau Monne wrote:
> > > Hello,
> > >
> > > This patch series attempts to fix the regressions caused by 75cc460a1b
> > > ('xen/pci: detect when BARs are not suitably positioned') and the last
> > > patch relaxes the check done when attempting to write to BARs with
> > > memory decoding enabled.
> > >
> > > I consider all of them bug fixes, albeit the last patch is not fixing a
> > > regression (since vPCI code has always behaved this way).
> > >
> > > Thanks, Roger.
> > >
> > > Roger Pau Monne (5):
> > > vpci: don't assume that vpci per-device data exists unconditionally
> > > vpci/msix: remove from table list on detach
> > > vpci: introduce a local vpci_bar variable to modify_decoding()
> > > pci: do not disable memory decoding for devices
> > > vpci: refuse BAR writes only if the BAR is mapped
> >
> > Looks like you've lost Henry's release-ack that was given for all of v1
> > (i.e. only patch 2 isn't covered by it).
>
> I was worry about adding it again for the whole series (except patch
> 2), as I think release-acks are conditional to the time they are
> given. IOW: a release-ack given for a previous series sent maybe
> weeks ago shouldn't be carried over because conditions to get changes
> accepted might be tighter as we progress with the release.
Thanks for being considerate! The release ack still holds.
>
> I think Henry would be fine to reassess the suitability of the series
> once it gets properly Acked.
No problem, for the whole series (given that this is a bug fix series)
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
But a reminder: patch #4 and #5 need review/ack from maintainers.
Kind regards,
Henry
>
> Thanks, Roger.
|
