[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.17 v2 0/5] (v)pci: fixes related to memory decoding handling
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 25 Oct 2022 18:00:32 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iG5RKw1QfV4vTZomEBAa1AVdQ4I+aTGh9eZU5WCRjSY=; b=gTQGYOyYRaMpSVsjbr9BK5ejXbQSiJ8YSNKFMLLU3mXhI435PC2Y+WejKtuT/yHQgUD8BBwAUEUIZKPR+rTUoRs935Bf5qip25w2lcFwP6xGpNZ7oMODGmv3kBTEyuTLecjMcZ/ZYeR131HpApzevfomWfsxCPUf5bnRbRuKYuLMwC7EQMb9TKO0mYliDE0G+kJaV4o6XehfGWAabMBQOMA332wY3LQ2KLEbdq1AKhtDkAGsb+PIx+swgvUZw/eNY+Pj7WaDOHyX1xqhiS7W9Lzzx1gao2c7E8n1ct1cmR4VB9GRed9f5xxnxviQuNhITAjUyEGOavkuXYov1KFppA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l6Z8bXRHytt4AaSh0HyPA607/0nT9QCQMsx2jgKLurMGt/XBUY03OhDS+D52PGCeAGpVSrX7lGyHyp04BrqUNKQgw0eSI05jjvUUuHaraIqYZod4bXVTJDt0sbRzrkGOPKer1vsT++SypT815QKoGIlUq60tebcnOJqvAjZEBF1w9Pv/Di5u0rOQ2Zokx1mNZ8ESCpJI7NCZ9aVYx/AZi4z2fiUpQ8J75R1iFWZJMAZUYzi2RdrniqXU43zJqIYMlLe3TiJNK8yYcisTn7NqSJLp5cYdUBGbFDHGTFshyOQlu30+m2VBavstCgLbXpX0uJMxHUyY61ccMro8lpuZWQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Henry.Wang@xxxxxxx, Paul Durrant <paul@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 25 Oct 2022 16:00:47 +0000
- Ironport-data: A9a23:Mw2qC6kTLsI+I81OJwnLU93o5gywJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIXWWCHafvbMWKmeNx/PI+x9RhSvcDRnd9kGwI9qn83FSMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wRkOKgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfGW5w5 KExImE0Qkqdobyu+YmFcdZir5F2RCXrFNt3VnBI6xj8VK9ja7aTBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsy6KklwZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r83beexniiBur+EpW95PhPkGy23lUqCSYuUH6Xmdm/km2HDoc3x 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8Ua5QeX2+zr6gCWLmEeS3hKb9lOnNc/WDgCx lKP2dTzClRHoLCTDH6Q6LqQhTezIjQOa38PYzceSgkI6MWlp5s85i8jVf5mGa+xy9fzSTf5x mnTqDBk3utDy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDEhAzSJflhTBCwfdg=
- Ironport-hdrordr: A9a23:v+YvW6Gl8g5XVzTPpLqFDZHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LW90Y27MAvhHP9OkPAs1NKZMDUO11HJEGgP1/qA/9SkIVyEygc/79 YdT0EdMqyWMbESt6+TjmiF+pQbsb+6GciT9JrjJhxWPGVXgs9bnmVE4lHxKDwNeOAKP+tPKL Osou584xawc3Ueacq2QlEDQuj4vtXO0LbrewQPCRIL4BSHyWrA0s+yLzGomjMlFx9fy7Yr9m bI1yT/+6WYqvm+jjvRzXXa4Zh6kMbojvFDGMuPoM4ILSiEsHffWK1RH5m5+BwlquCm71gn1P HKvhcbJsx2r0jce2mkyCGdqTXI4XIL0TvP2FWYiXzsrYjSXzQhEfdMgopfb1/w91cglMsU6t MH40up875sST/QliX04NbFEztwkFCvnHYkmekPy1RCTIolbqNLp4B3xjIeLH45JlO01GkbKp ghMCmFj8wmMG9yLkqp9VWH+ebcEkjaRXy9Mwg/Us/86UkkoJk29Tpa+CUlpAZwyHsMceg62w 36CNUXqFhvdL5iUUsvPpZ0feKHTkrwfDnrDEW+ZXzaKYBvAQO8l3ew2sR82N2X
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Oct 25, 2022 at 05:02:41PM +0200, Jan Beulich wrote:
> On 25.10.2022 16:44, Roger Pau Monne wrote:
> > Hello,
> >
> > This patch series attempts to fix the regressions caused by 75cc460a1b
> > ('xen/pci: detect when BARs are not suitably positioned') and the last
> > patch relaxes the check done when attempting to write to BARs with
> > memory decoding enabled.
> >
> > I consider all of them bug fixes, albeit the last patch is not fixing a
> > regression (since vPCI code has always behaved this way).
> >
> > Thanks, Roger.
> >
> > Roger Pau Monne (5):
> > vpci: don't assume that vpci per-device data exists unconditionally
> > vpci/msix: remove from table list on detach
> > vpci: introduce a local vpci_bar variable to modify_decoding()
> > pci: do not disable memory decoding for devices
> > vpci: refuse BAR writes only if the BAR is mapped
>
> Looks like you've lost Henry's release-ack that was given for all of v1
> (i.e. only patch 2 isn't covered by it).
I was worry about adding it again for the whole series (except patch
2), as I think release-acks are conditional to the time they are
given. IOW: a release-ack given for a previous series sent maybe
weeks ago shouldn't be carried over because conditions to get changes
accepted might be tighter as we progress with the release.
I think Henry would be fine to reassess the suitability of the series
once it gets properly Acked.
Thanks, Roger.
|
